-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add delay wait-for-commissionee command #24298
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_WaitForCommissionee
Jan 10, 2023
Merged
[chip-tool] Add delay wait-for-commissionee command #24298
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_WaitForCommissionee
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24298: Size comparison from 7f668cd to bb1e1e9 Increases above 0.2%:
Increases (8 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, telink)
Decreases (8 builds for bl602, cc13x2_26x2, efr32, esp32, psoc6)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Jan 9, 2023
bzbarsky-apple
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The test runner usually starts with
WaitForCommissionee
. This command set up a case session between and in the case of the test runner updates some internal states to know the target of following steps.It is not strictly needed in
chip-tool
but I found it useful to time how long does it takes to recover the device and it makes the integration between the python runner andchip-tool
simpler.It is also a good alternative to the current
pairing close-session
command when the other side has been shutted down (which happens frequently when doing local tests)