-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some more safety improvements to dispatch to the Matter queue. #24084
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:safer-async-dispatch
Dec 14, 2022
Merged
Make some more safety improvements to dispatch to the Matter queue. #24084
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:safer-async-dispatch
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to minimize the number of places that have to have isRunning checks, and direct access to the Matter queue, by having APIs that do those for you.
woody-apple
approved these changes
Dec 14, 2022
PR #24084: Size comparison from 12ee5a2 to cd91443 Increases (6 builds for bl602, bl702, psoc6, telink)
Decreases (7 builds for bl702, cyw30739, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to minimize the number of places that have to have isRunning checks, and direct access to the Matter queue, by having APIs that do those for you.