-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename TEST_CLUSTER to match latest ZAP tool #23907
Merged
andy31415
merged 1 commit into
project-chip:master
from
Grundfos:rjosefsen/fix-test-cluster-naming
Dec 5, 2022
Merged
Rename TEST_CLUSTER to match latest ZAP tool #23907
andy31415
merged 1 commit into
project-chip:master
from
Grundfos:rjosefsen/fix-test-cluster-naming
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23907: Size comparison from 9c0ca13 to 13f24e4 Increases (10 builds for cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 5, 2022
andy31415
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest ZAP tool (v2022.11.29-nightly) uses UNIT_TESTING_CLUSTER for the test-cluster-server, older versions used TEST_CLUSTER. When modifying the all-cluster-app to support feature map on PCC cluster (#23824), the CI fails since it does not have UNIT_TESTING_CLUSTER in zap_cluster_list.py.
Rather then adding UNIT_TESTING_CLUSTER in zap_cluster_list.py, to make both UNIT_TESTING_CLUSTER and TEST_CLUSTER work, this PR updates all zap files previously using TEST_CLUSTER to UNIT_TESTING_CLUSTER, as well as the latest zap file version and updated zap_cluster_list.py to use UNIT_TESTING_CLUSTER.