Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "right" byte-swapping function for port in Darwin DnssdImpl. #23894

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Use the "right" byte-swapping function for port in Darwin DnssdImpl. #23894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaacb06
Use the "right" byte-swapping function for port in Darwin DnssdImpl.
bzbarsky-apple Dec 3, 2022
0802868
Merge branch 'master' into fix-endian-swap
andy31415 Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/Darwin/DnssdImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ CHIP_ERROR Register(void * context, DnssdPublishCallback callback, uint32_t inte
sdCtx->mHostNameRegistrar.Init(hostname, addressType, interfaceId);

DNSServiceRef sdRef;
auto err = DNSServiceRegister(&sdRef, kRegisterFlags, interfaceId, name, type, kLocalDot, hostname, ntohs(port), record.size(),
auto err = DNSServiceRegister(&sdRef, kRegisterFlags, interfaceId, name, type, kLocalDot, hostname, htons(port), record.size(),
record.data(), OnRegister, sdCtx);
VerifyOrReturnError(kDNSServiceErr_NoError == err, sdCtx->Finalize(err));

Expand Down