-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] check for WiFi interface name when obtaining its MAC address #23789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23789: Size comparison from 8f1136d to e966fa7 Increases (8 builds for bl602, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Nov 29, 2022
PR #23789: Size comparison from 5936031 to 6dbbd86 Increases (18 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Please run './scripts/helpers/restyle-diff.sh' to solve the restyled issue |
Prefer interface matching the WiFi interface name when obtaining WiFi MAC address. Fallback to use first non-loopback interface if no match is found.
Remote branch is messed up, will create a new PR on a new branch. |
PR #23789: Size comparison from ae9d1b2 to 3f4ae0b Increases (5 builds for linux, psoc6, telink)
Decreases (3 builds for esp32, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23788 [Platform] Properly obtain primary WiFi MAC address on Linux
Currently we're only checking for address not associated with the loopback
interface, which will be problematic for devices with multiple network interfaces.
So updated it to explicitly check for WiFi interface based on the interface name
specified in CHIPDeviceConfig.