-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CPP codegen at compile time #23614
Merged
andy31415
merged 22 commits into
project-chip:master
from
andy31415:cpp_codegen_callback_stubs
Nov 19, 2022
Merged
Support CPP codegen at compile time #23614
andy31415
merged 22 commits into
project-chip:master
from
andy31415:cpp_codegen_callback_stubs
Nov 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not FULLY match, but only minor diffs exist
…-stub to ensure no regressions
PR #23614: Size comparison from 6519b91 to 62c8500 Increases (8 builds for bl602, bl702, telink)
Decreases (2 builds for bl702)
Full report (16 builds for bl602, bl702, k32w, linux, qpg, telink)
|
PR #23614: Size comparison from 6519b91 to 0ed6188 Increases (13 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect)
Full report (46 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, linux, nrfconnect, qpg, telink)
|
PR #23614: Size comparison from 6519b91 to 8cfde15 Increases (14 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Decreases (13 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, psoc6)
Full report (63 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pan-
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ATmobica
approved these changes
Nov 16, 2022
PR #23614: Size comparison from d2ae082 to 068476d Increases (15 builds for bl702, cc13x2_26x2, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, linux, mbed, nrfconnect, psoc6)
Full report (63 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #23614: Size comparison from 3fa2104 to 2ebe26a Increases (15 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, k32w, linux, nrfconnect, psoc6)
Full report (63 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted callback_stubs.cpp because its content is the simplest.
This is to ensure our build system has the capability to codegen at compiletime - previous #23247 added header support (and setting up propper include pats), this PR adds CPP file support.
Changes:
Testing: