-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Synchronizing on the use of NsdManager.resolveService() #23549
Merged
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:fixit-20221108
Nov 10, 2022
Merged
tv-casting-app: Synchronizing on the use of NsdManager.resolveService() #23549
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:fixit-20221108
Nov 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23549: Size comparison from bda7a8c to 4314e23 Increases (8 builds for bl602, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (4 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Nov 9, 2022
andy31415
reviewed
Nov 9, 2022
examples/tv-casting-app/android/App/app/src/main/jni/com/chip/casting/AppParameters.java
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Nov 9, 2022
PR #23549: Size comparison from bda7a8c to 06ecfcc Increases above 0.2%:
Increases (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (20 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, qpg, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Nov 11, 2022
…() (project-chip#23549) * tv-casting-app: Synchronizing on the use of NsdManager.resolveService() * Making AppParameters.discriminator private
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…() (project-chip#23549) * tv-casting-app: Synchronizing on the use of NsdManager.resolveService() * Making AppParameters.discriminator private
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…() (project-chip#23549) * tv-casting-app: Synchronizing on the use of NsdManager.resolveService() * Making AppParameters.discriminator private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23514
Problem
Change summary
Testing
Tested with the tv-casting-apps running on Android and iOS, against the Linux tv-app