-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply API review fixes for MTRPersistentStorageDelegate.h. #23476
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22609
Nov 3, 2022
Merged
Apply API review fixes for MTRPersistentStorageDelegate.h. #23476
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22609
Nov 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-landing of PR project-chip#22609 but modified to preserve the old APIs. * Rename the protocol (and header). * Fix some comments.
4073da2
to
c0bc386
Compare
jtung-apple
approved these changes
Nov 3, 2022
PR #23476: Size comparison from 706e9bb to c0bc386 Increases (7 builds for cc13x2_26x2, esp32, qpg, telink)
Decreases (9 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ksperling-apple
approved these changes
Nov 3, 2022
Fast tracking platform-specific change with platform owner review. |
PR #23476: Size comparison from 706e9bb to 60642ce Increases above 0.2%:
Increases (21 builds for bl702, cc13x2_26x2, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…hip#23476) * Apply API review fixes for MTRPersistentStorageDelegate.h. This is a re-landing of PR project-chip#22609 but modified to preserve the old APIs. * Rename the protocol (and header). * Fix some comments. * Address review comment.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…hip#23476) * Apply API review fixes for MTRPersistentStorageDelegate.h. This is a re-landing of PR project-chip#22609 but modified to preserve the old APIs. * Rename the protocol (and header). * Fix some comments. * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-landing of PR #22609 but modified to preserve the old APIs.