clang-tidy: apply modernize-loop-convert over a set of files #23443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-chip-tool-clang/compile_commands.json --export-fixes out/fixes.xml fix ```
``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-all-clusters-clang/compile_commands.json --export-fixes out/fixes.xml fix ```
``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-tests-clang/compile_commands.json --export-fixes out/fixes.xml fix ```
|
PR #23443: Size comparison from 5030df4 to 8b3d1e3 Increases (4 builds for bl702, linux)
Decreases (14 builds for bl602, bl702, k32w, qpg, telink)
Full report (17 builds for bl602, bl702, k32w, linux, mbed, qpg, telink)
|
|
PR #23443: Size comparison from 5030df4 to ef77554 Increases (2 builds for bl702)
Decreases (16 builds for bl602, bl702, k32w, nrfconnect, qpg, telink)
Full report (17 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg, telink)
|
|
PR #23443: Size comparison from 5030df4 to 5b736b5 Increases (14 builds for bl702, cc13x2_26x2, linux, psoc6)
Decreases (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Nov 2, 2022
src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.cpp
Outdated
Show resolved
Hide resolved
@bzbarsky-apple went manually through the changes and used more sane names. Also converted a setter to take a const array to make a const-correctness test better. Overall same change, but with saner names now I hope. Did not try hard for converting auto to const auto &, however some where converted. I am going for "this is slightly better than before". |
|
PR #23443: Size comparison from 90453bf to 91ce0ae Increases (14 builds for bl702, cc13x2_26x2, linux, psoc6)
Decreases (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Nov 3, 2022
|
Do we want to update |
I was unsure if forcing to use loop is something that we want everywhere. My instinct was that this does not always feel natural, but at the same time I 100% accepted all automated changes. Would welcome opinions from reviewers here if we should change clang-tidy to enforce or not. Change in BleLayer.cpp was questionable: had to make a static_assert to make the intent clear: seemingly unrelated constants meant |
bzbarsky-apple
approved these changes
Nov 3, 2022
|
PR #23443: Size comparison from 706e9bb to 669d4f8 Increases (4 builds for bl702, linux)
Decreases (9 builds for bl702, k32w, nrfconnect, qpg)
Full report (12 builds for bl702, k32w, linux, mbed, nrfconnect, qpg)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…-chip#23443) * Modernize using: ``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-chip-tool-clang/compile_commands.json --export-fixes out/fixes.xml fix ``` * Fix using: ``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-all-clusters-clang/compile_commands.json --export-fixes out/fixes.xml fix ``` * Modernize using: ``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-tests-clang/compile_commands.json --export-fixes out/fixes.xml fix ``` * Restyle and remove unused variable * Remove more unused variables for array sizes * Restyle * Start some manual renames of iteration values ... automated tool is quite silly * More manual updates for naming of things. Code should be cleaner now * Restyle * Enforce lowercase naming for cdSigningKey iterator variable * One more pass for cleanups Co-authored-by: Andrei Litvin <andreilitvin@google.com>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…-chip#23443) * Modernize using: ``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-chip-tool-clang/compile_commands.json --export-fixes out/fixes.xml fix ``` * Fix using: ``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-all-clusters-clang/compile_commands.json --export-fixes out/fixes.xml fix ``` * Modernize using: ``` ./scripts/run-clang-tidy-on-compile-commands.py --checks modernize-loop-convert --compile-database out/linux-x64-tests-clang/compile_commands.json --export-fixes out/fixes.xml fix ``` * Restyle and remove unused variable * Remove more unused variables for array sizes * Restyle * Start some manual renames of iteration values ... automated tool is quite silly * More manual updates for naming of things. Code should be cleaner now * Restyle * Enforce lowercase naming for cdSigningKey iterator variable * One more pass for cleanups Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied a
modernize-loop-convertusing chip-tool, all-clusters and tests as the sources of files to compile.