-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add the setupCommissioningSessionWithPayload API on MTRDeviceController. #23159
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-PASE-with-setup-payload
Oct 13, 2022
Merged
Re-add the setupCommissioningSessionWithPayload API on MTRDeviceController. #23159
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-PASE-with-setup-payload
Oct 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23159: Size comparison from 910218a to 6a446ee Increases (3 builds for bl602, psoc6)
Decreases (5 builds for bl602, psoc6, telink)
Full report (24 builds for bl602, bl702, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…oller. This is a re-landing of some of the API addition parts of project-chip#22596 and project-chip#22566, without including any of the API changes/removals. The code is nearly identical to what was on master before Darwin framework changes were reverted in project-chip#23155; the differences have to do with the different type and name of MTRSetupPayload's rendezvousInformation.
6a446ee
to
330bbbc
Compare
PR #23159: Size comparison from 2c9cd92 to 330bbbc Increases (9 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
anush-apple
approved these changes
Oct 13, 2022
Fast-tracking platform change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-landing of some of the API addition parts of
#22596 and
#22566, without including
any of the API changes/removals. The code is nearly identical to what was on
master before Darwin framework changes were reverted in
#23155; the differences have
to do with the different type and name of MTRSetupPayload's
rendezvousInformation.