Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SessionDelegate::OnSessionHang docs header #22928

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Fix SessionDelegate::OnSessionHang docs header #22928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/transport/SessionDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,8 @@ class DLL_EXPORT SessionDelegate

/**
* @brief
* Called when a session is unresponsive for a while (detected by MRP)
*
* Note: the implementation must not do anything that will destroy the session or change the SessionHolder.
* Called when a session is unresponsive for a while (detected by MRP). Callees SHALL NOT make synchronous calls into
* SessionManager to allocate a new session. If they desire to do so, it MUST be done asynchronously.
*/
virtual void OnSessionHang() {}
};
Expand Down