-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android/Java]event should be stored in array for java/android #22909
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_java_event_store
Sep 28, 2022
Merged
[Android/Java]event should be stored in array for java/android #22909
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_java_event_store
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31fd639
to
b3fb892
Compare
andy31415
reviewed
Sep 27, 2022
b3fb892
to
613cbe9
Compare
andy31415
approved these changes
Sep 27, 2022
PR #22909: Size comparison from 259feae to 613cbe9 Decreases (2 builds for bl702, telink)
Full report (7 builds for bl702, qpg, telink)
|
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
Store IM events in array instead of map since we might receive a burst of events, and we don't wanna lose those event info.