Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android/Java]event should be stored in array for java/android #22909

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Sep 27, 2022

Issue Being Resolved

Change overview

Store IM events in array instead of map since we might receive a burst of events, and we don't wanna lose those event info.

@yunhanw-google yunhanw-google force-pushed the feature/fix_java_event_store branch from b3fb892 to 613cbe9 Compare September 27, 2022 19:01
@github-actions
Copy link

PR #22909: Size comparison from 259feae to 613cbe9

Decreases (2 builds for bl702, telink)
platform target config section 259feae 613cbe9 change % change
bl702 lighting-app bl702 .debug_info 37899568 37899567 -1 -0.0
.text 956552 956550 -2 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 814500 814492 -8 -0.0
text 574574 574572 -2 -0.0
Full report (7 builds for bl702, qpg, telink)
platform target config section 259feae 613cbe9 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1187963 1187963 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67094 67094 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506903 1506903 0 0.0
.debug_aranges 133080 133080 0 0.0
.debug_frame 486372 486372 0 0.0
.debug_info 37899568 37899567 -1 -0.0
.debug_line 5252792 5252792 0 0.0
.debug_loc 3364396 3364396 0 0.0
.debug_ranges 359104 359104 0 0.0
.debug_str 3456111 3456111 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116536 116536 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564835 564835 0 0.0
.symtab 171584 171584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 956552 956550 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1283883 1283883 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75142 75142 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644448 1644448 0 0.0
.debug_aranges 140584 140584 0 0.0
.debug_frame 511748 511748 0 0.0
.debug_info 41806178 41806178 0 0.0
.debug_line 5627327 5627327 0 0.0
.debug_loc 3557140 3557140 0 0.0
.debug_ranges 381560 381560 0 0.0
.debug_str 3852011 3852011 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129928 129928 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624008 624008 0 0.0
.symtab 189392 189392 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030254 1030254 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1146272 1146272 0 0.0
.bss 110544 110544 0 0.0
.data 1028 1028 0 0.0
.text 593368 593368 0 0.0
lock-app qpg6105+debug (read/write) 1116164 1116164 0 0.0
.bss 106376 106376 0 0.0
.data 1032 1032 0 0.0
.text 563264 563264 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814500 814492 -8 -0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574574 574572 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 836604 836604 0 0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592794 592794 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844556 844556 0 0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 598976 598976 0 0.0

@yunhanw-google yunhanw-google enabled auto-merge (squash) September 27, 2022 20:05
@yunhanw-google yunhanw-google merged commit 3b48c2c into project-chip:master Sep 28, 2022
sharad-patil24 pushed a commit to sharad-patil24/connectedhomeip that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android/Java]IM events should be stored in array
2 participants