Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin dbus-python to correct version for arm64 build #22630

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Pin dbus-python to correct version for arm64 build #22630

merged 1 commit into from
Sep 14, 2022

Conversation

woody-apple
Copy link
Contributor

Issue Being Resolved

Fixes #22613

  • dbus-python was updated on Sep 6 2022 to 1.3.0.
  • This change caused issues with arm64 build of python controller

Change overview

  • Pin version 1.2.18, which was tested to work and was the default before.

Testing done:

  • Built successfully with prior version known to work
  • Can run tests

@tcarmelveilleux @web-flow
Pin dbus-python to correct version (#22624)
ba96c4d 
- dbus-python was updated on Sep 6 2022 to 1.3.0.
- This change caused issues with arm64 build of python controller

This PR changes pinned version 1.2.18, the version most tested by
Python scripts up to now (used to be the default highest).

Fixes #22613

Testing done:
- Built successfully with prior version known to work
- Can run tests
@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

PR #22630: Size comparison from 0f593d2 to ba96c4d

Increases (2 builds for cc13x2_26x2, nrfconnect)
platform target config section 0f593d2 ba96c4d change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 666010 666018 8 0.0
.text 579884 579892 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814168 814172 4 0.0
Decreases (4 builds for bl602, cc13x2_26x2, telink)
platform target config section 0f593d2 ba96c4d change % change
bl602 lighting-app bl602 .text 1051052 1051048 -4 -0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 181028 181020 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 808808 808800 -8 -0.0
text 571352 571348 -4 -0.0
lighting-app tlsr9518adk80d text 589476 589472 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0f593d2 ba96c4d change % change
bl602 lighting-app bl602 (read/write) 1383898 1383898 0 0.0
.bss 120290 120290 0 0.0
.data 4480 4480 0 0.0
.text 1051052 1051048 -4 -0.0
bl602+rpc (read/write) 1429410 1429410 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1082808 1082808 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673103 673103 0 0.0
(read/write) 178424 178424 0 0.0
.bss 74420 74420 0 0.0
.data 3372 3372 0 0.0
.rodata 88759 88759 0 0.0
.text 584028 584028 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 638487 638487 0 0.0
(read/write) 157996 157996 0 0.0
.bss 73708 73708 0 0.0
.data 3372 3372 0 0.0
.rodata 77991 77991 0 0.0
.text 560172 560172 0 0.0
lock-ftd LP_CC2652R7 (read only) 674859 674859 0 0.0
(read/write) 166884 166884 0 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 76683 76683 0 0.0
.text 597696 597696 0 0.0
lock-mtd LP_CC2652R7 (read only) 657595 657595 0 0.0
(read/write) 179836 179836 0 0.0
.bss 67212 67212 0 0.0
.data 3296 3296 0 0.0
.rodata 101771 101771 0 0.0
.text 555344 555344 0 0.0
pump-app LP_CC2652R7 (read only) 685531 685531 0 0.0
(read/write) 157020 157020 0 0.0
.bss 71564 71564 0 0.0
.data 3296 3296 0 0.0
.rodata 89971 89971 0 0.0
.text 595076 595076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 670023 670023 0 0.0
(read/write) 172648 172648 0 0.0
.bss 71684 71684 0 0.0
.data 3292 3292 0 0.0
.rodata 85527 85527 0 0.0
.text 584016 584016 0 0.0
shell LP_CC2652R7 (read only) 666010 666018 8 0.0
(read/write) 181028 181020 -8 -0.0
.bss 76732 76732 0 0.0
.data 3376 3376 0 0.0
.rodata 85810 85810 0 0.0
.text 579884 579892 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586118 586118 0 0.0
.app_xip_area 462752 462752 0 0.0
.bss 65800 65800 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591894 591894 0 0.0
.app_xip_area 463744 463744 0 0.0
.bss 70584 70584 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599026 599026 0 0.0
.app_xip_area 476380 476380 0 0.0
.bss 65112 65112 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1103948 1103948 0 0.0
.bss 136148 136148 0 0.0
.data 2068 2068 0 0.0
.text 965708 965708 0 0.0
BRD4161A+rpc (read/write) 1158216 1158216 0 0.0
.bss 152836 152836 0 0.0
.data 2280 2280 0 0.0
.text 1003080 1003080 0 0.0
BRD4161A+rs911x (read/write) 996624 996624 0 0.0
.bss 168912 168912 0 0.0
.data 2056 2056 0 0.0
.text 825636 825636 0 0.0
lock-app BRD4161A+wf200 (read/write) 1145900 1145900 0 0.0
.bss 151992 151992 0 0.0
.data 2064 2064 0 0.0
.text 991824 991824 0 0.0
window-app BRD4161A (read/write) 1095356 1095356 0 0.0
.bss 137588 137588 0 0.0
.data 2096 2096 0 0.0
.text 955652 955652 0 0.0
esp32 all-clusters-app c3devkit (read only) 1030022 1030022 0 0.0
(read/write) 1488674 1488674 0 0.0
.dram0.bss 70864 70864 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217776 217776 0 0.0
.flash.text 1030022 1030022 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1083387 1083387 0 0.0
(read/write) 490632 490632 0 0.0
.dram0.bss 76376 76376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248116 248116 0 0.0
.flash.text 1078003 1078003 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645524 645524 0 0.0
.bss 70232 70232 0 0.0
.data 2044 2044 0 0.0
.text 570520 570520 0 0.0
lock k32w0+release (read/write) 703044 703044 0 0.0
.bss 70704 70704 0 0.0
.data 2052 2052 0 0.0
.text 627560 627560 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10308476 10308476 0 0.0
(read/write) 704593 704593 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649248 649248 0 0.0
.dynamic 560 560 0 0.0
.got 13816 13816 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 500300 500300 0 0.0
.text 8157108 8157108 0 0.0
thermostat-no-ble arm64 (read only) 2356916 2356916 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140524 140524 0 0.0
.text 1978672 1978672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215076 215076 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180147 1180147 0 0.0
bss 143759 143759 0 0.0
rodata 143268 143268 0 0.0
text 814168 814172 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160023 1160023 0 0.0
bss 142996 142996 0 0.0
rodata 134944 134944 0 0.0
text 803160 803160 0 0.0
p6 all-clusters-app default (read only) 842104 842104 0 0.0
(read/write) 1738996 1738996 0 0.0
.bss 188584 188584 0 0.0
.data 2656 2656 0 0.0
.text 1539368 1539368 0 0.0
all-clusters-minimal-app default (read only) 842824 842824 0 0.0
(read/write) 1683004 1683004 0 0.0
.bss 187864 187864 0 0.0
.data 2656 2656 0 0.0
.text 1484096 1484096 0 0.0
light-app default (read only) 851168 851168 0 0.0
(read/write) 1600292 1600292 0 0.0
.bss 179728 179728 0 0.0
.data 2448 2448 0 0.0
.text 1409728 1409728 0 0.0
lock-app default (read only) 846136 846136 0 0.0
(read/write) 1638012 1638012 0 0.0
.bss 184744 184744 0 0.0
.data 2464 2464 0 0.0
.text 1442416 1442416 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808808 808800 -8 -0.0
bss 71480 71480 0 0.0
noinit 43488 43488 0 0.0
text 571352 571348 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 830776 830776 0 0.0
bss 72336 72336 0 0.0
noinit 43488 43488 0 0.0
text 589476 589472 -4 -0.0

@woody-apple woody-apple merged commit 52a995a into sve-2 Sep 14, 2022
@woody-apple woody-apple deleted the cherry-pick-f4f81f2af86fc907ff60bf4975419d5883b4b11b branch September 14, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
controller scripts sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @tcarmelveilleux