-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: update build_python_device.sh to use chip-core #22494
Merged
andy31415
merged 2 commits into
project-chip:master
from
sandeepmistry:python-device-build-script-fix
Sep 14, 2022
Merged
python: update build_python_device.sh to use chip-core #22494
andy31415
merged 2 commits into
project-chip:master
from
sandeepmistry:python-device-build-script-fix
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22494: Size comparison from 0e3bbae to 2d82c4d Increases (7 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, qpg)
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Sep 8, 2022
Damian-Nordic
approved these changes
Sep 12, 2022
tcarmelveilleux
approved these changes
Sep 12, 2022
mrjerryjohns
approved these changes
Sep 14, 2022
Accepted for 1.0: script change only. |
PR #22494: Size comparison from 8c4675f to 3da11cc Increases (6 builds for bl602, cc13x2_26x2, esp32, psoc6, qpg)
Decreases (3 builds for cc13x2_26x2, esp32, qpg)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…t-chip#22494) Co-authored-by: Jerry Johns <johnsj@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Closes #22627
Change overview
As discussed in the second half of #21969 (comment),
scripts/build_python_device.sh
should be updated to usechip-core
instead ofchip-library
.cc/ @mrjerryjohns
NOTE: this change does not address the core dump mentioned in the original issue and my latest comment: #21969 (comment)