-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation for chip-app1 commisioning. #22332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR project-chip#15801 changed the port to 5543, but the documentation was not updated. Just use "pairing code" to avoid problems like that. Fixes project-chip#22312
c481ddd
to
034a79e
Compare
PR #22332: Size comparison from 7894428 to 034a79e Increases (4 builds for esp32, qpg, telink)
Decreases (4 builds for bl602, esp32, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Sep 1, 2022
Damian-Nordic
approved these changes
Sep 1, 2022
The command |
andy31415
approved these changes
Sep 1, 2022
Documentation change, accepted for master. |
andy31415
reviewed
Sep 1, 2022
Yes, good catch! |
PR #22332: Size comparison from 7894428 to 55167ff Increases (6 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
Decreases (3 builds for cc13x2_26x2, esp32, k32w)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Fix documentation for chip-app1 commisioning. PR project-chip#15801 changed the port to 5543, but the documentation was not updated. Just use "pairing code" to avoid problems like that. Fixes project-chip#22312 * Fix review comments: add missing node id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #15801 changed the port to 5543, but the documentation was not updated. Just
use "pairing code" to avoid problems like that.
Fixes #22312
Problem
Wrong documentation. Port is wrong, and the extra CommissioningComplete is not needed (and in fact would fail).
Change overview
Fix the docs.