Use a separate execution thread to disable the OpenThread interface #22315

selissia · 2022-08-31T18:03:40Z

Problem

If ScanNetorks command is sent as a part of commissioning a Thread device the device crashes. Issue is seen on an EFR32 board BRD4186C.

Currently the chip-tool does not issue ScanNetorks during Thread commissioning but it is a valid thing to do and some device manufacturers are planning to implement such logic. To force the issue build the commissioner with the following change:
in CommissioningParameters::SetThreadOperationalDataset() call MakeOptional with "true" instead of "false". Then commissioning the device onto a Thread network triggers a crash.

This is an OpenThread issue not specific to Matter.
OpenThread Ticket: openthread/openthread#8110
Matter ticket: #21248

For the root cause see the OpenThread ticket above. The summary is that the Discovery callback is invoked in the middle of
MeshForwarder::UpdateSendMessage() execution. If the callback directly disables the IPv6 Thread interface mSendMessage is set to NULL and the continuation of MeshForwarder::UpdateSendMessage() crashes when trying to access it.

Change overview

Use a separate execution thread to disable the OpenThread interface from the Discovery callback

Testing

Forced the crash using the procedure described above. Verified that the crash no longer happens with this fix

* Added new manual scripts * Added Auto generated File

* [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <commits@restyled.io>

selissia · 2022-08-31T18:07:44Z

@LuDuda and @Damian-Nordic please take a look if you get a chance

github-actions · 2022-08-31T18:29:16Z

PR #22315: Size comparison from 04eeef1 to 1f62d90

Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)

platform	target	config	section	`04eeef1`	`1f62d90`	change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	675071	675119	48
			.text	585528	585576	48
	all-clusters-minimal-app	LP_CC2652R7	(read only)	639775	639823	48
			.text	561080	561128	48
	lock-ftd	LP_CC2652R7	(read only)	676123	676171	48
			.text	598568	598616	48
	lock-mtd	LP_CC2652R7	(read only)	659091	659139	48
			.text	556272	556320	48
	pump-app	LP_CC2652R7	(read only)	684927	684975	48
			.text	594492	594540	48
	pump-controller-app	LP_CC2652R7	(read only)	669435	669491	56
			.text	583448	583504	56
	shell	LP_CC2652R7	(read only)	665866	665914	48
			.text	579764	579812	48
cyw30739	light	cyw930739m2evb_01	(read/write)	586746	586786	40
			.app_xip_area	463404	463444	40
	lock	cyw930739m2evb_01	(read/write)	592498	592538	40
			.app_xip_area	464372	464412	40
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	599530	599570	40
			.app_xip_area	476908	476948	40
efr32	lighting-app	BRD4161A	(read/write)	1107968	1108016	48
			.text	969544	969592	48
		BRD4161A+rpc	(read/write)	971844	971892	48
			.text	818728	818776	48
	window-app	BRD4161A	(read/write)	1099224	1099272	48
			.text	959336	959384	48
esp32	all-clusters-app	c3devkit	(read only)	`1033726`	1033728	2
			.flash.text	`1033726`	1033728	2
k32w	light	k32w0+release	(read/write)	648060	648108	48
			.text	572552	572600	48
	lock	k32w0+release	(read/write)	705064	705112	48
			.text	629100	629148	48
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180787	1180835	48
			text	814824	814872	48
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1159967	1160015	48
			text	803216	803260	44
psoc6	all-clusters-minimal	cy8ckit_062s2_43012	.debug_info	26445241	26445242	1
qpg	lighting-app	qpg6105+debug	(read/write)	`1129044`	1129092	48
			.text	576140	576188	48
	lock-app	qpg6105+debug	(read/write)	1100032	1100080	48
			.text	547132	547180	48
telink	light-switch-app	tlsr9518adk80d	(read/write)	808704	808744	40
			text	571302	571344	42
	lighting-app	tlsr9518adk80d	(read/write)	830604	830644	40
			text	589414	589456	42

Decreases (8 builds for bl602, cc13x2_26x2)

platform	target	config	section	`04eeef1`	`1f62d90`	change	% change
bl602	lighting-app	bl602	(read/write)	1385942	`1385934`	-8	-0.0
			.text	1052320	1052316	-4	-0.0
		bl602+rpc	.text	1084076	`1084072`	-4	-0.0
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read/write)	176336	176288	-48	-0.0
	lock-ftd	LP_CC2652R7	(read/write)	165596	165548	-48	-0.0
	lock-mtd	LP_CC2652R7	(read/write)	178316	178268	-48	-0.0
	pump-app	LP_CC2652R7	(read/write)	157496	157448	-48	-0.0
	pump-controller-app	LP_CC2652R7	(read/write)	173100	173044	-56	-0.0
	shell	LP_CC2652R7	(read/write)	181060	181012	-48	-0.0

Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)

platform	target	config	section	`04eeef1`	`1f62d90`	change	% change
bl602	lighting-app	bl602	(read/write)	1385942	`1385934`	-8	-0.0
			.bss	120298	120298	0	0.0
			.data	4488	4488	0	0.0
			.text	1052320	1052316	-4	-0.0
		bl602+rpc	(read/write)	`1431582`	`1431582`	0	0.0
			.bss	127730	127730	0	0.0
			.data	4600	4600	0	0.0
			.text	1084076	`1084072`	-4	-0.0
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	675071	675119	48	0.0
			(read/write)	176336	176288	-48	-0.0
			.bss	74300	74300	0	0.0
			.data	3380	3380	0	0.0
			.rodata	89231	89231	0	0.0
			.text	585528	585576	48	0.0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	639775	639823	48	0.0
			(read/write)	157868	157868	0	0.0
			.bss	73572	73572	0	0.0
			.data	3380	3380	0	0.0
			.rodata	78375	78375	0	0.0
			.text	561080	561128	48	0.0
	lock-ftd	LP_CC2652R7	(read only)	676123	676171	48	0.0
			(read/write)	165596	165548	-48	-0.0
			.bss	71500	71500	0	0.0
			.data	3304	3304	0	0.0
			.rodata	77075	77075	0	0.0
			.text	598568	598616	48	0.0
	lock-mtd	LP_CC2652R7	(read only)	659091	659139	48	0.0
			(read/write)	178316	178268	-48	-0.0
			.bss	67188	67188	0	0.0
			.data	3304	3304	0	0.0
			.rodata	102339	102339	0	0.0
			.text	556272	556320	48	0.0
	pump-app	LP_CC2652R7	(read only)	684927	684975	48	0.0
			(read/write)	157496	157448	-48	-0.0
			.bss	71436	71436	0	0.0
			.data	3296	3296	0	0.0
			.rodata	89951	89951	0	0.0
			.text	594492	594540	48	0.0
	pump-controller-app	LP_CC2652R7	(read only)	669435	669491	56	0.0
			(read/write)	173100	173044	-56	-0.0
			.bss	71548	71548	0	0.0
			.data	3292	3292	0	0.0
			.rodata	85507	85507	0	0.0
			.text	583448	583504	56	0.0
	shell	LP_CC2652R7	(read only)	665866	665914	48	0.0
			(read/write)	181060	181012	-48	-0.0
			.bss	76620	76620	0	0.0
			.data	3376	3376	0	0.0
			.rodata	85786	85786	0	0.0
			.text	579764	579812	48	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	586746	586786	40	0.0
			.app_xip_area	463404	463444	40	0.0
			.bss	65776	65776	0	0.0
			.data	744	744	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	592498	592538	40	0.0
			.app_xip_area	464372	464412	40	0.0
			.bss	70560	70560	0	0.0
			.data	748	748	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	599530	599570	40	0.0
			.app_xip_area	476908	476948	40	0.0
			.bss	65088	65088	0	0.0
			.data	716	716	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read/write)	1107968	1108016	48	0.0
			.bss	136332	136332	0	0.0
			.data	2072	2072	0	0.0
			.text	969544	969592	48	0.0
		BRD4161A+rpc	(read/write)	971844	971892	48	0.0
			.bss	150844	150844	0	0.0
			.data	2252	2252	0	0.0
			.text	818728	818776	48	0.0
		BRD4161A+rs911x	(read/write)	`1001708`	`1001708`	0	0.0
			.bss	169168	169168	0	0.0
			.data	2064	2064	0	0.0
			.text	830456	830456	0	0.0
	lock-app	BRD4161A+wf200	(read/write)	1150008	1150008	0	0.0
			.bss	152248	152248	0	0.0
			.data	2072	2072	0	0.0
			.text	995668	995668	0	0.0
	window-app	BRD4161A	(read/write)	1099224	1099272	48	0.0
			.bss	137772	137772	0	0.0
			.data	2096	2096	0	0.0
			.text	959336	959384	48	0.0
esp32	all-clusters-app	c3devkit	(read only)	`1033726`	1033728	2	0.0
			(read/write)	1493518	1493518	0	0.0
			.dram0.bss	71120	71120	0	0.0
			.dram0.data	13696	13696	0	0.0
			.flash.rodata	218032	218032	0	0.0
			.flash.text	`1033726`	1033728	2	0.0
			.iram0.text	65204	65204	0	0.0
		m5stack	(read only)	1086083	1086083	0	0.0
			(read/write)	490804	490804	0	0.0
			.dram0.bss	76640	76640	0	0.0
			.dram0.data	34152	34152	0	0.0
			.flash.rodata	247344	247344	0	0.0
			.flash.text	1080699	1080699	0	0.0
			.iram0.text	123939	123939	0	0.0
k32w	light	k32w0+release	(read/write)	648060	648108	48	0.0
			.bss	70712	70712	0	0.0
			.data	2068	2068	0	0.0
			.text	572552	572600	48	0.0
	lock	k32w0+release	(read/write)	705064	705112	48	0.0
			.bss	71160	71160	0	0.0
			.data	2076	2076	0	0.0
			.text	629100	629148	48	0.0
linux	all-clusters-app	debug	(read only)	3043945	3043945	0	0.0
			(read/write)	156032	156032	0	0.0
			.bss	61792	61792	0	0.0
			.data	2096	2096	0	0.0
			.data.rel.ro	85768	85768	0	0.0
			.dynamic	608	608	0	0.0
			.got	4568	4568	0	0.0
			.init	27	27	0	0.0
			.init_array	1176	1176	0	0.0
			.rodata	275307	275307	0	0.0
			.text	2589202	2589202	0	0.0
	all-clusters-minimal-app	debug	(read only)	2879745	2879745	0	0.0
			(read/write)	147632	147632	0	0.0
			.bss	61024	61024	0	0.0
			.data	2064	2064	0	0.0
			.data.rel.ro	78264	78264	0	0.0
			.dynamic	608	608	0	0.0
			.got	4488	4488	0	0.0
			.init	27	27	0	0.0
			.init_array	1160	1160	0	0.0
			.rodata	275467	275467	0	0.0
			.text	2427618	2427618	0	0.0
	bridge-app	debug+rpc	(read only)	2378009	2378009	0	0.0
			(read/write)	127752	127752	0	0.0
			.bss	50656	50656	0	0.0
			.data	3600	3600	0	0.0
			.data.rel.ro	67640	67640	0	0.0
			.dynamic	608	608	0	0.0
			.got	4392	4392	0	0.0
			.init	27	27	0	0.0
			.init_array	832	832	0	0.0
			.rodata	204168	204168	0	0.0
			.text	2010930	2010930	0	0.0
	chip-tool	debug	(read only)	10910801	10910801	0	0.0
			(read/write)	657384	657384	0	0.0
			.bss	25240	25240	0	0.0
			.data	3266	3266	0	0.0
			.data.rel.ro	622352	622352	0	0.0
			.dynamic	608	608	0	0.0
			.got	5096	5096	0	0.0
			.init	27	27	0	0.0
			.init_array	776	776	0	0.0
			.rodata	564277	564277	0	0.0
			.text	`8825684`	`8825684`	0	0.0
	chip-tool-ipv6only	arm64	(read only)	10291460	10291460	0	0.0
			(read/write)	705217	705217	0	0.0
			.bss	33297	33297	0	0.0
			.data	3280	3280	0	0.0
			.data.rel.ro	649832	649832	0	0.0
			.dynamic	560	560	0	0.0
			.got	13840	13840	0	0.0
			.init	24	24	0	0.0
			.init_array	200	200	0	0.0
			.rodata	494724	494724	0	0.0
			.text	8144292	8144292	0	0.0
	lighting-app	debug+rpc	(read only)	2602937	2602937	0	0.0
			(read/write)	130536	130536	0	0.0
			.bss	49792	49792	0	0.0
			.data	2096	2096	0	0.0
			.data.rel.ro	72680	72680	0	0.0
			.dynamic	608	608	0	0.0
			.got	4392	4392	0	0.0
			.init	27	27	0	0.0
			.init_array	928	928	0	0.0
			.rodata	221008	221008	0	0.0
			.text	2210738	2210738	0	0.0
	lock-app	debug	(read only)	2585905	2585905	0	0.0
			(read/write)	125712	125712	0	0.0
			.bss	48288	48288	0	0.0
			.data	1712	1712	0	0.0
			.data.rel.ro	69688	69688	0	0.0
			.dynamic	608	608	0	0.0
			.got	4464	4464	0	0.0
			.init	27	27	0	0.0
			.init_array	904	904	0	0.0
			.rodata	238000	238000	0	0.0
			.text	2180962	2180962	0	0.0
	ota-provider-app	debug	(read only)	2363161	2363161	0	0.0
			(read/write)	119144	119144	0	0.0
			.bss	47808	47808	0	0.0
			.data	1936	1936	0	0.0
			.data.rel.ro	63512	63512	0	0.0
			.dynamic	608	608	0	0.0
			.got	4488	4488	0	0.0
			.init	27	27	0	0.0
			.init_array	768	768	0	0.0
			.rodata	209976	209976	0	0.0
			.text	1989426	1989426	0	0.0
	ota-requestor-app	debug	(read only)	2528409	2528409	0	0.0
			(read/write)	127552	127552	0	0.0
			.bss	50368	50368	0	0.0
			.data	2304	2304	0	0.0
			.data.rel.ro	68920	68920	0	0.0
			.dynamic	608	608	0	0.0
			.got	4480	4480	0	0.0
			.init	27	27	0	0.0
			.init_array	856	856	0	0.0
			.rodata	216704	216704	0	0.0
			.text	2138802	2138802	0	0.0
	shell	debug	(read only)	2612249	2612249	0	0.0
			(read/write)	142184	142184	0	0.0
			.bss	57704	57704	0	0.0
			.data	1264	1264	0	0.0
			.data.rel.ro	77376	77376	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	1048	1048	0	0.0
			.rodata	235410	235410	0	0.0
			.text	`2218130`	`2218130`	0	0.0
	thermostat-no-ble	arm64	(read only)	`2361956`	`2361956`	0	0.0
			(read/write)	141857	141857	0	0.0
			.bss	55233	55233	0	0.0
			.data	1680	1680	0	0.0
			.data.rel.ro	76112	76112	0	0.0
			.dynamic	560	560	0	0.0
			.got	5056	5056	0	0.0
			.init	24	24	0	0.0
			.init_array	416	416	0	0.0
			.rodata	141276	141276	0	0.0
			.text	1982640	1982640	0	0.0
	tv-app	debug	(read only)	`3190409`	`3190409`	0	0.0
			(read/write)	258040	258040	0	0.0
			.bss	167352	167352	0	0.0
			.data	4752	4752	0	0.0
			.data.rel.ro	79368	79368	0	0.0
			.dynamic	608	608	0	0.0
			.got	4856	4856	0	0.0
			.init	27	27	0	0.0
			.init_array	1080	1080	0	0.0
			.rodata	259976	259976	0	0.0
			.text	2740402	2740402	0	0.0
	tv-casting-app	debug	(read only)	5509633	5509633	0	0.0
			(read/write)	160536	160536	0	0.0
			.bss	51352	51352	0	0.0
			.data	2432	2432	0	0.0
			.data.rel.ro	100304	100304	0	0.0
			.dynamic	608	608	0	0.0
			.got	4776	4776	0	0.0
			.init	27	27	0	0.0
			.init_array	1048	1048	0	0.0
			.rodata	344945	344945	0	0.0
			.text	4892786	4892786	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2454936`	`2454936`	0	0.0
			.bss	215044	215044	0	0.0
			.data	5872	5872	0	0.0
			.text	1417580	1417580	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180787	1180835	48	0.0
			bss	143641	143641	0	0.0
			rodata	143380	143380	0	0.0
			text	814824	814872	48	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1159967	1160015	48	0.0
			bss	142868	142868	0	0.0
			rodata	134968	134968	0	0.0
			text	803216	803260	44	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	(read only)	841960	841960	0	0.0
			(read/write)	1742236	1742236	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	188720	188720	0	0.0
			.comment	204	204	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2664	2664	0	0.0
			.debug_abbrev	1221468	1221468	0	0.0
			.debug_aranges	111712	111712	0	0.0
			.debug_frame	372900	372900	0	0.0
			.debug_info	26708619	26708619	0	0.0
			.debug_line	3655730	3655730	0	0.0
			.debug_loc	3569692	3569692	0	0.0
			.debug_ranges	337616	337616	0	0.0
			.debug_str	3426920	3426920	0	0.0
			.heap	841960	841960	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	288	288	0	0.0
			.stab	156	156	0	0.0
			.stabstr	335	335	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	570576	570576	0	0.0
			.symtab	421488	421488	0	0.0
			.text	`1542464`	`1542464`	0	0.0
			.zero.table	8	8	0	0.0
			text	0	0	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	(read only)	842696	842696	0	0.0
			(read/write)	1685420	1685420	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	187984	187984	0	0.0
			.comment	204	204	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2664	2664	0	0.0
			.debug_abbrev	1213307	1213307	0	0.0
			.debug_aranges	111184	111184	0	0.0
			.debug_frame	375980	375980	0	0.0
			.debug_info	26445241	26445242	1	0.0
			.debug_line	3676246	3676246	0	0.0
			.debug_loc	`3557329`	`3557329`	0	0.0
			.debug_ranges	336232	336232	0	0.0
			.debug_str	3415925	3415925	0	0.0
			.heap	842696	842696	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	288	288	0	0.0
			.stab	156	156	0	0.0
			.stabstr	335	335	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	535050	535050	0	0.0
			.symtab	408080	408080	0	0.0
			.text	1486384	1486384	0	0.0
			.zero.table	0	0	0	0.0
				8	8	0	0.0
	light	cy8ckit_062s2_43012	(read only)	850928	850928	0	0.0
			(read/write)	1602700	1602700	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	179960	179960	0	0.0
			.comment	204	204	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2456	2456	0	0.0
			.debug_abbrev	1048126	1048126	0	0.0
			.debug_aranges	103360	103360	0	0.0
			.debug_frame	346248	346248	0	0.0
			.debug_info	21907524	21907524	0	0.0
			.debug_line	3246711	3246711	0	0.0
			.debug_loc	3255672	3255672	0	0.0
			.debug_ranges	301704	301704	0	0.0
			.debug_str	3221145	3221145	0	0.0
			.heap	850928	850928	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	288	288	0	0.0
			.stab	156	156	0	0.0
			.stabstr	335	335	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	468349	468349	0	0.0
			.symtab	375168	375168	0	0.0
			.text	1411896	1411896	0	0.0
			.zero.table	0	0	0	0.0
				8	8	0	0.0
	lock	cy8ckit_062s2_43012	(read only)	845896	845896	0	0.0
			(read/write)	1640380	1640380	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	184976	184976	0	0.0
			.comment	204	204	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2472	2472	0	0.0
			.debug_abbrev	1055561	1055561	0	0.0
			.debug_aranges	104032	104032	0	0.0
			.debug_frame	349076	349076	0	0.0
			.debug_info	22287271	22287271	0	0.0
			.debug_line	3255532	3255532	0	0.0
			.debug_loc	3295525	3295525	0	0.0
			.debug_ranges	305048	305048	0	0.0
			.debug_str	3248566	3248566	0	0.0
			.heap	845896	845896	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	288	288	0	0.0
			.stab	156	156	0	0.0
			.stabstr	335	335	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	474564	474564	0	0.0
			.symtab	378352	378352	0	0.0
			.text	1444544	1444544	0	0.0
			.zero.table	0	0	0	0.0
				8	8	0	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	`1129044`	1129092	48	0.0
			.bss	106112	106112	0	0.0
			.data	1028	1028	0	0.0
			.text	576140	576188	48	0.0
	lock-app	qpg6105+debug	(read/write)	1100032	1100080	48	0.0
			.bss	102344	102344	0	0.0
			.data	1032	1032	0	0.0
			.text	547132	547180	48	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	808704	808744	40	0.0
			bss	71344	71344	0	0.0
			noinit	43488	43488	0	0.0
			text	571302	571344	42	0.0
	lighting-app	tlsr9518adk80d	(read/write)	830604	830644	40	0.0
			bss	72200	72200	0	0.0
			noinit	43488	43488	0	0.0
			text	589414	589456	42	0.0

andy31415 · 2022-08-31T19:24:44Z

Accepted for master: fixing a potential crash

…roject-chip#22315) * Test added march 8 (project-chip#15957) * Added new manual scripts * Added Auto generated File * [OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981) * Regen to fix CI failures (project-chip#15990) * [ota] Store Default OTA Providers in flash (project-chip#15970) * [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <commits@restyled.io> * Disable OpenThread interface in a separate execution thread * Remove merge artifacts * Restyled by clang-format Co-authored-by: kowsisoundhar12 <57476670+kowsisoundhar12@users.noreply.github.com> Co-authored-by: Carol Yang <clyang@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>

kowsisoundhar12 and others added 30 commits March 8, 2022 22:28

Test added march 8 (project-chip#15957)

35fad7d

* Added new manual scripts * Added Auto generated File

[OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981)

d5f4b0b

Regen to fix CI failures (project-chip#15990)

9bee828

Merge branch 'master' of github.com:project-chip/connectedhomeip

c219807

Merge branch 'project-chip:master' into master

fa279bc

Merge branch 'project-chip:master' into master

9e18f9b

Merge branch 'project-chip:master' into master

b6ca5ca

Merge branch 'project-chip:master' into master

135dc25

Merge branch 'project-chip:master' into master

0446c67

Merge branch 'project-chip:master' into master

e69e63c

Merge branch 'project-chip:master' into master

a40f6df

Merge branch 'project-chip:master' into master

e5925ba

Merge branch 'project-chip:master' into master

0435362

Merge branch 'project-chip:master' into master

40b3412

Merge branch 'project-chip:master' into master

d197cb5

Merge branch 'project-chip:master' into master

e9b685d

Merge branch 'project-chip:master' into master

ef11df2

Merge branch 'project-chip:master' into master

b088f83

Merge branch 'project-chip:master' into master

8530810

Merge branch 'project-chip:master' into master

87a9581

Merge branch 'project-chip:master' into master

d9b496d

Merge branch 'project-chip:master' into master

2d283df

Merge branch 'project-chip:master' into master

2639213

Merge branch 'project-chip:master' into master

995a07e

Merge branch 'project-chip:master' into master

139f480

Merge branch 'project-chip:master' into master

f0beac0

Merge branch 'project-chip:master' into master

70059e4

Merge branch 'project-chip:master' into master

4faa576

Merge branch 'project-chip:master' into master

e22e2fc

pullapprove bot requested review from kghost, kpschoedel, lazarkov, LuDuda, mlepage-google, msandstedt, mspang, rgoliver, saurabhst, tcarmelveilleux, tecimovic, vijs, vivien-apple, wbschiller, woody-apple, xylophone21 and yufengwangca August 31, 2022 18:06

pullapprove bot added the review - pending label Aug 31, 2022

jmartinez-silabs approved these changes Aug 31, 2022

View reviewed changes

andy31415 approved these changes Aug 31, 2022

View reviewed changes

andy31415 added the ACCEPTED for 1.0 master label Aug 31, 2022

pullapprove bot added review - approved and removed review - pending ACCEPTED for 1.0 master labels Aug 31, 2022

selissia merged commit 4e01cee into project-chip:master Aug 31, 2022

selissia deleted the silabs-scan-fix-2 branch August 31, 2022 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a separate execution thread to disable the OpenThread interface #22315

Use a separate execution thread to disable the OpenThread interface #22315

selissia commented Aug 31, 2022 •

edited

Loading

selissia commented Aug 31, 2022

github-actions bot commented Aug 31, 2022 •

edited

Loading

andy31415 commented Aug 31, 2022

Use a separate execution thread to disable the OpenThread interface #22315

Use a separate execution thread to disable the OpenThread interface #22315

Conversation

selissia commented Aug 31, 2022 • edited Loading

Problem

Change overview

Testing

selissia commented Aug 31, 2022

github-actions bot commented Aug 31, 2022 • edited Loading

andy31415 commented Aug 31, 2022

selissia commented Aug 31, 2022 •

edited

Loading

github-actions bot commented Aug 31, 2022 •

edited

Loading