Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Integrate secure pairing with example app and device controller #2231

Closed
wants to merge 6 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Aug 19, 2020

A duplicate of #2230 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .bss 0 -992
chip-nrf52840-lock-example.out .text -1648 -1648
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_line,0,3063
[Unmapped],0,1651
.debug_macro,0,1198
.debug_info,0,844
.debug_str,0,801
.debug_ranges,0,96
.debug_aranges,0,-64
.debug_abbrev,0,-98
.debug_frame,0,-244
.symtab,0,-720
.strtab,0,-740
.bss,-992,0
.debug_loc,0,-1263
.text,-1648,-1648


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-nrf52840-lock-example.elf [LOAD #2 [RW]] 4 4
chip-nrf52840-lock-example.elf [LOAD #1 [RWX]] -4 -4
chip-nrf52840-lock-example.elf datas -4 -4
chip-nrf52840-lock-example.elf rodata -172 -172
chip-nrf52840-lock-example.elf bss 0 -960
chip-nrf52840-lock-example.elf text -2332 -2332
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_str,0,672
.debug_frame,0,192
.debug_aranges,0,16
[LOAD #2 [RW]],4,4
[LOAD #1 [RWX]],-4,-4
datas,-4,-4
[Unmapped],0,-24
.debug_ranges,0,-112
rodata,-172,-172
.debug_abbrev,0,-584
.debug_line,0,-605
.symtab,0,-640
.strtab,0,-801
bss,-960,0
.debug_loc,0,-1617
.debug_info,0,-2077
text,-2332,-2332


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out .text 3680 3680
chip-standalone-demo.out .eh_frame 920 920
chip-standalone-demo.out .rela.dyn 288 288
chip-standalone-demo.out .rodata 200 200
chip-standalone-demo.out .eh_frame_hdr 168 168
chip-standalone-demo.out .data.rel.ro 112 112
chip-standalone-demo.out .data 32 32
chip-standalone-demo.out [LOAD #5 [RW]] 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_info,0,29201
.debug_loc,0,9800
.debug_line,0,9058
.debug_macro,0,4755
.debug_str,0,4551
.text,3680,3680
.debug_abbrev,0,3305
.strtab,0,1817
.debug_ranges,0,1456
.eh_frame,920,920
.symtab,0,648
.debug_aranges,0,384
.rela.dyn,288,288
.rodata,200,200
.eh_frame_hdr,168,168
.data.rel.ro,112,112
.data,32,32
[LOAD #5 [RW]],16,16
[Unmapped],0,-1295


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: integer overflow


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2020

This pull request introduces 1 alert when merging ae47fc0 into 4af7537 - view on LGTM.com

new alerts:

  • 1 for Non-virtual destructor in base class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants