Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[privacy] Add AES_CTR_encrypt/decrypt with tests. #22108

Merged
merged 5 commits into from
Aug 30, 2022
Merged

[privacy] Add AES_CTR_encrypt/decrypt with tests. #22108

merged 5 commits into from
Aug 30, 2022

Conversation

turon
Copy link
Contributor

@turon turon commented Aug 23, 2022

Problem

Ch03 of the spec calls out the need for AES-CTR mode for privacy encrypt/decrypt.

Change overview

Adds AES-CTR to CryptoPal generally for all platforms by utilizing existing AES_CCM but ignoring the tag.

Testing

  • Added unit tests, so CI validates

@turon turon force-pushed the msg/privacy branch 2 times, most recently from d32167b to cc70c1c Compare August 23, 2022 17:04
@github-actions
Copy link

github-actions bot commented Aug 23, 2022 •
edited
Loading

PR #22108: Size comparison from 1a1d887 to 8db563b

Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 1a1d887 8db563b change % change
bl602 lighting-app bl602 (read/write) 1383930 1383986 56 0.0
.text 1051100 1051152 52 0.0
bl602+rpc (read/write) 1429586 1429634 48 0.0
.text 1082856 1082908 52 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673003 673075 72 0.0
.text 583852 583924 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637723 637787 64 0.0
.text 559420 559484 64 0.0
lock-ftd LP_CC2652R7 (read only) 674119 674183 64 0.0
.text 596968 597032 64 0.0
lock-mtd LP_CC2652R7 (read only) 656879 656951 72 0.0
.text 554632 554704 72 0.0
pump-app LP_CC2652R7 (read only) 684791 684863 72 0.0
.text 594348 594420 72 0.0
pump-controller-app LP_CC2652R7 (read only) 669299 669371 72 0.0
.text 583304 583376 72 0.0
shell LP_CC2652R7 (read only) 665694 665766 72 0.0
.text 579596 579668 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586754 586826 72 0.0
.app_xip_area 463412 463484 72 0.0
lock cyw930739m2evb_01 (read/write) 592538 592610 72 0.0
.app_xip_area 464412 464484 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599674 599754 80 0.0
.app_xip_area 477052 477132 80 0.0
efr32 lighting-app BRD4161A (read/write) 1107636 1107748 112 0.0
.text 969212 969324 112 0.0
BRD4161A+rpc (read/write) 971588 971652 64 0.0
.text 818468 818532 64 0.0
BRD4161A+rs911x (read/write) 1000248 1000360 112 0.0
.text 829084 829196 112 0.0
lock-app BRD4161A+wf200 (read/write) 1149420 1149484 64 0.0
.text 995168 995232 64 0.0
window-app BRD4161A (read/write) 1098932 1099044 112 0.0
.text 959044 959156 112 0.0
esp32 all-clusters-app c3devkit (read only) 1031286 1031344 58 0.0
.flash.text 1031286 1031344 58 0.0
m5stack (read only) 1084403 1084463 60 0.0
.flash.text 1079019 1079079 60 0.0
k32w light k32w0+release (read/write) 646676 646756 80 0.0
.text 571480 571560 80 0.0
lock k32w0+release (read/write) 704220 704284 64 0.0
.text 628552 628616 64 0.0
linux chip-tool-ipv6only arm64 (read only) 10261012 10261300 288 0.0
.text 8129284 8129572 288 0.0
thermostat-no-ble arm64 (read only) 2357300 2357588 288 0.0
.text 1978960 1979248 288 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2454536 2454600 64 0.0
.text 1417180 1417244 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180799 1180879 80 0.0
text 814736 814804 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159883 1159947 64 0.0
text 803144 803212 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1700996 1701108 112 0.0
.debug_abbrev 1217459 1217497 38 0.0
.debug_aranges 111544 111552 8 0.0
.debug_frame 372408 372464 56 0.0
.debug_info 26644547 26650167 5620 0.0
.debug_line 3647170 3647286 116 0.0
.debug_loc 3562765 3563416 651 0.0
.debug_ranges 336664 336672 8 0.0
.debug_str 3394161 3394277 116 0.0
.strtab 569346 569392 46 0.0
.symtab 420416 420448 32 0.0
.text 1540264 1540376 112 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1644204 1644316 112 0.0
.debug_abbrev 1209298 1209336 38 0.0
.debug_aranges 111016 111024 8 0.0
.debug_frame 375488 375544 56 0.0
.debug_info 26381242 26386789 5547 0.0
.debug_line 3667574 3667690 116 0.0
.debug_loc 3550402 3551053 651 0.0
.debug_ranges 335280 335288 8 0.0
.debug_str 3383150 3383266 116 0.0
.strtab 533820 533866 46 0.0
.symtab 407008 407040 32 0.0
.text 1484208 1484320 112 0.0
light cy8ckit_062s2_43012 (read/write) 1561436 1561548 112 0.0
.debug_abbrev 1043971 1044009 38 0.0
.debug_aranges 103184 103192 8 0.0
.debug_frame 345732 345788 56 0.0
.debug_info 21845798 21850122 4324 0.0
.debug_line 3238758 3238871 113 0.0
.debug_loc 3249979 3250615 636 0.0
.debug_ranges 301120 301128 8 0.0
.debug_str 3189244 3189360 116 0.0
.strtab 467101 467147 46 0.0
.symtab 374064 374096 32 0.0
.text 1409784 1409896 112 0.0
lock cy8ckit_062s2_43012 (read/write) 1598724 1598836 112 0.0
.debug_abbrev 1051147 1051185 38 0.0
.debug_aranges 103856 103864 8 0.0
.debug_frame 348556 348612 56 0.0
.debug_info 22200966 22205400 4434 0.0
.debug_line 3247442 3247554 112 0.0
.debug_loc 3290068 3290706 638 0.0
.debug_ranges 304536 304544 8 0.0
.debug_str 3216675 3216791 116 0.0
.strtab 473342 473388 46 0.0
.symtab 377248 377280 32 0.0
.text 1442576 1442688 112 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808800 56 0.0
text 571322 571378 56 0.0
lighting-app tlsr9518adk80d (read/write) 830680 830744 64 0.0
text 589412 589470 58 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 1a1d887 8db563b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178492 178420 -72 -0.0
lock-ftd LP_CC2652R7 (read/write) 167584 167520 -64 -0.0
lock-mtd LP_CC2652R7 (read/write) 180512 180440 -72 -0.0
pump-app LP_CC2652R7 (read/write) 157720 157648 -72 -0.0
pump-controller-app LP_CC2652R7 (read/write) 173332 173260 -72 -0.0
shell LP_CC2652R7 (read/write) 181320 181248 -72 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 1a1d887 8db563b change % change
bl602 lighting-app bl602 (read/write) 1383930 1383986 56 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1051100 1051152 52 0.0
bl602+rpc (read/write) 1429586 1429634 48 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082856 1082908 52 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673003 673075 72 0.0
(read/write) 178492 178420 -72 -0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583852 583924 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637723 637787 64 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559420 559484 64 0.0
lock-ftd LP_CC2652R7 (read only) 674119 674183 64 0.0
(read/write) 167584 167520 -64 -0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596968 597032 64 0.0
lock-mtd LP_CC2652R7 (read only) 656879 656951 72 0.0
(read/write) 180512 180440 -72 -0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554632 554704 72 0.0
pump-app LP_CC2652R7 (read only) 684791 684863 72 0.0
(read/write) 157720 157648 -72 -0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594348 594420 72 0.0
pump-controller-app LP_CC2652R7 (read only) 669299 669371 72 0.0
(read/write) 173332 173260 -72 -0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583304 583376 72 0.0
shell LP_CC2652R7 (read only) 665694 665766 72 0.0
(read/write) 181320 181248 -72 -0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579596 579668 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586754 586826 72 0.0
.app_xip_area 463412 463484 72 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592538 592610 72 0.0
.app_xip_area 464412 464484 72 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599674 599754 80 0.0
.app_xip_area 477052 477132 80 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107636 1107748 112 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 969212 969324 112 0.0
BRD4161A+rpc (read/write) 971588 971652 64 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818468 818532 64 0.0
BRD4161A+rs911x (read/write) 1000248 1000360 112 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 829084 829196 112 0.0
lock-app BRD4161A+wf200 (read/write) 1149420 1149484 64 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 995168 995232 64 0.0
window-app BRD4161A (read/write) 1098932 1099044 112 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959044 959156 112 0.0
esp32 all-clusters-app c3devkit (read only) 1031286 1031344 58 0.0
(read/write) 1489642 1489642 0 0.0
.dram0.bss 71144 71144 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218456 218456 0 0.0
.flash.text 1031286 1031344 58 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084403 1084463 60 0.0
(read/write) 491560 491560 0 0.0
.dram0.bss 76648 76648 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248772 248772 0 0.0
.flash.text 1079019 1079079 60 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646676 646756 80 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571480 571560 80 0.0
lock k32w0+release (read/write) 704220 704284 64 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628552 628616 64 0.0
linux chip-tool-ipv6only arm64 (read only) 10261012 10261300 288 0.0
(read/write) 699169 699169 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643848 643848 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493572 493572 0 0.0
.text 8129284 8129572 288 0.0
thermostat-no-ble arm64 (read only) 2357300 2357588 288 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1979248 288 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454536 2454600 64 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417180 1417244 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180799 1180879 80 0.0
bss 143745 143745 0 0.0
rodata 143360 143360 0 0.0
text 814736 814804 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159883 1159947 64 0.0
bss 142972 142972 0 0.0
rodata 134948 134948 0 0.0
text 803144 803212 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700996 1701108 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217459 1217497 38 0.0
.debug_aranges 111544 111552 8 0.0
.debug_frame 372408 372464 56 0.0
.debug_info 26644547 26650167 5620 0.0
.debug_line 3647170 3647286 116 0.0
.debug_loc 3562765 3563416 651 0.0
.debug_ranges 336664 336672 8 0.0
.debug_str 3394161 3394277 116 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569346 569392 46 0.0
.symtab 420416 420448 32 0.0
.text 0 0 0 0.0
1540264 1540376 112 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1644204 1644316 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209298 1209336 38 0.0
.debug_aranges 111016 111024 8 0.0
.debug_frame 375488 375544 56 0.0
.debug_info 26381242 26386789 5547 0.0
.debug_line 3667574 3667690 116 0.0
.debug_loc 3550402 3551053 651 0.0
.debug_ranges 335280 335288 8 0.0
.debug_str 3383150 3383266 116 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533820 533866 46 0.0
.symtab 407008 407040 32 0.0
.text 1484208 1484320 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561436 1561548 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1043971 1044009 38 0.0
.debug_aranges 103184 103192 8 0.0
.debug_frame 345732 345788 56 0.0
.debug_info 21845798 21850122 4324 0.0
.debug_line 3238758 3238871 113 0.0
.debug_loc 3249979 3250615 636 0.0
.debug_ranges 301120 301128 8 0.0
.debug_str 3189244 3189360 116 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467101 467147 46 0.0
.symtab 374064 374096 32 0.0
.text 1409784 1409896 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598724 1598836 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051147 1051185 38 0.0
.debug_aranges 103856 103864 8 0.0
.debug_frame 348556 348612 56 0.0
.debug_info 22200966 22205400 4434 0.0
.debug_line 3247442 3247554 112 0.0
.debug_loc 3290068 3290706 638 0.0
.debug_ranges 304536 304544 8 0.0
.debug_str 3216675 3216791 116 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473342 473388 46 0.0
.symtab 377248 377280 32 0.0
.text 1442576 1442688 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808800 56 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571322 571378 56 0.0
lighting-app tlsr9518adk80d (read/write) 830680 830744 64 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589412 589470 58 0.0

@github-actions
Copy link

github-actions bot commented Aug 26, 2022 •
edited
Loading

PR #22108: Size comparison from 1952eb7 to 04330b1

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 1952eb7 04330b1 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383746 56 0.0
.text 1050860 1050912 52 0.0
bl602+rpc (read/write) 1429602 1429658 56 0.0
.text 1082872 1082928 56 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672907 72 0.0
.text 583684 583756 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637611 56 0.0
.text 559252 559308 56 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673983 64 0.0
.text 596768 596832 64 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656759 72 0.0
.text 554440 554512 72 0.0
pump-app LP_CC2652R7 (read only) 684551 684623 72 0.0
.text 594140 594212 72 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669131 72 0.0
.text 583096 583168 72 0.0
shell LP_CC2652R7 (read only) 665526 665598 72 0.0
.text 579428 579500 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586650 64 0.0
.app_xip_area 463244 463308 64 0.0
lock cyw930739m2evb_01 (read/write) 592346 592418 72 0.0
.app_xip_area 464220 464292 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599522 72 0.0
.app_xip_area 476828 476900 72 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107412 128 0.0
.text 968860 968988 128 0.0
BRD4161A+rpc (read/write) 971396 971460 64 0.0
.text 818276 818340 64 0.0
BRD4161A+rs911x (read/write) 999896 1000024 128 0.0
.text 828732 828860 128 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149260 64 0.0
.text 994944 995008 64 0.0
window-app BRD4161A (read/write) 1098548 1098676 128 0.0
.text 958660 958788 128 0.0
esp32 all-clusters-app c3devkit (read only) 1031178 1031238 60 0.0
.flash.text 1031178 1031238 60 0.0
m5stack (read only) 1084287 1084351 64 0.0
.flash.text 1078903 1078967 64 0.0
k32w light k32w0+release (read/write) 646516 646580 64 0.0
.text 571320 571384 64 0.0
lock k32w0+release (read/write) 704012 704092 80 0.0
.text 628344 628424 80 0.0
linux all-clusters-app debug (read only) 3037929 3038377 448 0.0
.text 2584146 2584594 448 0.0
all-clusters-minimal-app debug (read only) 2873793 2874241 448 0.0
.text 2422594 2423042 448 0.0
bridge-app debug+rpc (read only) 2372313 2372761 448 0.0
.text 2006226 2006674 448 0.0
chip-tool debug (read only) 10878417 10878865 448 0.0
.text 8796500 8796948 448 0.0
chip-tool-ipv6only arm64 (read only) 10264052 10264340 288 0.0
.text 8119796 8120084 288 0.0
lighting-app debug+rpc (read only) 2597257 2597705 448 0.0
.text 2205986 2206434 448 0.0
lock-app debug (read only) 2580241 2580689 448 0.0
.text 2176258 2176706 448 0.0
ota-provider-app debug (read only) 2357401 2357849 448 0.0
.text 1984626 1985074 448 0.0
ota-requestor-app debug (read only) 2522921 2523353 432 0.0
.text 2134178 2134610 432 0.0
shell debug (read only) 2606233 2606681 448 0.0
.text 2213074 2213522 448 0.0
thermostat-no-ble arm64 (read only) 2356644 2356932 288 0.0
.text 1978336 1978624 288 0.0
tv-app debug (read only) 3182745 3183177 432 0.0
.text 2733922 2734354 432 0.0
tv-casting-app debug (read only) 5503505 5503953 448 0.0
.text 4887618 4888066 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2454312 2454376 64 0.0
.text 1416956 1417020 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180671 80 0.0
text 814560 814628 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159739 64 0.0
text 802968 803036 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1740372 1740484 112 0.0
.debug_abbrev 1217558 1217596 38 0.0
.debug_aranges 111560 111568 8 0.0
.debug_frame 372476 372532 56 0.0
.debug_info 26646623 26652244 5621 0.0
.debug_line 3647676 3647788 112 0.0
.debug_loc 3562758 3563360 602 0.0
.debug_ranges 336864 336872 8 0.0
.debug_str 3393925 3394041 116 0.0
.strtab 569449 569495 46 0.0
.symtab 420640 420672 32 0.0
.text 1540760 1540872 112 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1683580 1683692 112 0.0
.debug_abbrev 1209397 1209435 38 0.0
.debug_aranges 111032 111040 8 0.0
.debug_frame 375556 375612 56 0.0
.debug_info 26383316 26388866 5550 0.0
.debug_line 3668080 3668192 112 0.0
.debug_loc 3550395 3550997 602 0.0
.debug_ranges 335480 335488 8 0.0
.debug_str 3382914 3383030 116 0.0
.strtab 533923 533969 46 0.0
.symtab 407232 407264 32 0.0
.text 1484704 1484816 112 0.0
light cy8ckit_062s2_43012 (read/write) 1600828 1600940 112 0.0
.debug_abbrev 1044070 1044108 38 0.0
.debug_aranges 103200 103208 8 0.0
.debug_frame 345800 345856 56 0.0
.debug_info 21847874 21852199 4325 0.0
.debug_line 3239259 3239376 117 0.0
.debug_loc 3249910 3250604 694 0.0
.debug_ranges 301320 301328 8 0.0
.debug_str 3189008 3189124 116 0.0
.strtab 467204 467250 46 0.0
.symtab 374288 374320 32 0.0
.text 1410296 1410408 112 0.0
lock cy8ckit_062s2_43012 (read/write) 1638540 1638652 112 0.0
.debug_abbrev 1051505 1051543 38 0.0
.debug_aranges 103872 103880 8 0.0
.debug_frame 348628 348684 56 0.0
.debug_info 22227605 22232036 4431 0.0
.debug_line 3248153 3248266 113 0.0
.debug_loc 3289747 3290398 651 0.0
.debug_ranges 304664 304672 8 0.0
.debug_str 3216491 3216607 116 0.0
.strtab 473419 473465 46 0.0
.symtab 377472 377504 32 0.0
.text 1442976 1443088 112 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808472 56 0.0
text 571028 571082 54 0.0
lighting-app tlsr9518adk80d (read/write) 830392 830448 56 0.0
text 589152 589206 54 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 1952eb7 04330b1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178660 178588 -72 -0.0
lock-ftd LP_CC2652R7 (read/write) 167784 167720 -64 -0.0
lock-mtd LP_CC2652R7 (read/write) 180704 180632 -72 -0.0
pump-app LP_CC2652R7 (read/write) 157960 157888 -72 -0.0
pump-controller-app LP_CC2652R7 (read/write) 173572 173500 -72 -0.0
shell LP_CC2652R7 (read/write) 181488 181416 -72 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 1952eb7 04330b1 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383746 56 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050860 1050912 52 0.0
bl602+rpc (read/write) 1429602 1429658 56 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082872 1082928 56 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672907 72 0.0
(read/write) 178660 178588 -72 -0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583684 583756 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637611 56 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559252 559308 56 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673983 64 0.0
(read/write) 167784 167720 -64 -0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596832 64 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656759 72 0.0
(read/write) 180704 180632 -72 -0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554512 72 0.0
pump-app LP_CC2652R7 (read only) 684551 684623 72 0.0
(read/write) 157960 157888 -72 -0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594140 594212 72 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669131 72 0.0
(read/write) 173572 173500 -72 -0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583096 583168 72 0.0
shell LP_CC2652R7 (read only) 665526 665598 72 0.0
(read/write) 181488 181416 -72 -0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579428 579500 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586650 64 0.0
.app_xip_area 463244 463308 64 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592418 72 0.0
.app_xip_area 464220 464292 72 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599522 72 0.0
.app_xip_area 476828 476900 72 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107412 128 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968860 968988 128 0.0
BRD4161A+rpc (read/write) 971396 971460 64 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818276 818340 64 0.0
BRD4161A+rs911x (read/write) 999896 1000024 128 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828732 828860 128 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149260 64 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 995008 64 0.0
window-app BRD4161A (read/write) 1098548 1098676 128 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958660 958788 128 0.0
esp32 all-clusters-app c3devkit (read only) 1031178 1031238 60 0.0
(read/write) 1489650 1489650 0 0.0
.dram0.bss 71160 71160 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031178 1031238 60 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084287 1084351 64 0.0
(read/write) 491568 491568 0 0.0
.dram0.bss 76664 76664 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1078903 1078967 64 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646580 64 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571384 64 0.0
lock k32w0+release (read/write) 704012 704092 80 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628424 80 0.0
linux all-clusters-app debug (read only) 3037929 3038377 448 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274635 0 0.0
.text 2584146 2584594 448 0.0
all-clusters-minimal-app debug (read only) 2873793 2874241 448 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274827 0 0.0
.text 2422594 2423042 448 0.0
bridge-app debug+rpc (read only) 2372313 2372761 448 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203464 0 0.0
.text 2006226 2006674 448 0.0
chip-tool debug (read only) 10878417 10878865 448 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561365 561365 0 0.0
.text 8796500 8796948 448 0.0
chip-tool-ipv6only arm64 (read only) 10264052 10264340 288 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492132 492132 0 0.0
.text 8119796 8120084 288 0.0
lighting-app debug+rpc (read only) 2597257 2597705 448 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220368 0 0.0
.text 2205986 2206434 448 0.0
lock-app debug (read only) 2580241 2580689 448 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237328 0 0.0
.text 2176258 2176706 448 0.0
ota-provider-app debug (read only) 2357401 2357849 448 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209304 0 0.0
.text 1984626 1985074 448 0.0
ota-requestor-app debug (read only) 2522921 2523353 432 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216128 0 0.0
.text 2134178 2134610 432 0.0
shell debug (read only) 2606233 2606681 448 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234738 0 0.0
.text 2213074 2213522 448 0.0
thermostat-no-ble arm64 (read only) 2356644 2356932 288 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978336 1978624 288 0.0
tv-app debug (read only) 3182745 3183177 432 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259080 0 0.0
.text 2733922 2734354 432 0.0
tv-casting-app debug (read only) 5503505 5503953 448 0.0
(read/write) 160464 160464 0 0.0
.bss 51480 51480 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344273 0 0.0
.text 4887618 4888066 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454376 64 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1417020 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180671 80 0.0
bss 143745 143745 0 0.0
rodata 143328 143328 0 0.0
text 814560 814628 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159739 64 0.0
bss 142972 142972 0 0.0
rodata 134916 134916 0 0.0
text 802968 803036 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842120 842120 0 0.0
(read/write) 1740372 1740484 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188568 188568 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217558 1217596 38 0.0
.debug_aranges 111560 111568 8 0.0
.debug_frame 372476 372532 56 0.0
.debug_info 26646623 26652244 5621 0.0
.debug_line 3647676 3647788 112 0.0
.debug_loc 3562758 3563360 602 0.0
.debug_ranges 336864 336872 8 0.0
.debug_str 3393925 3394041 116 0.0
.heap 842120 842120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569449 569495 46 0.0
.symtab 420640 420672 32 0.0
.text 1540760 1540872 112 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842856 842856 0 0.0
(read/write) 1683580 1683692 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187832 187832 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209397 1209435 38 0.0
.debug_aranges 111032 111040 8 0.0
.debug_frame 375556 375612 56 0.0
.debug_info 26383316 26388866 5550 0.0
.debug_line 3668080 3668192 112 0.0
.debug_loc 3550395 3550997 602 0.0
.debug_ranges 335480 335488 8 0.0
.debug_str 3382914 3383030 116 0.0
.heap 842856 842856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533923 533969 46 0.0
.symtab 407232 407264 32 0.0
.text 1484704 1484816 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600940 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044108 38 0.0
.debug_aranges 103200 103208 8 0.0
.debug_frame 345800 345856 56 0.0
.debug_info 21847874 21852199 4325 0.0
.debug_line 3239259 3239376 117 0.0
.debug_loc 3249910 3250604 694 0.0
.debug_ranges 301320 301328 8 0.0
.debug_str 3189008 3189124 116 0.0
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467250 46 0.0
.symtab 374288 374320 32 0.0
.text 1410296 1410408 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638652 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051543 38 0.0
.debug_aranges 103872 103880 8 0.0
.debug_frame 348628 348684 56 0.0
.debug_info 22227605 22232036 4431 0.0
.debug_line 3248153 3248266 113 0.0
.debug_loc 3289747 3290398 651 0.0
.debug_ranges 304664 304672 8 0.0
.debug_str 3216491 3216607 116 0.0
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473465 46 0.0
.symtab 377472 377504 32 0.0
.text 1442976 1443088 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808472 56 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571028 571082 54 0.0
lighting-app tlsr9518adk80d (read/write) 830392 830448 56 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589152 589206 54 0.0

turon and others added 4 commits August 26, 2022 16:27
@turon
[privacy] Add AES_CTR_encrypt/decrypt with tests.
5a4cb3d
@turon
[style] Remove magic words.
b7512ce
@turon @jmeg-sfy
Apply suggestions from code review
6ff20e9 
Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>
@turon @emargolis
Update src/crypto/CHIPCryptoPAL.h
486de90 
Co-authored-by: Evgeny Margolis <emargolis@google.com>
@github-actions
Copy link

github-actions bot commented Aug 26, 2022 •
edited
Loading

PR #22108: Size comparison from 35c4d69 to 486de90

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 35c4d69 486de90 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383746 56 0.0
.text 1050856 1050912 56 0.0
bl602+rpc (read/write) 1429602 1429650 48 0.0
.text 1082872 1082924 52 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672907 72 0.0
.text 583684 583756 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637619 64 0.0
.text 559252 559316 64 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673983 64 0.0
.text 596768 596832 64 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656759 72 0.0
.text 554440 554512 72 0.0
pump-app LP_CC2652R7 (read only) 684551 684623 72 0.0
.text 594140 594212 72 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669131 72 0.0
.text 583096 583168 72 0.0
shell LP_CC2652R7 (read only) 665526 665598 72 0.0
.text 579428 579500 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586658 72 0.0
.app_xip_area 463244 463316 72 0.0
lock cyw930739m2evb_01 (read/write) 592346 592418 72 0.0
.app_xip_area 464220 464292 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599522 72 0.0
.app_xip_area 476828 476900 72 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107412 128 0.0
.text 968860 968988 128 0.0
BRD4161A+rpc (read/write) 971396 971460 64 0.0
.text 818276 818340 64 0.0
BRD4161A+rs911x (read/write) 999896 1000024 128 0.0
.text 828732 828860 128 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149260 64 0.0
.text 994944 995008 64 0.0
window-app BRD4161A (read/write) 1098548 1098676 128 0.0
.text 958660 958788 128 0.0
esp32 all-clusters-app c3devkit (read only) 1031178 1031236 58 0.0
.flash.text 1031178 1031236 58 0.0
m5stack (read only) 1084287 1084351 64 0.0
.flash.text 1078903 1078967 64 0.0
k32w light k32w0+release (read/write) 646516 646580 64 0.0
.text 571320 571384 64 0.0
lock k32w0+release (read/write) 704012 704076 64 0.0
.text 628344 628408 64 0.0
linux all-clusters-app debug (read only) 3037929 3038377 448 0.0
.text 2584146 2584594 448 0.0
all-clusters-minimal-app debug (read only) 2873793 2874241 448 0.0
.text 2422594 2423042 448 0.0
bridge-app debug+rpc (read only) 2372313 2372761 448 0.0
.text 2006226 2006674 448 0.0
chip-tool debug (read only) 10876545 10876993 448 0.0
.text 8794980 8795428 448 0.0
chip-tool-ipv6only arm64 (read only) 10262564 10262852 288 0.0
.text 8118644 8118932 288 0.0
lighting-app debug+rpc (read only) 2597257 2597705 448 0.0
.text 2205986 2206434 448 0.0
lock-app debug (read only) 2580241 2580689 448 0.0
.text 2176258 2176706 448 0.0
ota-provider-app debug (read only) 2357401 2357849 448 0.0
.text 1984626 1985074 448 0.0
ota-requestor-app debug (read only) 2522921 2523353 432 0.0
.text 2134178 2134610 432 0.0
shell debug (read only) 2606233 2606681 448 0.0
.text 2213074 2213522 448 0.0
thermostat-no-ble arm64 (read only) 2356644 2356932 288 0.0
.text 1978336 1978624 288 0.0
tv-app debug (read only) 3182745 3183177 432 0.0
.text 2733922 2734354 432 0.0
tv-casting-app debug (read only) 5503505 5503953 448 0.0
.text 4887618 4888066 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2454312 2454376 64 0.0
.text 1416956 1417020 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180655 64 0.0
text 814560 814624 64 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159739 64 0.0
text 802968 803036 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1740372 1740484 112 0.0
.debug_abbrev 1217558 1217596 38 0.0
.debug_aranges 111560 111568 8 0.0
.debug_frame 372476 372532 56 0.0
.debug_info 26646621 26652242 5621 0.0
.debug_line 3647676 3647788 112 0.0
.debug_loc 3562758 3563360 602 0.0
.debug_ranges 336864 336872 8 0.0
.debug_str 3393925 3394041 116 0.0
.strtab 569449 569495 46 0.0
.symtab 420640 420672 32 0.0
.text 1540760 1540872 112 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1683580 1683692 112 0.0
.debug_abbrev 1209397 1209435 38 0.0
.debug_aranges 111032 111040 8 0.0
.debug_frame 375556 375612 56 0.0
.debug_info 26383316 26388865 5549 0.0
.debug_line 3668080 3668192 112 0.0
.debug_loc 3550395 3550997 602 0.0
.debug_ranges 335480 335488 8 0.0
.debug_str 3382914 3383030 116 0.0
.strtab 533923 533969 46 0.0
.symtab 407232 407264 32 0.0
.text 1484704 1484816 112 0.0
light cy8ckit_062s2_43012 (read/write) 1600828 1600940 112 0.0
.debug_abbrev 1044070 1044108 38 0.0
.debug_aranges 103200 103208 8 0.0
.debug_frame 345800 345856 56 0.0
.debug_info 21847874 21852198 4324 0.0
.debug_line 3239259 3239376 117 0.0
.debug_loc 3249910 3250604 694 0.0
.debug_ranges 301320 301328 8 0.0
.debug_str 3189008 3189124 116 0.0
.strtab 467204 467250 46 0.0
.symtab 374288 374320 32 0.0
.text 1410296 1410408 112 0.0
lock cy8ckit_062s2_43012 (read/write) 1638540 1638652 112 0.0
.debug_abbrev 1051505 1051543 38 0.0
.debug_aranges 103872 103880 8 0.0
.debug_frame 348628 348684 56 0.0
.debug_info 22227604 22232036 4432 0.0
.debug_line 3248153 3248266 113 0.0
.debug_loc 3289747 3290398 651 0.0
.debug_ranges 304664 304672 8 0.0
.debug_str 3216491 3216607 116 0.0
.strtab 473419 473465 46 0.0
.symtab 377472 377504 32 0.0
.text 1442976 1443088 112 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808472 56 0.0
text 571026 571084 58 0.0
lighting-app tlsr9518adk80d (read/write) 830392 830448 56 0.0
text 589152 589206 54 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 35c4d69 486de90 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178660 178588 -72 -0.0
lock-ftd LP_CC2652R7 (read/write) 167784 167720 -64 -0.0
lock-mtd LP_CC2652R7 (read/write) 180704 180632 -72 -0.0
pump-app LP_CC2652R7 (read/write) 157960 157888 -72 -0.0
pump-controller-app LP_CC2652R7 (read/write) 173572 173500 -72 -0.0
shell LP_CC2652R7 (read/write) 181488 181416 -72 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 35c4d69 486de90 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383746 56 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050856 1050912 56 0.0
bl602+rpc (read/write) 1429602 1429650 48 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082872 1082924 52 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672907 72 0.0
(read/write) 178660 178588 -72 -0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583684 583756 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637619 64 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559252 559316 64 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673983 64 0.0
(read/write) 167784 167720 -64 -0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596832 64 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656759 72 0.0
(read/write) 180704 180632 -72 -0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554512 72 0.0
pump-app LP_CC2652R7 (read only) 684551 684623 72 0.0
(read/write) 157960 157888 -72 -0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594140 594212 72 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669131 72 0.0
(read/write) 173572 173500 -72 -0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583096 583168 72 0.0
shell LP_CC2652R7 (read only) 665526 665598 72 0.0
(read/write) 181488 181416 -72 -0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579428 579500 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586658 72 0.0
.app_xip_area 463244 463316 72 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592418 72 0.0
.app_xip_area 464220 464292 72 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599522 72 0.0
.app_xip_area 476828 476900 72 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107412 128 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968860 968988 128 0.0
BRD4161A+rpc (read/write) 971396 971460 64 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818276 818340 64 0.0
BRD4161A+rs911x (read/write) 999896 1000024 128 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828732 828860 128 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149260 64 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 995008 64 0.0
window-app BRD4161A (read/write) 1098548 1098676 128 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958660 958788 128 0.0
esp32 all-clusters-app c3devkit (read only) 1031178 1031236 58 0.0
(read/write) 1489650 1489650 0 0.0
.dram0.bss 71160 71160 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031178 1031236 58 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084287 1084351 64 0.0
(read/write) 491568 491568 0 0.0
.dram0.bss 76664 76664 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1078903 1078967 64 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646580 64 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571384 64 0.0
lock k32w0+release (read/write) 704012 704076 64 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628408 64 0.0
linux all-clusters-app debug (read only) 3037929 3038377 448 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274635 0 0.0
.text 2584146 2584594 448 0.0
all-clusters-minimal-app debug (read only) 2873793 2874241 448 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274827 0 0.0
.text 2422594 2423042 448 0.0
bridge-app debug+rpc (read only) 2372313 2372761 448 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203464 0 0.0
.text 2006226 2006674 448 0.0
chip-tool debug (read only) 10876545 10876993 448 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561013 561013 0 0.0
.text 8794980 8795428 448 0.0
chip-tool-ipv6only arm64 (read only) 10262564 10262852 288 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491796 491796 0 0.0
.text 8118644 8118932 288 0.0
lighting-app debug+rpc (read only) 2597257 2597705 448 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220368 0 0.0
.text 2205986 2206434 448 0.0
lock-app debug (read only) 2580241 2580689 448 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237328 0 0.0
.text 2176258 2176706 448 0.0
ota-provider-app debug (read only) 2357401 2357849 448 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209304 0 0.0
.text 1984626 1985074 448 0.0
ota-requestor-app debug (read only) 2522921 2523353 432 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216128 0 0.0
.text 2134178 2134610 432 0.0
shell debug (read only) 2606233 2606681 448 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234738 0 0.0
.text 2213074 2213522 448 0.0
thermostat-no-ble arm64 (read only) 2356644 2356932 288 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978336 1978624 288 0.0
tv-app debug (read only) 3182745 3183177 432 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259080 0 0.0
.text 2733922 2734354 432 0.0
tv-casting-app debug (read only) 5503505 5503953 448 0.0
(read/write) 160464 160464 0 0.0
.bss 51480 51480 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344273 0 0.0
.text 4887618 4888066 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454376 64 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1417020 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180655 64 0.0
bss 143745 143745 0 0.0
rodata 143328 143328 0 0.0
text 814560 814624 64 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159739 64 0.0
bss 142972 142972 0 0.0
rodata 134916 134916 0 0.0
text 802968 803036 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842120 842120 0 0.0
(read/write) 1740372 1740484 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188568 188568 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217558 1217596 38 0.0
.debug_aranges 111560 111568 8 0.0
.debug_frame 372476 372532 56 0.0
.debug_info 26646621 26652242 5621 0.0
.debug_line 3647676 3647788 112 0.0
.debug_loc 3562758 3563360 602 0.0
.debug_ranges 336864 336872 8 0.0
.debug_str 3393925 3394041 116 0.0
.heap 842120 842120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569449 569495 46 0.0
.symtab 420640 420672 32 0.0
.text 0 0 0 0.0
1540760 1540872 112 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842856 842856 0 0.0
(read/write) 1683580 1683692 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187832 187832 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209397 1209435 38 0.0
.debug_aranges 111032 111040 8 0.0
.debug_frame 375556 375612 56 0.0
.debug_info 26383316 26388865 5549 0.0
.debug_line 3668080 3668192 112 0.0
.debug_loc 3550395 3550997 602 0.0
.debug_ranges 335480 335488 8 0.0
.debug_str 3382914 3383030 116 0.0
.heap 842856 842856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533923 533969 46 0.0
.symtab 407232 407264 32 0.0
.text 1484704 1484816 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600940 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044108 38 0.0
.debug_aranges 103200 103208 8 0.0
.debug_frame 345800 345856 56 0.0
.debug_info 21847874 21852198 4324 0.0
.debug_line 3239259 3239376 117 0.0
.debug_loc 3249910 3250604 694 0.0
.debug_ranges 301320 301328 8 0.0
.debug_str 3189008 3189124 116 0.0
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467250 46 0.0
.symtab 374288 374320 32 0.0
.text 1410296 1410408 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638652 112 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051543 38 0.0
.debug_aranges 103872 103880 8 0.0
.debug_frame 348628 348684 56 0.0
.debug_info 22227604 22232036 4432 0.0
.debug_line 3248153 3248266 113 0.0
.debug_loc 3289747 3290398 651 0.0
.debug_ranges 304664 304672 8 0.0
.debug_str 3216491 3216607 116 0.0
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473465 46 0.0
.symtab 377472 377504 32 0.0
.text 1442976 1443088 112 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808472 56 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571026 571084 58 0.0
lighting-app tlsr9518adk80d (read/write) 830392 830448 56 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589152 589206 54 0.0

@bzbarsky-apple bzbarsky-apple merged commit 9bde9e3 into project-chip:master Aug 30, 2022
@andy31415 andy31415 mentioned this pull request Aug 30, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@turon @jmeg-sfy
@emargolis @andy31415 @isiu-apple
[privacy] Add AES_CTR_encrypt/decrypt with tests. (project-chip#22108)
fe4dd1c 
* [privacy] Add AES_CTR_encrypt/decrypt with tests.

* [style] Remove magic words.

* Apply suggestions from code review

Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>

* Update src/crypto/CHIPCryptoPAL.h

Co-authored-by: Evgeny Margolis <emargolis@google.com>

* Use stdbuf to try to disable stdout buffering on darwin

Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>
Co-authored-by: Evgeny Margolis <emargolis@google.com>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@emargolis emargolis emargolis approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
crypto review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@turon @andy31415 @emargolis @woody-apple @jmeg-sfy @bzbarsky-apple