-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ReliableMessageMgr to perform address relookup on first message fail #21768
Merged
tehampson
merged 13 commits into
project-chip:master
from
tehampson:reworked-update-device-21639
Aug 12, 2022
Merged
Allow ReliableMessageMgr to perform address relookup on first message fail #21768
tehampson
merged 13 commits into
project-chip:master
from
tehampson:reworked-update-device-21639
Aug 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #21768: Size comparison from 93d72d2 to 7d010c8 Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
7d010c8
to
7512f27
Compare
PR #21768: Size comparison from 3860268 to 7512f27 Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
7512f27
to
9396ee9
Compare
PR #21768: Size comparison from a985e18 to 9396ee9 Increases (12 builds for bl602, cyw30739, k32w, mbed, nrfconnect, telink)
Full report (12 builds for bl602, cyw30739, k32w, mbed, nrfconnect, telink)
|
woody-apple
approved these changes
Aug 10, 2022
PR #21768: Size comparison from a985e18 to 4a770a6 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #21768: Size comparison from a985e18 to 0c42bc1 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Aug 11, 2022
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
mrjerryjohns
approved these changes
Aug 12, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
… fail (project-chip#21768) * OnFirstMessageDeliveryFailed is removed from SessionDelegate * CASESessionManager will implement delegate to allow updating Session transport peer address. *During CASESessionManager::Init it will register itself with ReliableMessageMgr, so that ReliableMessageMgr has a callback. * CASESessionManager create a different OperationalSessionSetup to perform address lookup and update that is separate from OperationalSessionSetup used for establishing a connection. Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
OnFirstMessageDeliveryFailed
no longer performs address lookup after 21256 #21639Change overview
OnFirstMessageDeliveryFailed
is removed fromSessionDelegate
CASESessionManager
will implement delegate to allow updatingSession
transport peer address.CASESessionManager::Init
it will register itself withReliableMessageMgr
, so thatReliableMessageMgr
has a callbackCASESessionManager
resuses existingOperationalSessionSetup
to perform address lookup and updateTesting
PerformLookupOnExistingSession
, confirmed the following worked:PerformLookupOnExistingSession
on session that is currently establishedOnDeviceConnected
was called after address resolution successfully completed.