-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Android App: Updated vendor id support #21471
Merged
woody-apple
merged 6 commits into
project-chip:master
from
lazarkov:feature/tv-android-app-add-vendor-id
Aug 2, 2022
Merged
TV Android App: Updated vendor id support #21471
woody-apple
merged 6 commits into
project-chip:master
from
lazarkov:feature/tv-android-app-add-vendor-id
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #21471: Size comparison from 17c8da6 to e2cf446 Decreases (4 builds for bl602, cyw30739, telink)
Full report (14 builds for bl602, cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
PR #21471: Size comparison from 17c8da6 to 9959d63 Increases (1 build for cc13x2_26x2)
Decreases (3 builds for cc13x2_26x2, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
If possible, could you get Android chip-tool working again? I think it was the API change from wifi scanning that broke it. |
chrisdecenzo
approved these changes
Aug 1, 2022
woody-apple
approved these changes
Aug 2, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
* Add support for vendor id * Update build.gn * Restyle fix * Removed level control unused file * Fix linter issue * Restyle fix & remove chip config
woody-apple
added a commit
that referenced
this pull request
Aug 2, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Add support for vendor id * Update build.gn * Restyle fix * Removed level control unused file * Fix linter issue * Restyle fix & remove chip config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
Manually tested the flow:
add-admin-vendor 65521
and press okcast request 0
cast cluster channel read channel-list 0 1