Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring LevelControl cluster and its tests into conformance with the spec and the test spec #21312

Merged
merged 12 commits into from
Jul 28, 2022
Merged

Bring LevelControl cluster and its tests into conformance with the spec and the test spec #21312

merged 12 commits into from
Jul 28, 2022

Conversation

robszewczyk
Copy link
Contributor

Problem

  • Spec uses the terms optionsMask and optionsOverride instead of the mor* e antiquated terms optionMask and optionOverride (those terms existed in an old version ZCL) in the LevelControl cluster. While the parameter naming has no impact on the functionality of the code or on interop, it does affect the certification testing and associated test plans.
  • The LevelControl cluster was missing the optionsMask and optionsOverride parameters in the variants of commands *WithOnOff

Change overview

The meaningful changes are:

  • general.xml -- modify the commands definition
  • levelcontrol.cpp -- in *WithOnOff variants of commands, pass the optionsMask and optionsOverride rather than fill in defaults
  • Modify YAML tests to capture the corrected parameter names
  • regen zap-generated files

Testing

  • existing unit tests pass

fix #21294

@robszewczyk
Bring Level Control cluster in line with the spec
033de68 
* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing optional parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes project-chip#21294
@robszewczyk
OptionsMask and optionsOverride in the level control
b802410 
* rename parameters in YAML test specs to follow spec
* `WithOnOff` variants of the commands take the same options as the regular variants of the commands
@robszewczyk
Regenerated ZAP-generated files
e77dcde
@robszewczyk
Restyled code
8f68df0
@woody-apple woody-apple enabled auto-merge (squash) July 28, 2022 00:32
@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

PR #21312: Size comparison from 661cb82 to fcda326

Increases (22 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 661cb82 fcda326 change % change
bl602 lighting-app bl602 (read/write) 1381330 1381562 232 0.0
.text 1051628 1051836 208 0.0
bl602+rpc (read/write) 1426746 1426986 240 0.0
.text 1083292 1083504 212 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668291 668475 184 0.0
.text 579780 579964 184 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633875 634059 184 0.0
.text 556140 556324 184 0.0
lock-ftd LP_CC2652R7 (read only) 671447 671455 8 0.0
.text 594704 594712 8 0.0
pump-app LP_CC2652R7 (read only) 680743 680919 176 0.0
.text 591396 591572 176 0.0
pump-controller-app LP_CC2652R7 (read only) 666479 666487 8 0.0
.text 581320 581328 8 0.0
shell LP_CC2652R7 (read only) 661006 661166 160 0.0
.text 575524 575684 160 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583206 583374 168 0.0
.app_xip_area 460016 460184 168 0.0
efr32 lighting-app BRD4161A (read/write) 1087832 1088024 192 0.0
.text 952480 952672 192 0.0
BRD4161A+rpc (read/write) 1142124 1142316 192 0.0
.text 989880 990072 192 0.0
BRD4161A+rs911x (read/write) 952488 952696 208 0.0
.text 809420 809628 208 0.0
esp32 all-clusters-app c3devkit (read only) 1022462 1022746 284 0.0
.flash.text 1022462 1022746 284 0.0
m5stack (read only) 1076107 1076207 100 0.0
.flash.text 1070723 1070823 100 0.0
k32w light k32w0+release (read/write) 642600 642760 160 0.0
.text 568108 568268 160 0.0
linux chip-tool-ipv6only arm64 (read only) 9839124 9840388 1264 0.0
.text 7788980 7790276 1296 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172691 1172867 176 0.0
text 808808 808980 172 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152743 1152919 176 0.0
text 798120 798292 172 0.0
p6 all-clusters-app default (read/write) 1686700 1686908 208 0.0
.text 1526528 1526736 208 0.0
all-clusters-minimal-app default (read/write) 1630796 1631004 208 0.0
.text 1471344 1471552 208 0.0
light-app default (read/write) 1552220 1552412 192 0.0
.text 1401072 1401264 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 819708 819984 276 0.0
text 583810 584070 260 0.0
Decreases (6 builds for cc13x2_26x2, linux)
platform target config section 661cb82 fcda326 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183076 182892 -184 -0.1
lock-ftd LP_CC2652R7 (read/write) 170112 170104 -8 -0.0
pump-app LP_CC2652R7 (read/write) 161648 161472 -176 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176048 176040 -8 -0.0
shell LP_CC2652R7 (read/write) 185880 185720 -160 -0.1
linux chip-tool-ipv6only arm64 .rodata 467796 467764 -32 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 661cb82 fcda326 change % change
bl602 lighting-app bl602 (read/write) 1381330 1381562 232 0.0
.bss 117618 117618 0 0.0
.data 4480 4480 0 0.0
.text 1051628 1051836 208 0.0
bl602+rpc (read/write) 1426746 1426986 240 0.0
.bss 125058 125058 0 0.0
.data 4600 4600 0 0.0
.text 1083292 1083504 212 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668291 668475 184 0.0
(read/write) 183076 182892 -184 -0.1
.bss 74260 74260 0 0.0
.data 3356 3356 0 0.0
.rodata 88195 88195 0 0.0
.text 579780 579964 184 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633875 634059 184 0.0
(read/write) 157828 157828 0 0.0
.bss 73556 73556 0 0.0
.data 3356 3356 0 0.0
.rodata 77411 77411 0 0.0
.text 556140 556324 184 0.0
lock-ftd LP_CC2652R7 (read only) 671447 671455 8 0.0
(read/write) 170112 170104 -8 -0.0
.bss 71340 71340 0 0.0
.data 3280 3280 0 0.0
.rodata 76263 76263 0 0.0
.text 594704 594712 8 0.0
lock-mtd LP_CC2652R7 (read only) 653555 653555 0 0.0
(read/write) 183692 183692 0 0.0
.bss 67028 67028 0 0.0
.data 3280 3280 0 0.0
.rodata 100875 100875 0 0.0
.text 552200 552200 0 0.0
pump-app LP_CC2652R7 (read only) 680743 680919 176 0.0
(read/write) 161648 161472 -176 -0.1
.bss 71404 71404 0 0.0
.data 3280 3280 0 0.0
.rodata 88863 88863 0 0.0
.text 591396 591572 176 0.0
pump-controller-app LP_CC2652R7 (read only) 666479 666487 8 0.0
(read/write) 176048 176040 -8 -0.0
.bss 71540 71540 0 0.0
.data 3276 3276 0 0.0
.rodata 84679 84679 0 0.0
.text 581320 581328 8 0.0
shell LP_CC2652R7 (read only) 661006 661166 160 0.0
(read/write) 185880 185720 -160 -0.1
.bss 76580 76580 0 0.0
.data 3360 3360 0 0.0
.rodata 85166 85166 0 0.0
.text 575524 575684 160 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583206 583374 168 0.0
.app_xip_area 460016 460184 168 0.0
.bss 65648 65648 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589126 589126 0 0.0
.app_xip_area 461208 461208 0 0.0
.bss 70376 70376 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588938 588938 0 0.0
.app_xip_area 466564 466564 0 0.0
.bss 64888 64888 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087832 1088024 192 0.0
.bss 133284 133284 0 0.0
.data 2048 2048 0 0.0
.text 952480 952672 192 0.0
BRD4161A+rpc (read/write) 1142124 1142316 192 0.0
.bss 149964 149964 0 0.0
.data 2260 2260 0 0.0
.text 989880 990072 192 0.0
BRD4161A+rs911x (read/write) 952488 952696 208 0.0
.bss 141000 141000 0 0.0
.data 2048 2048 0 0.0
.text 809420 809628 208 0.0
lock-app BRD4161A+wf200 (read/write) 1128296 1128296 0 0.0
.bss 144368 144368 0 0.0
.data 2056 2056 0 0.0
.text 981852 981852 0 0.0
window-app BRD4161A (read/write) 1081308 1081308 0 0.0
.bss 134756 134756 0 0.0
.data 2076 2076 0 0.0
.text 944452 944452 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022462 1022746 284 0.0
(read/write) 1486274 1486274 0 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215936 215936 0 0.0
.flash.text 1022462 1022746 284 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076107 1076207 100 0.0
(read/write) 488312 488312 0 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246364 246364 0 0.0
.flash.text 1070723 1070823 100 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 642600 642760 160 0.0
.bss 69736 69736 0 0.0
.data 2028 2028 0 0.0
.text 568108 568268 160 0.0
lock k32w0+release (read/write) 699832 699832 0 0.0
.bss 70176 70176 0 0.0
.data 2036 2036 0 0.0
.text 624892 624892 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9839124 9840388 1264 0.0
(read/write) 678609 678609 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467796 467764 -32 -0.0
.text 7788980 7790276 1296 0.0
thermostat-no-ble arm64 (read only) 2343388 2343388 0 0.0
(read/write) 141601 141601 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 138964 138964 0 0.0
.text 1967200 1967200 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450384 2450384 0 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1413028 1413028 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172691 1172867 176 0.0
bss 143140 143140 0 0.0
rodata 141828 141828 0 0.0
text 808808 808980 172 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152743 1152919 176 0.0
bss 142376 142376 0 0.0
rodata 133360 133360 0 0.0
text 798120 798292 172 0.0
p6 all-clusters-app default (read only) 881560 881560 0 0.0
(read/write) 1686700 1686908 208 0.0
.bss 149136 149136 0 0.0
.data 2648 2648 0 0.0
.text 1526528 1526736 208 0.0
all-clusters-minimal-app default (read only) 882280 882280 0 0.0
(read/write) 1630796 1631004 208 0.0
.bss 148416 148416 0 0.0
.data 2648 2648 0 0.0
.text 1471344 1471552 208 0.0
light-app default (read only) 890584 890584 0 0.0
(read/write) 1552220 1552412 192 0.0
.bss 140320 140320 0 0.0
.data 2440 2440 0 0.0
.text 1401072 1401264 192 0.0
lock-app default (read only) 886112 886112 0 0.0
(read/write) 1589828 1589828 0 0.0
.bss 144776 144776 0 0.0
.data 2456 2456 0 0.0
.text 1434208 1434208 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799600 799600 0 0.0
bss 70816 70816 0 0.0
noinit 40416 40416 0 0.0
text 567240 567240 0 0.0
lighting-app tlsr9518adk80d (read/write) 819708 819984 276 0.0
bss 71660 71660 0 0.0
noinit 40416 40416 0 0.0
text 583810 584070 260 0.0

@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

PR #21312: Size comparison from 8c18775 to df27236

Increases (19 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
platform target config section 8c18775 df27236 change % change
bl602 lighting-app bl602 (read/write) 1381330 1381562 232 0.0
.text 1051628 1051836 208 0.0
bl602+rpc (read/write) 1426746 1426986 240 0.0
.text 1083292 1083504 212 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668299 668475 176 0.0
.text 579788 579964 176 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633875 634059 184 0.0
.text 556140 556324 184 0.0
pump-app LP_CC2652R7 (read only) 680735 680911 176 0.0
.text 591388 591564 176 0.0
shell LP_CC2652R7 (read only) 661006 661166 160 0.0
.text 575524 575684 160 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583206 583374 168 0.0
.app_xip_area 460016 460184 168 0.0
efr32 lighting-app BRD4161A (read/write) 1087832 1088024 192 0.0
.text 952480 952672 192 0.0
BRD4161A+rpc (read/write) 1142124 1142316 192 0.0
.text 989880 990072 192 0.0
BRD4161A+rs911x (read/write) 973224 973432 208 0.0
.text 809420 809628 208 0.0
esp32 all-clusters-app c3devkit (read only) 1022460 1022746 286 0.0
.flash.text 1022460 1022746 286 0.0
m5stack (read only) 1076107 1076207 100 0.0
.flash.text 1070723 1070823 100 0.0
k32w light k32w0+release (read/write) 642600 642760 160 0.0
.text 568108 568268 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172691 1172867 176 0.0
text 808808 808980 172 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152743 1152919 176 0.0
text 798120 798292 172 0.0
p6 all-clusters-app default (read/write) 1686700 1686908 208 0.0
.text 1526528 1526736 208 0.0
all-clusters-minimal-app default (read/write) 1630796 1631004 208 0.0
.text 1471344 1471552 208 0.0
light-app default (read/write) 1552220 1552412 192 0.0
.text 1401072 1401264 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 819708 819984 276 0.0
text 583810 584072 262 0.0
Decreases (4 builds for cc13x2_26x2, telink)
platform target config section 8c18775 df27236 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183068 182892 -176 -0.1
pump-app LP_CC2652R7 (read/write) 161656 161480 -176 -0.1
shell LP_CC2652R7 (read/write) 185880 185720 -160 -0.1
telink light-switch-app tlsr9518adk80d text 567240 567238 -2 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 8c18775 df27236 change % change
bl602 lighting-app bl602 (read/write) 1381330 1381562 232 0.0
.bss 117618 117618 0 0.0
.data 4480 4480 0 0.0
.text 1051628 1051836 208 0.0
bl602+rpc (read/write) 1426746 1426986 240 0.0
.bss 125058 125058 0 0.0
.data 4600 4600 0 0.0
.text 1083292 1083504 212 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668299 668475 176 0.0
(read/write) 183068 182892 -176 -0.1
.bss 74260 74260 0 0.0
.data 3356 3356 0 0.0
.rodata 88195 88195 0 0.0
.text 579788 579964 176 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633875 634059 184 0.0
(read/write) 157828 157828 0 0.0
.bss 73556 73556 0 0.0
.data 3356 3356 0 0.0
.rodata 77411 77411 0 0.0
.text 556140 556324 184 0.0
lock-ftd LP_CC2652R7 (read only) 671455 671455 0 0.0
(read/write) 170104 170104 0 0.0
.bss 71340 71340 0 0.0
.data 3280 3280 0 0.0
.rodata 76263 76263 0 0.0
.text 594712 594712 0 0.0
lock-mtd LP_CC2652R7 (read only) 653555 653555 0 0.0
(read/write) 183692 183692 0 0.0
.bss 67028 67028 0 0.0
.data 3280 3280 0 0.0
.rodata 100875 100875 0 0.0
.text 552200 552200 0 0.0
pump-app LP_CC2652R7 (read only) 680735 680911 176 0.0
(read/write) 161656 161480 -176 -0.1
.bss 71404 71404 0 0.0
.data 3280 3280 0 0.0
.rodata 88863 88863 0 0.0
.text 591388 591564 176 0.0
pump-controller-app LP_CC2652R7 (read only) 666487 666487 0 0.0
(read/write) 176040 176040 0 0.0
.bss 71540 71540 0 0.0
.data 3276 3276 0 0.0
.rodata 84679 84679 0 0.0
.text 581328 581328 0 0.0
shell LP_CC2652R7 (read only) 661006 661166 160 0.0
(read/write) 185880 185720 -160 -0.1
.bss 76580 76580 0 0.0
.data 3360 3360 0 0.0
.rodata 85166 85166 0 0.0
.text 575524 575684 160 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583206 583374 168 0.0
.app_xip_area 460016 460184 168 0.0
.bss 65648 65648 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589126 589126 0 0.0
.app_xip_area 461208 461208 0 0.0
.bss 70376 70376 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588938 588938 0 0.0
.app_xip_area 466564 466564 0 0.0
.bss 64888 64888 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087832 1088024 192 0.0
.bss 133284 133284 0 0.0
.data 2048 2048 0 0.0
.text 952480 952672 192 0.0
BRD4161A+rpc (read/write) 1142124 1142316 192 0.0
.bss 149964 149964 0 0.0
.data 2260 2260 0 0.0
.text 989880 990072 192 0.0
BRD4161A+rs911x (read/write) 973224 973432 208 0.0
.bss 161736 161736 0 0.0
.data 2048 2048 0 0.0
.text 809420 809628 208 0.0
lock-app BRD4161A+wf200 (read/write) 1128296 1128296 0 0.0
.bss 144368 144368 0 0.0
.data 2056 2056 0 0.0
.text 981852 981852 0 0.0
window-app BRD4161A (read/write) 1081308 1081308 0 0.0
.bss 134756 134756 0 0.0
.data 2076 2076 0 0.0
.text 944452 944452 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022460 1022746 286 0.0
(read/write) 1486274 1486274 0 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215936 215936 0 0.0
.flash.text 1022460 1022746 286 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076107 1076207 100 0.0
(read/write) 488312 488312 0 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246364 246364 0 0.0
.flash.text 1070723 1070823 100 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 642600 642760 160 0.0
.bss 69736 69736 0 0.0
.data 2028 2028 0 0.0
.text 568108 568268 160 0.0
lock k32w0+release (read/write) 699832 699832 0 0.0
.bss 70176 70176 0 0.0
.data 2036 2036 0 0.0
.text 624892 624892 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450384 2450384 0 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1413028 1413028 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172691 1172867 176 0.0
bss 143140 143140 0 0.0
rodata 141828 141828 0 0.0
text 808808 808980 172 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152743 1152919 176 0.0
bss 142376 142376 0 0.0
rodata 133360 133360 0 0.0
text 798120 798292 172 0.0
p6 all-clusters-app default (read only) 881560 881560 0 0.0
(read/write) 1686700 1686908 208 0.0
.bss 149136 149136 0 0.0
.data 2648 2648 0 0.0
.text 1526528 1526736 208 0.0
all-clusters-minimal-app default (read only) 882280 882280 0 0.0
(read/write) 1630796 1631004 208 0.0
.bss 148416 148416 0 0.0
.data 2648 2648 0 0.0
.text 1471344 1471552 208 0.0
light-app default (read only) 890584 890584 0 0.0
(read/write) 1552220 1552412 192 0.0
.bss 140320 140320 0 0.0
.data 2440 2440 0 0.0
.text 1401072 1401264 192 0.0
lock-app default (read only) 886112 886112 0 0.0
(read/write) 1589828 1589828 0 0.0
.bss 144776 144776 0 0.0
.data 2456 2456 0 0.0
.text 1434208 1434208 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799600 799600 0 0.0
bss 70816 70816 0 0.0
noinit 40416 40416 0 0.0
text 567240 567238 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 819708 819984 276 0.0
bss 71660 71660 0 0.0
noinit 40416 40416 0 0.0
text 583810 584072 262 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure an issue is filed to generally align this cluster with the spec (naming, etc), with the "spec" label. There are various spec mismatches in the bits this PR does not touch, but we should do that in a separate PR to avoid scope creep.

src/app/clusters/level-control/level-control.cpp Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/silabs/general.xml Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Jul 28, 2022
Closed
@robszewczyk robszewczyk disabled auto-merge July 28, 2022 20:11
@robszewczyk
Copy link
Contributor Author

Filed #21377 per request to track outstanding LevelControl open issues.

@robszewczyk robszewczyk enabled auto-merge (squash) July 28, 2022 21:14
@robszewczyk robszewczyk mentioned this pull request Jul 28, 2022
Merged
@robszewczyk robszewczyk merged commit cc3e2b7 into project-chip:master Jul 28, 2022
github-actions bot pushed a commit that referenced this pull request Jul 28, 2022
@robszewczyk @woody-apple @web-flow
Bring LevelControl cluster and its tests into conformance with the sp…
e8b6b00 
…ec and the test spec (#21312)

* Bring Level Control cluster in line with the spec

* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes #21294

Co-authored-by: Justin Wood <woody@apple.com>
@robszewczyk robszewczyk deleted the issue/21294 branch July 28, 2022 22:42
woody-apple added a commit that referenced this pull request Jul 29, 2022
@woody-apple @robszewczyk
Bring LevelControl cluster and its tests into conformance with the sp…
be72965 
…ec and the test spec (#21312) (#21379)

* Bring Level Control cluster in line with the spec

* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes #21294

Co-authored-by: Justin Wood <woody@apple.com>

Co-authored-by: Robert Szewczyk <szewczyk@google.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@robszewczyk @woody-apple @isiu-apple
Bring LevelControl cluster and its tests into conformance with the sp…
5dc764d 
…ec and the test spec (project-chip#21312)

* Bring Level Control cluster in line with the spec

* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes project-chip#21294

Co-authored-by: Justin Wood <woody@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin examples review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chip-tool levelcontrol misses mandatory parameters for some commands
4 participants
@robszewczyk @mrjerryjohns @woody-apple @bzbarsky-apple