Revert "[esp32]: We should not setup DeviceInfoProvider via PlatfromMgr on ESP32."

[woody-apple]

Reverts #21039

Reverting this, given the platform owners do not agree with this platform change.

[woody-apple]

Fast tracking platform changes (reverts).

[woody-apple]

Tagging @bzbarsky-apple per comments in the reverted PR, and @dhrishi

[github-actions]

PR #21097: Size comparison from eeb75da to a44c28f

Increases (5 builds for cc13x2_26x2, esp32, nrfconnect, telink)

platform	target	config	section	eeb75da	a44c28f	change	% change
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read/write)	169932	169940	8	0.0
esp32	all-clusters-app	c3devkit	(read only)	1021924	1021930	6	0.0
			(read/write)	1486274	1486290	16	0.0
			.dram0.bss	70224	70232	8	0.0
			.flash.text	1021924	1021930	6	0.0
		m5stack	(read only)	1075563	1075691	128	0.0
			(read/write)	488304	488312	8	0.0
			.dram0.bss	75744	75752	8	0.0
			.flash.text	1070179	1070307	128	0.0
nrfconnect	all-clusters-minimal-app	nrf52840dk_nrf52840	text	801860	801864	4	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	799460	799468	8	0.0
			text	567184	567186	2	0.0

Decreases (1 build for cc13x2_26x2)

platform	target	config	section	eeb75da	a44c28f	change	% change
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	671587	671579	-8	-0.0
			.text	594664	594656	-8	-0.0

Full report (14 builds for cc13x2_26x2, esp32, mbed, nrfconnect, telink)

platform	target	config	section	eeb75da	a44c28f	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	668383	668383	0	0.0
			(read/write)	182960	182960	0	0.0
			.bss	74236	74236	0	0.0
			.data	3356	3356	0	0.0
			.rodata	88327	88327	0	0.0
			.text	579740	579740	0	0.0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	633983	633983	0	0.0
			(read/write)	157804	157804	0	0.0
			.bss	73532	73532	0	0.0
			.data	3356	3356	0	0.0
			.rodata	77551	77551	0	0.0
			.text	556108	556108	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	671587	671579	-8	-0.0
			(read/write)	169932	169940	8	0.0
			.bss	71300	71300	0	0.0
			.data	3280	3280	0	0.0
			.rodata	76443	76443	0	0.0
			.text	594664	594656	-8	-0.0
	lock-mtd	LP_CC2652R7	(read only)	653871	653871	0	0.0
			(read/write)	183336	183336	0	0.0
			.bss	66988	66988	0	0.0
			.data	3280	3280	0	0.0
			.rodata	101183	101183	0	0.0
			.text	552208	552208	0	0.0
	pump-app	LP_CC2652R7	(read only)	681087	681087	0	0.0
			(read/write)	161288	161288	0	0.0
			.bss	71388	71388	0	0.0
			.data	3280	3280	0	0.0
			.rodata	89039	89039	0	0.0
			.text	591564	591564	0	0.0
	pump-controller-app	LP_CC2652R7	(read only)	666863	666863	0	0.0
			(read/write)	175632	175632	0	0.0
			.bss	71508	71508	0	0.0
			.data	3276	3276	0	0.0
			.rodata	84895	84895	0	0.0
			.text	581488	581488	0	0.0
	shell	LP_CC2652R7	(read only)	660858	660858	0	0.0
			(read/write)	185988	185988	0	0.0
			.bss	76540	76540	0	0.0
			.data	3360	3360	0	0.0
			.rodata	85098	85098	0	0.0
			.text	575444	575444	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	1021924	1021930	6	0.0
			(read/write)	1486274	1486290	16	0.0
			.dram0.bss	70224	70232	8	0.0
			.dram0.data	14600	14600	0	0.0
			.flash.rodata	216016	216016	0	0.0
			.flash.text	1021924	1021930	6	0.0
			.iram0.text	62902	62902	0	0.0
		m5stack	(read only)	1075563	1075691	128	0.0
			(read/write)	488304	488312	8	0.0
			.dram0.bss	75744	75752	8	0.0
			.dram0.data	34144	34144	0	0.0
			.flash.rodata	246420	246420	0	0.0
			.flash.text	1070179	1070307	128	0.0
			.iram0.text	123267	123267	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2449032	2449032	0	0.0
			.bss	214444	214444	0	0.0
			.data	5872	5872	0	0.0
			.text	1411676	1411676	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1176927	1176927	0	0.0
			bss	143068	143068	0	0.0
			rodata	142440	142440	0	0.0
			text	812548	812548	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1156979	1156979	0	0.0
			bss	142304	142304	0	0.0
			rodata	133972	133972	0	0.0
			text	801860	801864	4	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	799460	799468	8	0.0
			bss	70744	70744	0	0.0
			noinit	40416	40416	0	0.0
			text	567184	567186	2	0.0
	lighting-app	tlsr9518adk80d	(read/write)	819516	819516	0	0.0
			bss	71588	71588	0	0.0
			noinit	40416	40416	0	0.0
			text	583730	583730	0	0.0

[bzbarsky-apple]

In particular #21039 made the exact changes that #18236 (comment) was saying should not be made (removing the platform device info provider on ESP32), on the mistaken assumption that the code there was the same as the default code and staying that way. Which it's not.

On Slack @dhrishi indicated that the ESP32 folks involved are busy with SVE now but would revert 21039 when they get a chance...

[dhrishi]

Sorry for the confusion @bzbarsky-apple . I wanted to say that the relevant developer would revert to the messages on the group and not the PR :-D