-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ami.xmp from matter #20659
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/remove_ami_xml
Jul 13, 2022
Merged
remove ami.xmp from matter #20659
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/remove_ami_xml
Jul 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #20659: Size comparison from a903f59 to c4b81c5 Increases (1 build for cyw30739)
Decreases (7 builds for bl602, linux, nrfconnect, telink)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
c4b81c5
to
fa57505
Compare
PR #20659: Size comparison from a903f59 to fa57505 Increases (3 builds for cc13x2_26x2, cyw30739, esp32)
Decreases (10 builds for bl602, cc13x2_26x2, esp32, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 13, 2022
andy31415
approved these changes
Jul 13, 2022
Merged
andy31415
pushed a commit
that referenced
this pull request
Jul 13, 2022
ajwak
pushed a commit
to ajwak/connectedhomeip
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#20020 (comment)
ami.xml is not part of matter, and it is blocking #20020
Change overview
removed ami.xml
Testing
compilation