Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flashbundle name (it is based on project name) for nrf projects #20654

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Fix flashbundle name (it is based on project name) for nrf projects #20654

merged 1 commit into from
Jul 13, 2022

Conversation

woody-apple
Copy link
Contributor

Problem

NRF connect does not build artifacts with flashbundles:

FileNotFoundError: [Errno 2] No such file or directory: '/workspace/out/nrf-nrf52840dk-all-clusters/chip-nrfconnect-all-clusters-example.flashbundle.txt'

Change overview

Fix the name

Testing

./scripts/build/build_examples.py --target nrf-nrf52840dk-all-clusters --enable-flashbundle build --copy-artifacts-to out/artifacts

now passes

@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited
Loading

PR #20654: Size comparison from dad96b1 to c32d40a

Increases (2 builds for efr32, esp32)
platform target config section dad96b1 c32d40a change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1128448 1128464 16 0.0
.text 982180 982196 16 0.0
esp32 all-clusters-app c3devkit (read only) 1019920 1019922 2 0.0
.flash.text 1019920 1019922 2 0.0
Decreases (7 builds for bl602, cyw30739, mbed, nrfconnect, telink)
platform target config section dad96b1 c32d40a change % change
bl602 lighting-app bl602 .text 1058528 1058524 -4 -0.0
bl602+rpc (read/write) 1442682 1442674 -8 -0.0
.text 1090212 1090208 -4 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 585430 585422 -8 -0.0
.app_xip_area 459464 459456 -8 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447912 2447848 -64 -0.0
.text 1410556 1410492 -64 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155119 1155103 -16 -0.0
text 800756 800752 -4 -0.0
telink light-switch-app tlsr9518adk80d text 565542 565540 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816908 816900 -8 -0.0
text 581866 581864 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section dad96b1 c32d40a change % change
bl602 lighting-app bl602 (read/write) 1397250 1397250 0 0.0
.bss 116978 116978 0 0.0
.data 4480 4480 0 0.0
.text 1058528 1058524 -4 -0.0
bl602+rpc (read/write) 1442682 1442674 -8 -0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1090212 1090208 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666011 666011 0 0.0
(read/write) 185212 185212 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577628 577628 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631819 631819 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 554188 554188 0 0.0
lock-ftd LP_CC2652R7 (read only) 668927 668927 0 0.0
(read/write) 172440 172440 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 592240 592240 0 0.0
lock-mtd LP_CC2652R7 (read only) 618335 618335 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541760 541760 0 0.0
pump-app LP_CC2652R7 (read only) 677951 677951 0 0.0
(read/write) 164264 164264 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 589036 589036 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663775 663775 0 0.0
(read/write) 178560 178560 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 579000 579000 0 0.0
shell LP_CC2652R7 (read only) 658510 658510 0 0.0
(read/write) 188216 188216 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 573348 573348 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579494 579494 0 0.0
.app_xip_area 458264 458264 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585430 585422 -8 -0.0
.app_xip_area 459464 459456 -8 -0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582550 582550 0 0.0
.app_xip_area 462168 462168 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081180 1081180 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946116 946116 0 0.0
BRD4161A+rpc (read/write) 1135484 1135484 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983528 983528 0 0.0
BRD4161A+rs911x (read/write) 947692 947692 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 804856 804856 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128448 1128464 16 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982180 982196 16 0.0
window-app BRD4161A (read/write) 1074980 1074980 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938412 938412 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019920 1019922 2 0.0
(read/write) 1485490 1485490 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215376 215376 0 0.0
.flash.text 1019920 1019922 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073887 1073887 0 0.0
(read/write) 487568 487568 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245828 245828 0 0.0
.flash.text 1068503 1068503 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658544 658544 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581236 581236 0 0.0
lock k32w061+release (read/write) 685316 685316 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607532 607532 0 0.0
linux all-clusters-app debug (read only) 2960129 2960129 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263581 263581 0 0.0
.text 2519362 2519362 0 0.0
all-clusters-minimal-app debug (read only) 2812673 2812673 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265277 265277 0 0.0
.text 2372386 2372386 0 0.0
bridge-app debug+rpc (read only) 2314841 2314841 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1955154 1955154 0 0.0
chip-tool debug (read only) 10315489 10315489 0 0.0
(read/write) 622240 622240 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587888 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 514357 514357 0 0.0
.text 8369444 8369444 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10006884 10006884 0 0.0
(read/write) 684529 684529 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623432 0 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 476516 476516 0 0.0
.text 7969700 7969700 0 0.0
lighting-app debug+rpc (read only) 2550585 2550585 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2166978 2166978 0 0.0
lock-app debug (read only) 2515185 2515185 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228680 228680 0 0.0
.text 2121362 2121362 0 0.0
ota-provider-app debug (read only) 2321665 2321665 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1955474 1955474 0 0.0
ota-requestor-app debug (read only) 2438817 2438817 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2060434 2060434 0 0.0
shell debug (read only) 2550457 2550457 0 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227698 227698 0 0.0
.text 2165682 2165682 0 0.0
thermostat-no-ble arm64 (read only) 2594708 2594708 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165412 165412 0 0.0
.text 2189520 2189520 0 0.0
tv-app debug (read only) 3101553 3101553 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2664722 2664722 0 0.0
tv-casting-app debug (read only) 5577177 5577177 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343145 343145 0 0.0
.text 4956082 4956082 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447912 2447848 -64 -0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410556 1410492 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174911 1174911 0 0.0
bss 142900 142900 0 0.0
rodata 141816 141816 0 0.0
text 811312 811312 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155119 1155103 -16 -0.0
bss 142136 142136 0 0.0
rodata 133344 133344 0 0.0
text 800756 800752 -4 -0.0
p6 all-clusters-app default (read/write) 2565152 2565152 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523416 1523416 0 0.0
all-clusters-minimal-app default (read/write) 2510208 2510208 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468472 1468472 0 0.0
light-app default (read/write) 2440496 2440496 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398760 1398760 0 0.0
lock-app default (read/write) 2467760 2467760 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426024 1426024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797076 797076 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565542 565540 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816908 816900 -8 -0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581866 581864 -2 -0.0

@andy31415 andy31415 merged commit 9a59072 into sve Jul 13, 2022
@andy31415 andy31415 deleted the cherry-pick-71d2689a6c68e582a21bea4ce0b7130e51784843 branch July 13, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scripts sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @andy31415