-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Added EnableKey parameter to factory data #20557
Merged
Damian-Nordic
merged 2 commits into
project-chip:master
from
ArekBalysNordic:factory_data_enable_key
Jul 14, 2022
Merged
[nrfconnect] Added EnableKey parameter to factory data #20557
Damian-Nordic
merged 2 commits into
project-chip:master
from
ArekBalysNordic:factory_data_enable_key
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certification tests may make use of the TestEventTrigger command of GeneralDiagnostics cluster to trigger certain actions. The command uses authentication with the EnableKey parameter, that should be placed in the factory data set. - Added EnableKey to the JSON Schema - Added EnableKey to the factory data - Added EnableKey to the Cmake script - Added GetEnableKey to the FactoryDataProvider and FactoryDataParser
1b27170
to
837a1c2
Compare
PR #20557: Size comparison from d271f7b to 837a1c2 Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (11 builds for cc13x2_26x2, nrfconnect, telink)
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Jul 12, 2022
PR #20557: Size comparison from a903f59 to 1802823 Increases (3 builds for esp32, nrfconnect)
Decreases (13 builds for bl602, cyw30739, nrfconnect, telink)
Full report (51 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
kkasperczyk-no
approved these changes
Jul 13, 2022
tcarmelveilleux
approved these changes
Jul 14, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
Certification tests may make use of the TestEventTrigger command of GeneralDiagnostics cluster to trigger certain actions. The command uses authentication with the EnableKey parameter, that should be placed in the factory data set. - Added EnableKey to the JSON Schema - Added EnableKey to the factory data - Added EnableKey to the Cmake script - Added GetEnableKey to the FactoryDataProvider and FactoryDataParser
woody-apple
added a commit
that referenced
this pull request
Jul 14, 2022
Certification tests may make use of the TestEventTrigger command of GeneralDiagnostics cluster to trigger certain actions. The command uses authentication with the EnableKey parameter, that should be placed in the factory data set. - Added EnableKey to the JSON Schema - Added EnableKey to the factory data - Added EnableKey to the Cmake script - Added GetEnableKey to the FactoryDataProvider and FactoryDataParser Co-authored-by: Arkadiusz Bałys <arkadiusz.balys@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Certification tests may make use of the TestEventTrigger command
of GeneralDiagnostics cluster to trigger certain actions.
The command uses authentication with the EnableKey parameter, that
should be placed in the factory data set.
Change overview
Testing
Tested by building example with factory data & using nRF52DK.