-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FabricTable utility methods #20332
Merged
andy31415
merged 6 commits into
project-chip:master
from
msandstedt:fabric-table-utility-methods
Jul 6, 2022
Merged
Add FabricTable utility methods #20332
andy31415
merged 6 commits into
project-chip:master
from
msandstedt:fabric-table-utility-methods
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fabric table lacks an interface to lookup fabric index based upon the fully-qualified <root CA public key, fabric ID> identity. It also lacks an interface to extract the local node CATs for a given fabric. Add these. Testing: unit tests for the new utility methods have been added.
woody-apple
approved these changes
Jul 5, 2022
PR #20332: Size comparison from a498673 to 7efb59f Increases above 0.2%:
Increases (5 builds for cc13x2_26x2, cyw30739, k32w, linux)
Decreases (7 builds for esp32, linux, nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 5, 2022
PR #20332: Size comparison from a498673 to 4f852e1 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, cyw30739, k32w, linux)
Decreases (6 builds for efr32, esp32, linux, nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The fabric table lacks an interface to lookup fabric index based upon
the fully-qualified <root CA public key, fabric ID> identity. It also
lacks an interface to extract the local node CATs for a given fabric.
Change overview
Add FabricTable utility methods to lookup by <root CA public key, fabric ID> and to extract CATs from the NOC for a give fabric.
Testing
Unit tests have been added for the new utility interfaces.