-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Call mDNS resolve callback under stack lock #19947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in dc3862a has uncovered potential race condition in Tizen mDNS resolver. The callback function was called outside of the Matter stack lock. This callback might perform PASE session paring which involves message exchanges, which requires locking. Simple fix for that is to call the callback under the lock.
PR #19947: Size comparison from 2d0c529 to ad93cea Increases (2 builds for cc13x2_26x2, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jun 24, 2022
bzbarsky-apple
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes in dc3862a has uncovered potential race condition in Tizen mDNS
resolver. The callback function was called outside of the Matter stack
lock. This callback might perform PASE session paring which involves
message exchanges, which requires locking. Simple fix for that is to
call the callback under the lock.
Change overview
Testing
Manually tested that Tizen chip-tool can commission lighting-app running on the network.
Previously we've got this:
On Linux:
On Tizen: