-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MinInterval handling in ReadClient. #19854
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-min-interval-storage
Jun 22, 2022
Merged
Fix MinInterval handling in ReadClient. #19854
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-min-interval-storage
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had codepaths on which we did not store MinInterval for an outgoing subscribe request, and would later report the wrong MinInterval.
tcarmelveilleux
approved these changes
Jun 22, 2022
PR #19854: Size comparison from d1a4bb7 to d841a01 Increases (9 builds for cc13x2_26x2, efr32, esp32, linux, telink)
Decreases (10 builds for cc13x2_26x2, cyw30739, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mrjerryjohns
approved these changes
Jun 22, 2022
woody-apple
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had codepaths on which we did not store MinInterval for an outgoing
subscribe request, and would later report the wrong MinInterval.
Problem
chip-tool subscribe ended up showing minInterval as 0, because we never stored the incoming value on the codepath chip-tool ends up using.
Change overview
Store the value on the codepath all subscribes go through.
Testing
Ran
chip-tool onoff subscribe on-off 90 900 17 1
and observed that the log says:where before it would say: