-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DeviceProxy pointer in ClusterBase #19673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would like @bzbarsky-apple to review as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do the Darwin bits of this once we sort out how the cluster bits are initialized; the exact Darwin changes will depend very heavily on that.
PR #19673: Size comparison from 3963c1b to 54ebf42 Increases (11 builds for cc13x2_26x2, efr32, nrfconnect, telink)
Decreases (20 builds for cc13x2_26x2, cyw30739, efr32, linux, nrfconnect)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 3963c1b to 104e5f9 Increases (9 builds for cc13x2_26x2, efr32, nrfconnect)
Decreases (20 builds for cc13x2_26x2, cyw30739, efr32, linux, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 147cab2 to 7040ce7 Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect, telink)
Decreases (15 builds for cc13x2_26x2, linux, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 41e474d to c8a80ec Increases (11 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Decreases (4 builds for cc13x2_26x2, linux)
Full report (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 41e474d to a957860 Increases (18 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (13 builds for cc13x2_26x2, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 81c7f2a to 4eac99a Increases (18 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (13 builds for cc13x2_26x2, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 81c7f2a to 6df0787 Increases (19 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect)
Decreases (15 builds for cc13x2_26x2, linux, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 39a8af0 to d4072ef Increases (15 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect)
Decreases (6 builds for cc13x2_26x2, linux, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
scripts/idl/tests/outputs/several_clusters/jni/FirstClient-InvokeSubscribeImpl.cpp
Show resolved
Hide resolved
PR #19673: Size comparison from 08cb351 to acd8583 Increases (19 builds for cc13x2_26x2, cyw30739, efr32, linux, nrfconnect, telink)
Decreases (14 builds for cc13x2_26x2, esp32, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 796f370 to 72e12a2 Increases (15 builds for cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect)
Decreases (6 builds for cc13x2_26x2, efr32, linux)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 5b603f3 to d9d71e1 Increases (19 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, telink)
Decreases (14 builds for cc13x2_26x2, efr32, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19673: Size comparison from 5b603f3 to 1435340 Increases (20 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect)
Decreases (16 builds for cc13x2_26x2, efr32, linux, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Needs to go in SVE, given high likelihood of divergence. |
Problem
Pave the path to fix #19259
Change overview
Remove
DeviceProxy*
inClusterBase
class, use a session handle ref instead.@andy31415 Not sure how to generate files underscripts/idl/tests/outputs
@bzbarsky-apple Need to fix
src/darwin/Framework/CHIP/CHIPCluster.mm
but I don't understand object-c at all.Testing
Refactor, can be verified by unit tests.