-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use monotonic clock for measuring intervals in tests. #19659
Merged
isiu-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:monotonic-time-tests
Jun 21, 2022
Merged
Use monotonic clock for measuring intervals in tests. #19659
isiu-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:monotonic-time-tests
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we won't get spurious timeouts from clock changes.
PR #19659: Size comparison from 1e3f120 to 877cd98 Increases (3 builds for cc13x2_26x2, esp32)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jun 16, 2022
andy31415
approved these changes
Jun 16, 2022
isiu-apple
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we won't get spurious timeouts from clock changes.
Problem
Wall clock being used for measuring time intervals.
Change overview
Use monotonic clock.
Testing
Ran tests locally.