-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Segmentation fault if wifi name not initialized #19439
Merged
woody-apple
merged 1 commit into
project-chip:master
from
TE-N-ElvenWang:fix_segment_fault
Jun 16, 2022
Merged
Fix the Segmentation fault if wifi name not initialized #19439
woody-apple
merged 1 commit into
project-chip:master
from
TE-N-ElvenWang:fix_segment_fault
Jun 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee0670a
to
e48dbab
Compare
PR #19439: Size comparison from 3522f9a to e48dbab Increases (3 builds for linux, nrfconnect)
Decreases (1 build for esp32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Jun 10, 2022
e48dbab
to
6c5e0d6
Compare
PR #19439: Size comparison from f3247ba to 6c5e0d6 Increases (14 builds for linux, nrfconnect)
Decreases (1 build for telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
harsha-rajendran
approved these changes
Jun 15, 2022
The WiFi name is configured when WiFi init successfuly. Sometime, the WiFi interface is not up in some Linux platform and instead the platform use ethernet like eth0. In this condition, eth0 will have the IP update event and this update listerner will be called. On this condition, the GetWiFiIfName() will report a nullptr and cause a Segmentation fault. This patch will ignore the event and prevent the Segmentation fault. Signed-off-by: Haoran Wang <elven.wang@nxp.com>
woody-apple
approved these changes
Jun 16, 2022
Fast tracking platform changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WiFi name is configured when WiFi init successfuly.
Sometime, the WiFi interface is not up in some Linux platform and instead
the platform use ethernet like eth0.
In this condition, eth0 will have the IP update event and this update listerner
will be called.
On this condition, the GetWiFiIfName() will report a nullptr and cause a Segmentation fault.
This patch will ignore the event and prevent the Segmentation fault.
Signed-off-by: Haoran Wang elven.wang@nxp.com