-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TestEventTriggerDelegate in General Diagnostics Cluster #18852
Merged
tehampson
merged 12 commits into
project-chip:master
from
tehampson:test-event-triggers-part-two-18322
May 30, 2022
Merged
Use TestEventTriggerDelegate in General Diagnostics Cluster #18852
tehampson
merged 12 commits into
project-chip:master
from
tehampson:test-event-triggers-part-two-18322
May 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update xml and regenerate files
bd0b9e8
to
f350059
Compare
f350059
to
653fdbe
Compare
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
3d97dd6
to
25a630b
Compare
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
PR #18852: Size comparison from c671767 to 7b7d18a Increases above 0.2%:
Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18852: Size comparison from e5fe58d to f50c35c Increases above 0.2%:
Increases (35 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 28, 2022
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
9ba86bf
to
23802e9
Compare
PR #18852: Size comparison from 4d84a4a to 23802e9 Increases above 0.2%:
Increases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, nrfconnect, p6)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
May 30, 2022
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
Outdated
Show resolved
Hide resolved
PR #18852: Size comparison from e1c9658 to 8f77237 Increases above 0.2%:
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
CONSTRAINT_ERROR
CONSTRAINT_ERROR