-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for thermostat running mode attribute to all clusters app #18777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #18777: Size comparison from 2b02a50 to 38d4d8a Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18777: Size comparison from 2b02a50 to e2a9c68 Increases (4 builds for cc13x2_26x2, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18777: Size comparison from 2b02a50 to d91c793 Increases (4 builds for cc13x2_26x2, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
21d87a2
to
decafb3
Compare
PR #18777: Size comparison from d956c63 to decafb3 Increases (4 builds for cc13x2_26x2, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
daacd9e
to
1f3a8a9
Compare
PR #18777: Size comparison from 66ebfb2 to 1f3a8a9 Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 25, 2022
- Add Thermostat running mode to the m5 stack UI as well
PR #18777: Size comparison from 897d9f6 to 892be57 Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, p6)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Add thermostat running mode to the all clusters app for handling Auto mode. Also modify the m5 stack UI to add support for running mode attribute.
Change overview
Add thermostat running mode to the all clusters app for handling Auto mode. Also modify the m5 stack UI to add support for running mode attribute.
Testing
How was this tested? (at least one bullet point required)
Tested using the m5 stack