Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ConvertToNOCResponseStatus() Function Implementation. #18588

Merged
merged 1 commit into from
May 24, 2022
Merged

Updated ConvertToNOCResponseStatus() Function Implementation. #18588

merged 1 commit into from
May 24, 2022

Conversation

emargolis
Copy link
Contributor

Problem

The ConvertToNOCResponseStatus() doesn't match the spec.

Change overview

Updated

Testing

Existing tests

@boring-cyborg boring-cyborg bot added the app label May 19, 2022
@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited
Loading

PR #18588: Size comparison from 70e259c to c182bf3

Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 70e259c c182bf3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 625570 625618 48 0.0
.app_xip_area 529184 529232 48 0.0
lock cyw930739m2evb_01 (read/write) 628542 628590 48 0.0
.app_xip_area 533612 533660 48 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570998 571038 40 0.0
.app_xip_area 466352 466392 40 0.0
efr32 lighting-app BRD4161A (read only) 917676 917724 48 0.0
.text 917668 917716 48 0.0
BRD4161A+rpc (read only) 951848 951896 48 0.0
.text 951840 951888 48 0.0
BRD4161A+rs911x (read only) 791140 791172 32 0.0
.text 791132 791164 32 0.0
lock-app BRD4161A+wf200 (read only) 947140 947188 48 0.0
.text 947132 947180 48 0.0
window-app BRD4161A (read only) 897796 897844 48 0.0
.text 897788 897836 48 0.0
esp32 all-clusters-app c3devkit (read only) 1000894 1000952 58 0.0
.flash.text 1000894 1000952 58 0.0
m5stack (read only) 1056019 1056103 84 0.0
.flash.text 1050635 1050719 84 0.0
k32w light k32w061+release (read/write) 683032 683080 48 0.0
.text 599088 599136 48 0.0
lock k32w061+release (read/write) 729608 729656 48 0.0
.text 645272 645320 48 0.0
linux thermostat-no-ble arm64 (read only) 2353036 2353548 512 0.0
.text 1975808 1976320 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2420736 2420800 64 0.0
.text 1383380 1383444 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181151 1181199 48 0.0
text 810720 810772 52 0.0
p6 all-clusters-app default (read/write) 2539096 2539144 48 0.0
.text 1497360 1497408 48 0.0
light-app default (read/write) 2425512 2425560 48 0.0
.text 1383776 1383824 48 0.0
lock-app default (read/write) 2436224 2436272 48 0.0
.text 1394488 1394536 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782752 782816 64 0.0
text 553478 553542 64 0.0
lighting-app tlsr9518adk80d (read/write) 802844 802908 64 0.0
text 570244 570308 64 0.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 70e259c c182bf3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 625570 625618 48 0.0
.app_xip_area 529184 529232 48 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628542 628590 48 0.0
.app_xip_area 533612 533660 48 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570998 571038 40 0.0
.app_xip_area 466352 466392 40 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917676 917724 48 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 917668 917716 48 0.0
BRD4161A+rpc (read only) 951848 951896 48 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 951840 951888 48 0.0
BRD4161A+rs911x (read only) 791140 791172 32 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 791132 791164 32 0.0
lock-app BRD4161A+wf200 (read only) 947140 947188 48 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 947132 947180 48 0.0
window-app BRD4161A (read only) 897796 897844 48 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897788 897836 48 0.0
esp32 all-clusters-app c3devkit (read only) 1000894 1000952 58 0.0
(read/write) 1478218 1478218 0 0.0
.dram0.bss 68208 68208 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209960 209960 0 0.0
.flash.text 1000894 1000952 58 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1056019 1056103 84 0.0
(read/write) 480212 480212 0 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240288 240288 0 0.0
.flash.text 1050635 1050719 84 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 683032 683080 48 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 599088 599136 48 0.0
lock k32w061+release (read/write) 729608 729656 48 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 645272 645320 48 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9078228 9078228 0 0.0
(read/write) 646209 646209 0 0.0
.bss 42209 42209 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583944 583944 0 0.0
.dynamic 560 560 0 0.0
.got 15016 15016 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 444948 444948 0 0.0
.text 7169076 7169076 0 0.0
thermostat-no-ble arm64 (read only) 2353036 2353548 512 0.0
(read/write) 176289 176289 0 0.0
.bss 87585 87585 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147244 147244 0 0.0
.text 1975808 1976320 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420736 2420800 64 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383380 1383444 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181151 1181199 48 0.0
bss 138380 138380 0 0.0
rodata 153176 153176 0 0.0
text 810720 810772 52 0.0
p6 all-clusters-app default (read/write) 2539096 2539144 48 0.0
.bss 136176 136176 0 0.0
.data 2808 2808 0 0.0
.text 1497360 1497408 48 0.0
light-app default (read/write) 2425512 2425560 48 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383776 1383824 48 0.0
lock-app default (read/write) 2436224 2436272 48 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394488 1394536 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782752 782816 64 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 553478 553542 64 0.0
lighting-app tlsr9518adk80d (read/write) 802844 802908 64 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 570244 570308 64 0.0

@emargolis emargolis force-pushed the emargolis/feature/chip-error-to-noc-status-conversion branch from c182bf3 to 7a5cd26 Compare May 23, 2022 17:56
@github-actions
Copy link

github-actions bot commented May 23, 2022 •
edited
Loading

PR #18588: Size comparison from 721e9dd to 7a5cd26

Increases (19 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, telink)
platform target config section 721e9dd 7a5cd26 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668519 668551 32 0.0
.text 568376 568408 32 0.0
lock-ftd LP_CC2652R7 (read only) 675927 675943 16 0.0
.text 581036 581052 16 0.0
lock-mtd LP_CC2652R7 (read only) 625335 625351 16 0.0
.text 530556 530572 16 0.0
pump-app LP_CC2652R7 (read only) 676011 676027 16 0.0
.text 586628 586644 16 0.0
pump-controller-app LP_CC2652R7 (read only) 653971 654003 32 0.0
.text 569816 569848 32 0.0
shell LP_CC2652R7 (read only) 661542 661558 16 0.0
.text 564428 564444 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624150 624174 24 0.0
.app_xip_area 527508 527532 24 0.0
lock cyw930739m2evb_01 (read/write) 626962 626986 24 0.0
.app_xip_area 531776 531800 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570882 570906 24 0.0
.app_xip_area 465980 466004 24 0.0
efr32 lock-app BRD4161A+wf200 (read only) 946776 946792 16 0.0
.text 946768 946784 16 0.0
esp32 all-clusters-app c3devkit (read only) 1002948 1002966 18 0.0
.flash.text 1002948 1002966 18 0.0
m5stack (read only) 1057747 1057755 8 0.0
.flash.text 1052363 1052371 8 0.0
k32w light k32w061+release (read/write) 682488 682520 32 0.0
.text 598416 598448 32 0.0
lock k32w061+release (read/write) 728652 728668 16 0.0
.text 644188 644204 16 0.0
linux chip-tool debug (read only) 9488845 9489101 256 0.0
.text 7675605 7675861 256 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9231604 9231812 208 0.0
.text 7319332 7319540 208 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183339 1183371 32 0.0
text 812372 812396 24 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782384 782408 24 0.0
text 553428 553452 24 0.0
lighting-app tlsr9518adk80d (read/write) 802404 802428 24 0.0
text 570140 570164 24 0.0
Decreases (20 builds for cc13x2_26x2, efr32, linux, p6)
platform target config section 721e9dd 7a5cd26 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183120 183088 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 166856 166840 -16 -0.0
pump-app LP_CC2652R7 (read/write) 168260 168244 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189900 189868 -32 -0.0
shell LP_CC2652R7 (read/write) 185656 185640 -16 -0.0
efr32 lighting-app BRD4161A (read only) 915636 915620 -16 -0.0
.text 915628 915612 -16 -0.0
BRD4161A+rpc (read only) 949824 949808 -16 -0.0
.text 949816 949800 -16 -0.0
window-app BRD4161A (read only) 896908 896892 -16 -0.0
.text 896900 896884 -16 -0.0
linux all-clusters-app debug (read only) 2759513 2759241 -272 -0.0
.text 2343474 2343202 -272 -0.0
bridge-app debug+rpc (read only) 2035241 2034969 -272 -0.0
.text 1709058 1708786 -272 -0.0
lighting-app debug+rpc (read only) 2326953 2326681 -272 -0.0
.text 1972530 1972258 -272 -0.0
lock-app debug (read only) 2240449 2240177 -272 -0.0
.text 1881778 1881506 -272 -0.0
ota-provider-app debug (read only) 2065657 2065385 -272 -0.0
.text 1727218 1726946 -272 -0.0
ota-requestor-app debug (read only) 2094609 2094337 -272 -0.0
.text 1758738 1758466 -272 -0.0
shell debug (read only) 2575625 2575353 -272 -0.0
.text 2191986 2191714 -272 -0.0
thermostat-no-ble arm64 (read only) 2357180 2356860 -320 -0.0
.text 1980560 1980240 -320 -0.0
tv-app debug (read only) 2856401 2856129 -272 -0.0
.text 2453090 2452818 -272 -0.0
tv-casting-app debug (read only) 5450705 5450433 -272 -0.0
.text 4749250 4748978 -272 -0.0
p6 light-app default (read/write) 2424216 2424200 -16 -0.0
.text 1382480 1382464 -16 -0.0
lock-app default (read/write) 2434904 2434888 -16 -0.0
.text 1393168 1393152 -16 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 721e9dd 7a5cd26 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668519 668551 32 0.0
(read/write) 183120 183088 -32 -0.0
.bss 74620 74620 0 0.0
.data 3404 3404 0 0.0
.rodata 99919 99919 0 0.0
.text 568376 568408 32 0.0
lock-ftd LP_CC2652R7 (read only) 675927 675943 16 0.0
(read/write) 166856 166840 -16 -0.0
.bss 72820 72820 0 0.0
.data 3236 3236 0 0.0
.rodata 94407 94407 0 0.0
.text 581036 581052 16 0.0
lock-mtd LP_CC2652R7 (read only) 625335 625351 16 0.0
(read/write) 145652 145652 0 0.0
.bss 68556 68556 0 0.0
.data 3236 3236 0 0.0
.rodata 94287 94287 0 0.0
.text 530556 530572 16 0.0
pump-app LP_CC2652R7 (read only) 676011 676027 16 0.0
(read/write) 168260 168244 -16 -0.0
.bss 73284 73284 0 0.0
.data 3272 3272 0 0.0
.rodata 88899 88899 0 0.0
.text 586628 586644 16 0.0
pump-controller-app LP_CC2652R7 (read only) 653971 654003 32 0.0
(read/write) 189900 189868 -32 -0.0
.bss 73140 73140 0 0.0
.data 3232 3232 0 0.0
.rodata 83675 83675 0 0.0
.text 569816 569848 32 0.0
shell LP_CC2652R7 (read only) 661542 661558 16 0.0
(read/write) 185656 185640 -16 -0.0
.bss 76980 76980 0 0.0
.data 3408 3408 0 0.0
.rodata 96886 96886 0 0.0
.text 564428 564444 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624150 624174 24 0.0
.app_xip_area 527508 527532 24 0.0
.bss 79284 79284 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626962 626986 24 0.0
.app_xip_area 531776 531800 24 0.0
.bss 77860 77860 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570882 570906 24 0.0
.app_xip_area 465980 466004 24 0.0
.bss 87280 87280 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915636 915620 -16 -0.0
(read/write) 133372 133372 0 0.0
.bss 131312 131312 0 0.0
.data 2060 2060 0 0.0
.text 915628 915612 -16 -0.0
BRD4161A+rpc (read only) 949824 949808 -16 -0.0
(read/write) 150056 150056 0 0.0
.bss 147792 147792 0 0.0
.data 2264 2264 0 0.0
.text 949816 949800 -16 -0.0
BRD4161A+rs911x (read only) 790196 790196 0 0.0
(read/write) 129640 129640 0 0.0
.bss 127572 127572 0 0.0
.data 2068 2068 0 0.0
.text 790188 790188 0 0.0
lock-app BRD4161A+wf200 (read only) 946776 946792 16 0.0
(read/write) 124124 124124 0 0.0
.bss 122100 122100 0 0.0
.data 2024 2024 0 0.0
.text 946768 946784 16 0.0
window-app BRD4161A (read only) 896908 896892 -16 -0.0
(read/write) 133432 133432 0 0.0
.bss 131384 131384 0 0.0
.data 2048 2048 0 0.0
.text 896900 896884 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1002948 1002966 18 0.0
(read/write) 1478906 1478906 0 0.0
.dram0.bss 69176 69176 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209672 209672 0 0.0
.flash.text 1002948 1002966 18 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057747 1057755 8 0.0
(read/write) 480920 480920 0 0.0
.dram0.bss 74704 74704 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240020 240020 0 0.0
.flash.text 1052363 1052371 8 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682488 682520 32 0.0
.bss 80352 80352 0 0.0
.data 2016 2016 0 0.0
.text 598416 598448 32 0.0
lock k32w061+release (read/write) 728652 728668 16 0.0
.bss 80784 80784 0 0.0
.data 1976 1976 0 0.0
.text 644188 644204 16 0.0
linux all-clusters-app debug (read only) 2759513 2759241 -272 -0.0
(read/write) 177216 177216 0 0.0
.bss 86272 86272 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82712 82712 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 241437 241437 0 0.0
.text 2343474 2343202 -272 -0.0
bridge-app debug+rpc (read only) 2035241 2034969 -272 -0.0
(read/write) 148024 148024 0 0.0
.bss 73120 73120 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65384 65384 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169065 169065 0 0.0
.text 1709058 1708786 -272 -0.0
chip-tool debug (read only) 9488845 9489101 256 0.0
(read/write) 579704 579704 0 0.0
.bss 23936 23936 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 548328 548328 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 485085 485085 0 0.0
.text 7675605 7675861 256 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9231604 9231812 208 0.0
(read/write) 645937 645937 0 0.0
.bss 42225 42225 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583656 583656 0 0.0
.dynamic 560 560 0 0.0
.got 15016 15016 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 448884 448884 0 0.0
.text 7319332 7319540 208 0.0
lighting-app debug+rpc (read only) 2326953 2326681 -272 -0.0
(read/write) 153440 153440 0 0.0
.bss 74912 74912 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70728 70728 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188073 188073 0 0.0
.text 1972530 1972258 -272 -0.0
lock-app debug (read only) 2240449 2240177 -272 -0.0
(read/write) 148152 148152 0 0.0
.bss 73600 73600 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198713 198713 0 0.0
.text 1881778 1881506 -272 -0.0
ota-provider-app debug (read only) 2065657 2065385 -272 -0.0
(read/write) 141232 141232 0 0.0
.bss 73056 73056 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60600 60600 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179872 179872 0 0.0
.text 1727218 1726946 -272 -0.0
ota-requestor-app debug (read only) 2094609 2094337 -272 -0.0
(read/write) 144040 144040 0 0.0
.bss 73728 73728 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62664 62664 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175840 175840 0 0.0
.text 1758738 1758466 -272 -0.0
shell debug (read only) 2575625 2575353 -272 -0.0
(read/write) 201240 201240 0 0.0
.bss 117192 117192 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76912 76912 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 222418 222418 0 0.0
.text 2191986 2191714 -272 -0.0
thermostat-no-ble arm64 (read only) 2357180 2356860 -320 -0.0
(read/write) 176849 176849 0 0.0
.bss 88113 88113 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79416 79416 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147596 147596 0 0.0
.text 1980560 1980240 -320 -0.0
tv-app debug (read only) 2856401 2856129 -272 -0.0
(read/write) 279072 279072 0 0.0
.bss 191032 191032 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 77120 77120 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221137 221137 0 0.0
.text 2453090 2452818 -272 -0.0
tv-casting-app debug (read only) 5450705 5450433 -272 -0.0
(read/write) 226048 226048 0 0.0
.bss 78808 78808 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138632 138632 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340737 340737 0 0.0
.text 4749250 4748978 -272 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418936 2418936 0 0.0
.bss 202796 202796 0 0.0
.data 5872 5872 0 0.0
.text 1381580 1381580 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183339 1183371 32 0.0
bss 139348 139348 0 0.0
rodata 152820 152820 0 0.0
text 812372 812396 24 0.0
p6 all-clusters-app default (read/write) 2540360 2540360 0 0.0
.bss 137144 137144 0 0.0
.data 2808 2808 0 0.0
.text 1498624 1498624 0 0.0
light-app default (read/write) 2424216 2424200 -16 -0.0
.bss 129616 129616 0 0.0
.data 2608 2608 0 0.0
.text 1382480 1382464 -16 -0.0
lock-app default (read/write) 2434904 2434888 -16 -0.0
.bss 129432 129432 0 0.0
.data 2568 2568 0 0.0
.text 1393168 1393152 -16 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 782384 782408 24 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 553428 553452 24 0.0
lighting-app tlsr9518adk80d (read/write) 802404 802428 24 0.0
bss 71000 71000 0 0.0
noinit 40416 40416 0 0.0
text 570140 570164 24 0.0

bzbarsky-apple
bzbarsky-apple approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@emargolis emargolis merged commit 37129df into project-chip:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @tcarmelveilleux @bzbarsky-apple