-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add an optional timeout parameter to the pairing command #18555
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_PairingOptionalTimeout
May 18, 2022
Merged
[chip-tool] Add an optional timeout parameter to the pairing command #18555
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_PairingOptionalTimeout
May 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
May 18, 2022
pullapprove
bot
requested review from
andy31415,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
saurabhst
May 18, 2022 14:13
pullapprove
bot
requested review from
selissia,
tecimovic,
tehampson,
vijs,
wbschiller,
xylophone21,
yufengwangca and
yunhanw-google
May 18, 2022 14:13
Damian-Nordic
approved these changes
May 18, 2022
isiu-apple
reviewed
May 18, 2022
PR #18555: Size comparison from 02d8302 to 01c540b Increases (1 build for linux)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no mechanism to configure the default timeout of the pairing command.
Fix #18143
Change overview
Testing
./out/debug/standalone/chip-tool pairing qrcode 0x12344321 MT:-24J029Q00KA0648G00 --timeout 3