Address Rotating ID issues #18514

chrisdecenzo · 2022-05-17T17:19:22Z

Problem

Currently, the rotating id is generated from a #define unique id

Fixes Generate the Rotating Device Id based on Reset Counter #4224

Change overview

Add platform command to set the rotating id unique id so that platforms can call this at startup

Testing

Tested using tv-app and tv-casting-app

github-actions · 2022-05-17T17:37:58Z

PR #18514: Size comparison from 05a20b1 to 4a77455

Full report (8 builds for k32w, linux, mbed, nrfconnect, telink)

platform	target	config	section	`05a20b1`	`4a77455`
k32w	light	k32w061+release	(read/write)	682516	682516
			.bss	80200	80200
			.data	2016	2016
			.text	598596	598596
	lock	k32w061+release	(read/write)	729012	729012
			.bss	80632	80632
			.data	1976	1976
			.text	644700	644700
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	`9058756`	`9058756`
			(read/write)	644993	644993
			.bss	41105	41105
			.data	1192	1192
			.data.rel.ro	583864	583864
			.dynamic	560	560
			.got	14992	14992
			.init	24	24
			.init_array	184	184
			.rodata	445124	445124
			.text	7149732	7149732
	thermostat-no-ble	arm64	(read only)	2343780	2343780
			(read/write)	175121	175121
			.bss	86465	86465
			.data	1520	1520
			.data.rel.ro	79336	79336
			.dynamic	560	560
			.got	4768	4768
			.init	24	24
			.init_array	376	376
			.rodata	147108	147108
			.text	1966848	1966848
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2418784	2418784
			.bss	201588	201588
			.data	5872	5872
			.text	`1381428`	`1381428`
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180243	1180243
			bss	138356	138356
			rodata	152956	152956
			text	810160	810160
telink	light-switch-app	tlsr9518adk80d	(read/write)	782116	782116
			bss	70592	70592
			noinit	40416	40416
			text	553028	553028
	lighting-app	tlsr9518adk80d	(read/write)	802208	802208
			bss	70848	70848
			noinit	40416	40416
			text	569794	569794

src/controller/CommissionerDiscoveryController.cpp

github-actions · 2022-05-17T18:30:00Z

PR #18514: Size comparison from 05a20b1 to a8e79d1

Full report (10 builds for cc13x2_26x2, mbed, nrfconnect, telink)

platform	target	config	section	`05a20b1`	`a8e79d1`
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	692151	692151
			(read/write)	159384	159384
			.bss	74516	74516
			.data	3412	3412
			.rodata	103823	103823
			.text	587848	587848
	lock-ftd	LP_CC2652R7	(read only)	676863	676863
			(read/write)	165776	165776
			.bss	72676	72676
			.data	3236	3236
			.rodata	94967	94967
			.text	581412	581412
	lock-mtd	LP_CC2652R7	(read only)	625695	625695
			(read/write)	145508	145508
			.bss	68412	68412
			.data	3236	3236
			.rodata	94855	94855
			.text	530348	530348
	pump-app	LP_CC2652R7	(read only)	660387	660387
			(read/write)	183532	183532
			.bss	72932	72932
			.data	3268	3268
			.rodata	80467	80467
			.text	579440	579440
	pump-controller-app	LP_CC2652R7	(read only)	653555	653555
			(read/write)	190172	190172
			.bss	72996	72996
			.data	3232	3232
			.rodata	83571	83571
			.text	569504	569504
	shell	LP_CC2652R7	(read only)	686538	686538
			(read/write)	160820	160820
			.bss	77140	77140
			.data	3416	3416
			.rodata	101370	101370
			.text	584684	584684
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2418784	2418784
			.bss	201588	201588
			.data	5872	5872
			.text	`1381428`	`1381428`
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180243	1180243
			bss	138356	138356
			rodata	152956	152956
			text	810160	810160
telink	light-switch-app	tlsr9518adk80d	(read/write)	782116	782116
			bss	70592	70592
			noinit	40416	40416
			text	553028	553028
	lighting-app	tlsr9518adk80d	(read/write)	802208	802208
			bss	70848	70848
			noinit	40416	40416
			text	569794	569794

github-actions · 2022-05-17T20:18:35Z

PR #18514: Size comparison from 05a20b1 to 661c7bd

Increases (3 builds for nrfconnect, telink)

platform	target	config	section	`05a20b1`	`661c7bd`	change
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	text	810160	810168	8
telink	light-switch-app	tlsr9518adk80d	(read/write)	782116	782124	8
			text	553028	553036	8
	lighting-app	tlsr9518adk80d	(read/write)	802208	802216	8
			text	569794	569802	8

Full report (15 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, telink)

platform	target	config	section	`05a20b1`	`661c7bd`	change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	692151	692151	0
			(read/write)	159384	159384	0
			.bss	74516	74516	0
			.data	3412	3412	0
			.rodata	103823	103823	0
			.text	587848	587848	0
	lock-ftd	LP_CC2652R7	(read only)	676863	676863	0
			(read/write)	165776	165776	0
			.bss	72676	72676	0
			.data	3236	3236	0
			.rodata	94967	94967	0
			.text	581412	581412	0
	lock-mtd	LP_CC2652R7	(read only)	625695	625695	0
			(read/write)	145508	145508	0
			.bss	68412	68412	0
			.data	3236	3236	0
			.rodata	94855	94855	0
			.text	530348	530348	0
	pump-app	LP_CC2652R7	(read only)	660387	660387	0
			(read/write)	183532	183532	0
			.bss	72932	72932	0
			.data	3268	3268	0
			.rodata	80467	80467	0
			.text	579440	579440	0
	pump-controller-app	LP_CC2652R7	(read only)	653555	653555	0
			(read/write)	190172	190172	0
			.bss	72996	72996	0
			.data	3232	3232	0
			.rodata	83571	83571	0
			.text	569504	569504	0
	shell	LP_CC2652R7	(read only)	686538	686538	0
			(read/write)	160820	160820	0
			.bss	77140	77140	0
			.data	3416	3416	0
			.rodata	101370	101370	0
			.text	584684	584684	0
cyw30739	light	cyw930739m2evb_01	(read/write)	624766	624766	0
			.app_xip_area	528396	528396	0
			.bss	79012	79012	0
			.data	708	708	0
			.rodata	0	0	0
			.text	0	0	0
	lock	cyw930739m2evb_01	(read/write)	627826	627826	0
			.app_xip_area	532912	532912	0
			.bss	77588	77588	0
			.data	672	672	0
			.rodata	0	0	0
			.text	0	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	572266	572266	0
			.app_xip_area	467636	467636	0
			.bss	87008	87008	0
			.data	584	584	0
			.rodata	0	0	0
			.text	112	112	0
k32w	light	k32w061+release	(read/write)	682516	682516	0
			.bss	80200	80200	0
			.data	2016	2016	0
			.text	598596	598596	0
	lock	k32w061+release	(read/write)	729012	729012	0
			.bss	80632	80632	0
			.data	1976	1976	0
			.text	644700	644700	0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2418784	2418784	0
			.bss	201588	201588	0
			.data	5872	5872	0
			.text	`1381428`	`1381428`	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180243	1180243	0
			bss	138356	138356	0
			rodata	152956	152956	0
			text	810160	810168	8
telink	light-switch-app	tlsr9518adk80d	(read/write)	782116	782124	8
			bss	70592	70592	0
			noinit	40416	40416	0
			text	553028	553036	8
	lighting-app	tlsr9518adk80d	(read/write)	802208	802216	8
			bss	70848	70848	0
			noinit	40416	40416	0
			text	569794	569802	8

src/include/platform/internal/GenericConfigurationManagerImpl.ipp

examples/tv-casting-app/tv-casting-common/src/CastingServer.cpp

4224 Rotating ID issues

4a77455

boring-cyborg bot added controller examples labels May 17, 2022

pullapprove bot requested review from saurabhst, selissia and tcarmelveilleux May 17, 2022 17:19

pullapprove bot added the review - pending label May 17, 2022

pullapprove bot requested review from tecimovic, tehampson, vijs, vivien-apple, wbschiller, woody-apple, xylophone21 and yufengwangca May 17, 2022 17:19

pullapprove bot added controller examples and removed examples controller labels May 17, 2022

hnnajh approved these changes May 17, 2022

View reviewed changes

fix CI build when rotating id disabled

a8e79d1

tcarmelveilleux reviewed May 17, 2022

View reviewed changes

src/controller/CommissionerDiscoveryController.cpp Outdated Show resolved Hide resolved

missed comment cleanup

661c7bd

tcarmelveilleux approved these changes May 18, 2022

View reviewed changes

bzbarsky-apple approved these changes May 18, 2022

View reviewed changes

src/include/platform/internal/GenericConfigurationManagerImpl.ipp Outdated Show resolved Hide resolved

examples/tv-casting-app/tv-casting-common/src/CastingServer.cpp Outdated Show resolved Hide resolved

pullapprove bot added review - approved and removed review - pending labels May 18, 2022

incorporate feedback

a87d575

andy31415 merged commit 9134491 into master May 18, 2022

andy31415 deleted the tv-apps-android7 branch May 18, 2022 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address Rotating ID issues #18514

Address Rotating ID issues #18514

chrisdecenzo commented May 17, 2022

github-actions bot commented May 17, 2022 •

edited

Loading

github-actions bot commented May 17, 2022 •

edited

Loading

github-actions bot commented May 17, 2022 •

edited

Loading

Address Rotating ID issues #18514

Address Rotating ID issues #18514

Conversation

chrisdecenzo commented May 17, 2022

Problem

Change overview

Testing

github-actions bot commented May 17, 2022 • edited Loading

github-actions bot commented May 17, 2022 • edited Loading

github-actions bot commented May 17, 2022 • edited Loading

github-actions bot commented May 17, 2022 •

edited

Loading

github-actions bot commented May 17, 2022 •

edited

Loading

github-actions bot commented May 17, 2022 •

edited

Loading