Use incremental resolution for minmdns discover/resolve #18442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… target host name
|
PR #18442: Size comparison from 8456f3f to 2cc70e1 Increases above 0.2%:
Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (35 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…in logs, better log coloring and logic (do not hardcode binary bits and rely on modules
… clear any delegates set to an object about to get deleted
tcarmelveilleux
approved these changes
May 17, 2022
…ce if a test crashes
…s because of dangling pointers, only patched it up however usage of this object should be removed
|
PR #18442: Size comparison from 9acc5cb to 84aa444 Increases above 0.2%:
Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (18 builds for cc13x2_26x2, esp32, linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 18, 2022
Until the changes in project-chip#18442 DiscoveryImplPlatform::Shutdown was a no-op on most platforms, so the fact that you could not re-init after that call did not matter, because nothing had actually been shut down. Now that we are actually shutting down mResolverProxy, we need to make sure a future call to Init() will correctly re-initialize things instead of just bailing out.
andy31415
pushed a commit
that referenced
this pull request
May 18, 2022
Until the changes in #18442 DiscoveryImplPlatform::Shutdown was a no-op on most platforms, so the fact that you could not re-init after that call did not matter, because nothing had actually been shut down. Now that we are actually shutting down mResolverProxy, we need to make sure a future call to Init() will correctly re-initialize things instead of just bailing out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MinMDNS cannot issue AAAA queries if the "Additional data" of dnssd packets do not contain them when querying for ANY/SRV records.
Change overview
Use Incremental resolver from #18348 in minmdns resolver. These changes are also included:
Testing
This passes now:
CI will also validate that Discovery tests do not regress (minmdns is default on linux)
Unit tests added for the heap qname class.