Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored OnboardingCodesUtil to decrease memory footprint. #18318

Merged
merged 6 commits into from
May 16, 2022
Merged

Refactored OnboardingCodesUtil to decrease memory footprint. #18318

merged 6 commits into from
May 16, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

OnboardingCodesUtil uses SetupPayload object that contains a lot unnecessary data and takes a lot of flash.

Change overview

Replaced using SetupPayload with PayloadContents and QRCodeSetupPayloadGenerator with QRCodeBasicSetupPayloadGenerator.
It allowed to save about 3.28 k of flash for nrfconnect platform.

Testing

Verified that generated QR code and manual pairing code is the same before and after the change.

@kkasperczyk-no
Refactored OnboardingCodesUtil to decrease memory footprint.
4175f40 
OnboardingCodesUtil uses SetupPayload object that contains
a lot unnecessary data and takes a lot of flash.

Replaced using SetupPayload with PayloadContents
and QRCodeSetupPayloadGenerator with QRCodeBasicSetupPayloadGenerator.
It allowed to save about 3.28 k of flash for nrfconnect platform.
@boring-cyborg boring-cyborg bot added the app label May 11, 2022
@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR #18318: Size comparison from 588d4c9 to afa597f

Decreases (3 builds for mbed, nrfconnect, telink)
platform target config section 588d4c9 afa597f change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2420356 2416784 -3572 -0.1
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
text 572768 569116 -3652 -0.6
Full report (3 builds for mbed, nrfconnect, telink)
platform target config section 588d4c9 afa597f change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420356 2416784 -3572 -0.1
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
bss 139680 139680 0 0.0
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 569116 -3652 -0.6

@kkasperczyk-no kkasperczyk-no marked this pull request as draft May 12, 2022 10:05
@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR #18318: Size comparison from 588d4c9 to 88389ce

Increases above 0.2%:

platform target config section 588d4c9 88389ce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
Increases (5 builds for cc13x2_26x2, linux)
platform target config section 588d4c9 88389ce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
.text 7044548 7044612 64 0.0
Decreases (16 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 88389ce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.text 645128 642008 -3120 -0.5
linux thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data.rel.ro 79408 79336 -72 -0.1
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2420356 2416784 -3572 -0.1
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
text 572768 569116 -3652 -0.6
Full report (18 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 88389ce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
(read/write) 161292 164620 3328 2.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
(read/write) 164956 168316 3360 2.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
(read/write) 181672 185000 3328 1.8
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
(read/write) 188280 191636 3356 1.8
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626534 626534 0 0.0
.app_xip_area 530580 530580 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645128 642008 -3120 -0.5
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 439196 439196 0 0.0
.text 7044548 7044612 64 0.0
thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 79408 79336 -72 -0.1
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420356 2416784 -3572 -0.1
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
bss 139680 139680 0 0.0
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 569116 -3652 -0.6

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR #18318: Size comparison from 588d4c9 to 1d22155

Increases above 0.2%:

platform target config section 588d4c9 1d22155 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
Increases (6 builds for cc13x2_26x2, esp32, linux)
platform target config section 588d4c9 1d22155 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
esp32 all-clusters-app m5stack (read/write) 478312 478320 8 0.0
.flash.rodata 238308 238316 8 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
.text 7044548 7044612 64 0.0
Decreases (18 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 1d22155 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
esp32 all-clusters-app c3devkit (read only) 1001304 997366 -3938 -0.4
(read/write) 1475906 1475778 -128 -0.0
.flash.rodata 208552 208464 -88 -0.0
.flash.text 1001304 997366 -3938 -0.4
m5stack (read only) 1056067 1053643 -2424 -0.2
.flash.text 1050683 1048259 -2424 -0.2
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.text 645128 642008 -3120 -0.5
linux thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data.rel.ro 79408 79336 -72 -0.1
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2420356 2416784 -3572 -0.1
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
text 572768 569116 -3652 -0.6
Full report (20 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 1d22155 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
(read/write) 161292 164620 3328 2.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
(read/write) 164956 168316 3360 2.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
(read/write) 181672 185000 3328 1.8
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
(read/write) 188280 191636 3356 1.8
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626534 626534 0 0.0
.app_xip_area 530580 530580 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001304 997366 -3938 -0.4
(read/write) 1475906 1475778 -128 -0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208552 208464 -88 -0.0
.flash.text 1001304 997366 -3938 -0.4
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056067 1053643 -2424 -0.2
(read/write) 478312 478320 8 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238308 238316 8 0.0
.flash.text 1050683 1048259 -2424 -0.2
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645128 642008 -3120 -0.5
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 439196 439196 0 0.0
.text 7044548 7044612 64 0.0
thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 79408 79336 -72 -0.1
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420356 2416784 -3572 -0.1
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
bss 139680 139680 0 0.0
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 569116 -3652 -0.6

@kkasperczyk-no
Changed char span size for codes buffers and fixed builds
2011a62 
* Added documentation for OnboardingCodesUtil methods
* Changed char span sizes returned by codes encoding methods
to not include null terminator
* Aligned examples using GetQRCode and GetManualPairingCode
to the new API.
@kkasperczyk-no kkasperczyk-no marked this pull request as ready for review May 12, 2022 12:24
@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR #18318: Size comparison from 588d4c9 to 2011a62

Increases above 0.2%:

platform target config section 588d4c9 2011a62 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
Increases (5 builds for cc13x2_26x2, linux)
platform target config section 588d4c9 2011a62 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
.text 7044548 7044612 64 0.0
Decreases (16 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 2011a62 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.text 645128 642008 -3120 -0.5
linux thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data.rel.ro 79408 79336 -72 -0.1
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2420356 2416784 -3572 -0.1
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
text 572768 569116 -3652 -0.6
Full report (18 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 2011a62 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
(read/write) 161292 164620 3328 2.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
(read/write) 164956 168316 3360 2.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
(read/write) 181672 185000 3328 1.8
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
(read/write) 188280 191636 3356 1.8
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626534 626534 0 0.0
.app_xip_area 530580 530580 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645128 642008 -3120 -0.5
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 439196 439196 0 0.0
.text 7044548 7044612 64 0.0
thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 79408 79336 -72 -0.1
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420356 2416784 -3572 -0.1
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
bss 139680 139680 0 0.0
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 569116 -3652 -0.6

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR #18318: Size comparison from 588d4c9 to f38d41b

Increases above 0.2%:

platform target config section 588d4c9 f38d41b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
Increases (8 builds for cc13x2_26x2, efr32, esp32, linux)
platform target config section 588d4c9 f38d41b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
efr32 lighting-app BRD4161A+rs911x (read/write) 129776 129780 4 0.0
window-app BRD4161A (read/write) 134472 134580 108 0.1
.bss 132416 132528 112 0.1
esp32 all-clusters-app m5stack (read/write) 478312 478320 8 0.0
.flash.rodata 238308 238316 8 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
.text 7044548 7044612 64 0.0
Decreases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 f38d41b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
efr32 lighting-app BRD4161A (read only) 909984 905892 -4092 -0.4
.text 909976 905884 -4092 -0.4
BRD4161A+rpc (read only) 944328 940220 -4108 -0.4
(read/write) 151208 151204 -4 -0.0
.text 944320 940212 -4108 -0.4
BRD4161A+rs911x (read only) 787724 783616 -4108 -0.5
.text 787716 783608 -4108 -0.5
lock-app BRD4161A+wf200 (read only) 946816 943492 -3324 -0.4
.text 946808 943484 -3324 -0.4
window-app BRD4161A (read only) 890288 886148 -4140 -0.5
.text 890280 886140 -4140 -0.5
esp32 all-clusters-app c3devkit (read only) 1001304 997366 -3938 -0.4
(read/write) 1475906 1475778 -128 -0.0
.flash.rodata 208552 208464 -88 -0.0
.flash.text 1001304 997366 -3938 -0.4
m5stack (read only) 1056067 1053643 -2424 -0.2
.flash.text 1050683 1048259 -2424 -0.2
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.text 645128 642008 -3120 -0.5
linux thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data.rel.ro 79408 79336 -72 -0.1
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2420356 2416784 -3572 -0.1
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
text 572768 569116 -3652 -0.6
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588d4c9 f38d41b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
(read/write) 161292 164620 3328 2.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
(read/write) 164956 168316 3360 2.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
(read/write) 181672 185000 3328 1.8
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
(read/write) 188280 191636 3356 1.8
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626534 626534 0 0.0
.app_xip_area 530580 530580 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909984 905892 -4092 -0.4
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909976 905884 -4092 -0.4
BRD4161A+rpc (read only) 944328 940220 -4108 -0.4
(read/write) 151208 151204 -4 -0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944320 940212 -4108 -0.4
BRD4161A+rs911x (read only) 787724 783616 -4108 -0.5
(read/write) 129776 129780 4 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787716 783608 -4108 -0.5
lock-app BRD4161A+wf200 (read only) 946816 943492 -3324 -0.4
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946808 943484 -3324 -0.4
window-app BRD4161A (read only) 890288 886148 -4140 -0.5
(read/write) 134472 134580 108 0.1
.bss 132416 132528 112 0.1
.data 2052 2052 0 0.0
.text 890280 886140 -4140 -0.5
esp32 all-clusters-app c3devkit (read only) 1001304 997366 -3938 -0.4
(read/write) 1475906 1475778 -128 -0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208552 208464 -88 -0.0
.flash.text 1001304 997366 -3938 -0.4
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056067 1053643 -2424 -0.2
(read/write) 478312 478320 8 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238308 238316 8 0.0
.flash.text 1050683 1048259 -2424 -0.2
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645128 642008 -3120 -0.5
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943340 64 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 439196 439196 0 0.0
.text 7044548 7044612 64 0.0
thermostat-no-ble arm64 (read only) 2370244 2340052 -30192 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 79408 79336 -72 -0.1
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1963248 -30128 -1.5
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420356 2416784 -3572 -0.1
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
bss 139680 139680 0 0.0
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802732 -3796 -0.5
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 569116 -3652 -0.6

bzbarsky-apple
bzbarsky-apple reviewed May 13, 2022
View reviewed changes
src/setup_payload/Base38Encode.cpp Outdated Show resolved Hide resolved
src/setup_payload/Base38Encode.h Outdated Show resolved Hide resolved
src/setup_payload/ManualSetupPayloadGenerator.cpp Outdated Show resolved Hide resolved
src/setup_payload/QRCodeSetupPayloadGenerator.h Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request May 13, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 13, 2022 •
edited
Loading

PR #18318: Size comparison from 80cadfa to 9b64065

Increases above 0.2%:

platform target config section 80cadfa 9b64065 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
Increases (11 builds for cc13x2_26x2, efr32, linux)
platform target config section 80cadfa 9b64065 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161292 164620 3328 2.1
lock-ftd LP_CC2652R7 (read/write) 164956 168316 3360 2.0
pump-app LP_CC2652R7 (read/write) 181672 185000 3328 1.8
pump-controller-app LP_CC2652R7 (read/write) 188280 191636 3356 1.8
efr32 lighting-app BRD4161A+rs911x (read/write) 129776 129780 4 0.0
window-app BRD4161A (read/write) 134472 134580 108 0.1
.bss 132416 132528 112 0.1
linux bridge-app debug+rpc (read only) 1897401 1897481 80 0.0
.rodata 161721 161881 160 0.1
chip-tool debug (read only) 9124389 9124613 224 0.0
.rodata 472373 472565 192 0.0
.text 7327557 7327589 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943308 32 0.0
.text 7044548 7044580 32 0.0
ota-provider-app debug .rodata 176627 176659 32 0.0
tv-app debug .rodata 218635 218641 6 0.0
Decreases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 80cadfa 9b64065 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
efr32 lighting-app BRD4161A (read only) 909984 905892 -4092 -0.4
.text 909976 905884 -4092 -0.4
BRD4161A+rpc (read only) 944328 940220 -4108 -0.4
(read/write) 151208 151204 -4 -0.0
.text 944320 940212 -4108 -0.4
BRD4161A+rs911x (read only) 787724 783616 -4108 -0.5
.text 787716 783608 -4108 -0.5
lock-app BRD4161A+wf200 (read only) 946816 943492 -3324 -0.4
.text 946808 943484 -3324 -0.4
window-app BRD4161A (read only) 890288 886148 -4140 -0.5
.text 890280 886140 -4140 -0.5
esp32 all-clusters-app c3devkit (read only) 999828 995878 -3950 -0.4
(read/write) 1477138 1477010 -128 -0.0
.flash.rodata 208616 208528 -88 -0.0
.flash.text 999828 995878 -3950 -0.4
m5stack (read only) 1053755 1051315 -2440 -0.2
.flash.text 1048371 1045931 -2440 -0.2
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.text 645128 642008 -3120 -0.5
linux all-clusters-app debug (read only) 2742761 2720689 -22072 -0.8
(read/write) 174552 174456 -96 -0.1
.bss 83904 83808 -96 -0.1
.rodata 236581 236573 -8 -0.0
.text 2330306 2308242 -22064 -0.9
bridge-app debug+rpc (read/write) 121080 120984 -96 -0.1
.bss 71520 71424 -96 -0.1
.text 1612322 1612242 -80 -0.0
lighting-app debug+rpc (read only) 2331017 2310665 -20352 -0.9
(read/write) 152032 151904 -128 -0.1
.bss 73568 73440 -128 -0.2
.rodata 185881 185865 -16 -0.0
.text 1977922 1957586 -20336 -1.0
lock-app debug (read only) 2238505 2216281 -22224 -1.0
(read/write) 146616 146520 -96 -0.1
.bss 72192 72096 -96 -0.1
.rodata 195689 195673 -16 -0.0
.text 1881922 1859714 -22208 -1.2
ota-provider-app debug (read only) 2067289 2045097 -22192 -1.1
(read/write) 139696 139600 -96 -0.1
.bss 71680 71584 -96 -0.1
.text 1732290 1710066 -22224 -1.3
ota-requestor-app debug (read only) 2097537 2075313 -22224 -1.1
(read/write) 142536 142440 -96 -0.1
.bss 72320 72224 -96 -0.1
.text 1764754 1742530 -22224 -1.3
shell debug (read only) 2567777 2543209 -24568 -1.0
(read/write) 198288 198256 -32 -0.0
.got 4208 4184 -24 -0.6
.text 2186930 2162658 -24272 -1.1
thermostat-no-ble arm64 (read only) 2370244 2340020 -30224 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data.rel.ro 79408 79336 -72 -0.1
.text 1993376 1963216 -30160 -1.5
tv-app debug (read only) 2855449 2834209 -21240 -0.7
(read/write) 277472 277376 -96 -0.0
.bss 189624 189528 -96 -0.1
.text 2453586 2432338 -21248 -0.9
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2420356 2416784 -3572 -0.1
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802724 -3804 -0.5
text 572768 569108 -3660 -0.6
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 80cadfa 9b64065 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 687731 -3328 -0.5
(read/write) 161292 164620 3328 2.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 102915 -168 -0.2
.text 587492 584332 -3160 -0.5
lock-ftd LP_CC2652R7 (read only) 678499 675139 -3360 -0.5
(read/write) 164956 168316 3360 2.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94803 94635 -168 -0.2
.text 583216 580024 -3192 -0.5
lock-mtd LP_CC2652R7 (read only) 627251 623883 -3368 -0.5
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94523 -168 -0.2
.text 532072 528872 -3200 -0.6
pump-app LP_CC2652R7 (read only) 663071 659743 -3328 -0.5
(read/write) 181672 185000 3328 1.8
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80823 -168 -0.2
.text 581596 578436 -3160 -0.5
pump-controller-app LP_CC2652R7 (read only) 656263 652907 -3356 -0.5
(read/write) 188280 191636 3356 1.8
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 84087 83931 -156 -0.2
.text 571692 568492 -3200 -0.6
cyw30739 light cyw930739m2evb_01 (read/write) 627598 624482 -3116 -0.5
.app_xip_area 530188 527072 -3116 -0.6
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626534 626534 0 0.0
.app_xip_area 530580 530580 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 572182 -3120 -0.5
.app_xip_area 469632 466512 -3120 -0.7
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909984 905892 -4092 -0.4
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909976 905884 -4092 -0.4
BRD4161A+rpc (read only) 944328 940220 -4108 -0.4
(read/write) 151208 151204 -4 -0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944320 940212 -4108 -0.4
BRD4161A+rs911x (read only) 787724 783616 -4108 -0.5
(read/write) 129776 129780 4 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787716 783608 -4108 -0.5
lock-app BRD4161A+wf200 (read only) 946816 943492 -3324 -0.4
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946808 943484 -3324 -0.4
window-app BRD4161A (read only) 890288 886148 -4140 -0.5
(read/write) 134472 134580 108 0.1
.bss 132416 132528 112 0.1
.data 2052 2052 0 0.0
.text 890280 886140 -4140 -0.5
esp32 all-clusters-app c3devkit (read only) 999828 995878 -3950 -0.4
(read/write) 1477138 1477010 -128 -0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 208616 208528 -88 -0.0
.flash.text 999828 995878 -3950 -0.4
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1053755 1051315 -2440 -0.2
(read/write) 479040 479040 0 0.0
.dram0.bss 73992 73992 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238868 238868 0 0.0
.flash.text 1048371 1045931 -2440 -0.2
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 685148 682024 -3124 -0.5
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600176 597052 -3124 -0.5
lock k32w061+release (read/write) 730492 727372 -3120 -0.4
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645128 642008 -3120 -0.5
linux all-clusters-app debug (read only) 2742761 2720689 -22072 -0.8
(read/write) 174552 174456 -96 -0.1
.bss 83904 83808 -96 -0.1
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236581 236573 -8 -0.0
.text 2330306 2308242 -22064 -0.9
bridge-app debug+rpc (read only) 1897401 1897481 80 0.0
(read/write) 121080 120984 -96 -0.1
.bss 71520 71424 -96 -0.1
.data 3488 3488 0 0.0
.data.rel.ro 40712 40712 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161721 161881 160 0.1
.text 1612322 1612242 -80 -0.0
chip-tool debug (read only) 9124389 9124613 224 0.0
(read/write) 577008 577008 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 546752 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 472373 472565 192 0.0
.text 7327557 7327589 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8943276 8943308 32 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 439196 439196 0 0.0
.text 7044548 7044580 32 0.0
lighting-app debug+rpc (read only) 2331017 2310665 -20352 -0.9
(read/write) 152032 151904 -128 -0.1
.bss 73568 73440 -128 -0.2
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185881 185865 -16 -0.0
.text 1977922 1957586 -20336 -1.0
lock-app debug (read only) 2238505 2216281 -22224 -1.0
(read/write) 146616 146520 -96 -0.1
.bss 72192 72096 -96 -0.1
.data 1568 1568 0 0.0
.data.rel.ro 67160 67160 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195689 195673 -16 -0.0
.text 1881922 1859714 -22208 -1.2
ota-provider-app debug (read only) 2067289 2045097 -22192 -1.1
(read/write) 139696 139600 -96 -0.1
.bss 71680 71584 -96 -0.1
.data 1736 1736 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176627 176659 32 0.0
.text 1732290 1710066 -22224 -1.3
ota-requestor-app debug (read only) 2097537 2075313 -22224 -1.1
(read/write) 142536 142440 -96 -0.1
.bss 72320 72224 -96 -0.1
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172924 172924 0 0.0
.text 1764754 1742530 -22224 -1.3
shell debug (read only) 2567777 2543209 -24568 -1.0
(read/write) 198288 198256 -32 -0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4208 4184 -24 -0.6
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218066 218066 0 0.0
.text 2186930 2162658 -24272 -1.1
thermostat-no-ble arm64 (read only) 2370244 2340020 -30224 -1.3
(read/write) 175153 175009 -144 -0.1
.bss 86417 86353 -64 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 79408 79336 -72 -0.1
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1963216 -30160 -1.5
tv-app debug (read only) 2855449 2834209 -21240 -0.7
(read/write) 277472 277376 -96 -0.0
.bss 189624 189528 -96 -0.1
.data 4672 4672 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218635 218641 6 0.0
.text 2453586 2432338 -21248 -0.9
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420356 2416784 -3572 -0.1
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382956 1379428 -3528 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180143 1176811 -3332 -0.3
bss 139680 139680 0 0.0
rodata 151792 151628 -164 -0.1
text 809956 806792 -3164 -0.4
p6 all-clusters-app default (read/write) 2531960 2527832 -4128 -0.2
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1490224 1486096 -4128 -0.3
light-app default (read/write) 2422016 2417848 -4168 -0.2
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1380280 1376112 -4168 -0.3
lock-app default (read/write) 2431544 2427392 -4152 -0.2
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389808 1385656 -4152 -0.3
telink lighting-app tlsr9518adk80d (read/write) 806528 802724 -3804 -0.5
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 569108 -3660 -0.6

@andy31415 andy31415 merged commit 04b4f07 into project-chip:master May 16, 2022
@cpagravel cpagravel mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples lib review - approved setup payload
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkasperczyk-no @andy31415 @bzbarsky-apple @Damian-Nordic