Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExchangeContext remove unused flags #17731

Merged
merged 4 commits into from
Jun 8, 2022
Merged

ExchangeContext remove unused flags #17731

merged 4 commits into from
Jun 8, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Apr 26, 2022 •
edited
Loading

Problem

Some legacy code is not being used at all

Change overview

  • Rename HasPiggybackAckPending => HasAckCounter
  • Clear up unused code

Testing

Passed unit-tests

@pullapprove pullapprove bot requested a review from yufengwangca April 26, 2022 06:53
@github-actions
Copy link

github-actions bot commented Apr 26, 2022 •
edited
Loading

PR #17731: Size comparison from 3a7f03a to bc31d2e

Increases (2 builds for cc13x2_26x2)
platform target config section 3a7f03a bc31d2e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159828 159836 8 0.0
lock-ftd LP_CC2652R7 (read/write) 164616 164632 16 0.0
Decreases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 3a7f03a bc31d2e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692195 692187 -8 -0.0
.text 585720 585712 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 678719 678703 -16 -0.0
.text 579404 579388 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 627463 627455 -8 -0.0
.text 528260 528252 -8 -0.0
pump-app LP_CC2652R7 (read only) 651195 651187 -8 -0.0
.text 574984 574976 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 644247 644231 -16 -0.0
.text 564920 564904 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 623558 623550 -8 -0.0
.app_xip_area 526436 526428 -8 -0.0
lock cyw930739m2evb_01 (read/write) 618514 618506 -8 -0.0
.app_xip_area 522864 522856 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571230 571222 -8 -0.0
.app_xip_area 465944 465936 -8 -0.0
efr32 lighting-app BRD4161A (read only) 907776 907760 -16 -0.0
.text 907768 907752 -16 -0.0
BRD4161A+rpc (read only) 942192 942176 -16 -0.0
.text 942184 942168 -16 -0.0
window-app BRD4161A (read only) 845160 845128 -32 -0.0
.text 845152 845120 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 999482 999454 -28 -0.0
.flash.text 999482 999454 -28 -0.0
m5stack (read only) 1053791 1053779 -12 -0.0
.flash.text 1048407 1048395 -12 -0.0
k32w light k32w061+release (read/write) 688820 688804 -16 -0.0
.text 599908 599892 -16 -0.0
lock k32w061+release (read/write) 729712 729696 -16 -0.0
.text 640432 640416 -16 -0.0
linux all-clusters-app debug (read only) 2735377 2735201 -176 -0.0
.text 2326674 2326498 -176 -0.0
bridge-app debug+rpc (read only) 1891361 1891185 -176 -0.0
.text 1608946 1608770 -176 -0.0
chip-tool debug (read only) 10945293 10945117 -176 -0.0
.text 9557957 9557781 -176 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10556732 10556524 -208 -0.0
.text 8917652 8917444 -208 -0.0
lighting-app debug+rpc (read only) 2326817 2326641 -176 -0.0
.text 1976450 1976274 -176 -0.0
lock-app debug (read only) 2207169 2206993 -176 -0.0
.text 1854978 1854802 -176 -0.0
ota-provider-app debug (read only) 2059889 2059713 -176 -0.0
.text 1728146 1727970 -176 -0.0
ota-requestor-app debug (read only) 2091137 2090961 -176 -0.0
.text 1761554 1761378 -176 -0.0
shell debug (read only) 2561209 2561033 -176 -0.0
.text 2183698 2183522 -176 -0.0
thermostat-no-ble arm64 (read only) 2368284 2368076 -208 -0.0
.text 1993680 1993472 -208 -0.0
tv-app debug (read only) 2845017 2844841 -176 -0.0
.text 2446546 2446370 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177475 1177459 -16 -0.0
text 806956 806944 -12 -0.0
p6 all-clusters-app default (read/write) 2527096 2527080 -16 -0.0
.text 1485360 1485344 -16 -0.0
light-app default (read/write) 2418848 2418832 -16 -0.0
.text 1377112 1377096 -16 -0.0
lock-app default (read/write) 2423040 2423008 -32 -0.0
.text 1381304 1381272 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808020 807988 -32 -0.0
text 571792 571764 -28 -0.0
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3a7f03a bc31d2e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692195 692187 -8 -0.0
(read/write) 159828 159836 8 0.0
.bss 75008 75008 0 0.0
.data 3396 3396 0 0.0
.rodata 105995 105995 0 0.0
.text 585720 585712 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 678719 678703 -16 -0.0
(read/write) 164616 164632 16 0.0
.bss 73376 73376 0 0.0
.data 3220 3220 0 0.0
.rodata 98831 98831 0 0.0
.text 579404 579388 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 627463 627455 -8 -0.0
(read/write) 146172 146172 0 0.0
.bss 69096 69096 0 0.0
.data 3220 3220 0 0.0
.rodata 98711 98711 0 0.0
.text 528260 528252 -8 -0.0
pump-app LP_CC2652R7 (read only) 651195 651187 -8 -0.0
(read/write) 151684 151684 0 0.0
.bss 73552 73552 0 0.0
.data 3252 3252 0 0.0
.rodata 75723 75723 0 0.0
.text 574984 574976 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 644247 644231 -16 -0.0
(read/write) 151440 151440 0 0.0
.bss 73600 73600 0 0.0
.data 3216 3216 0 0.0
.rodata 78839 78839 0 0.0
.text 564920 564904 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 623558 623550 -8 -0.0
.app_xip_area 526436 526428 -8 -0.0
.bss 79780 79780 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 618514 618506 -8 -0.0
.app_xip_area 522864 522856 -8 -0.0
.bss 78340 78340 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571230 571222 -8 -0.0
.app_xip_area 465944 465936 -8 -0.0
.bss 87680 87680 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907776 907760 -16 -0.0
(read/write) 134912 134912 0 0.0
.bss 132864 132864 0 0.0
.data 2044 2044 0 0.0
.text 907768 907752 -16 -0.0
BRD4161A+rpc (read only) 942192 942176 -16 -0.0
(read/write) 151592 151592 0 0.0
.bss 149344 149344 0 0.0
.data 2248 2248 0 0.0
.text 942184 942168 -16 -0.0
window-app BRD4161A (read only) 845160 845128 -32 -0.0
(read/write) 133000 133000 0 0.0
.bss 131040 131040 0 0.0
.data 1956 1956 0 0.0
.text 845152 845120 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 999482 999454 -28 -0.0
(read/write) 1473666 1473666 0 0.0
.dram0.bss 68176 68176 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206616 206616 0 0.0
.flash.text 999482 999454 -28 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053791 1053779 -12 -0.0
(read/write) 475656 475656 0 0.0
.dram0.bss 73696 73696 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235956 235956 0 0.0
.flash.text 1048407 1048395 -12 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688820 688804 -16 -0.0
.bss 81112 81112 0 0.0
.data 2000 2000 0 0.0
.text 599908 599892 -16 -0.0
lock k32w061+release (read/write) 729712 729696 -16 -0.0
.bss 81520 81520 0 0.0
.data 1960 1960 0 0.0
.text 640432 640416 -16 -0.0
linux all-clusters-app debug (read only) 2735377 2735201 -176 -0.0
(read/write) 172872 172872 0 0.0
.bss 83168 83168 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81640 81640 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 233861 233861 0 0.0
.text 2326674 2326498 -176 -0.0
bridge-app debug+rpc (read only) 1891361 1891185 -176 -0.0
(read/write) 120304 120304 0 0.0
.bss 71168 71168 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40392 40392 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 159633 159633 0 0.0
.text 1608946 1608770 -176 -0.0
chip-tool debug (read only) 10945293 10945117 -176 -0.0
(read/write) 375792 375792 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 345808 345808 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 547381 547381 0 0.0
.text 9557957 9557781 -176 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10556732 10556524 -208 -0.0
(read/write) 497697 497697 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393104 393104 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 521228 521228 0 0.0
.text 8917652 8917444 -208 -0.0
lighting-app debug+rpc (read only) 2326817 2326641 -176 -0.0
(read/write) 151256 151256 0 0.0
.bss 73216 73216 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70328 70328 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 183729 183729 0 0.0
.text 1976450 1976274 -176 -0.0
lock-app debug (read only) 2207169 2206993 -176 -0.0
(read/write) 145640 145640 0 0.0
.bss 71808 71808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66664 66664 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192193 192193 0 0.0
.text 1854978 1854802 -176 -0.0
ota-provider-app debug (read only) 2059889 2059713 -176 -0.0
(read/write) 138888 138888 0 0.0
.bss 71232 71232 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60216 60216 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174235 174235 0 0.0
.text 1728146 1727970 -176 -0.0
ota-requestor-app debug (read only) 2091137 2090961 -176 -0.0
(read/write) 141696 141696 0 0.0
.bss 71872 71872 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170588 170588 0 0.0
.text 1761554 1761378 -176 -0.0
shell debug (read only) 2561209 2561033 -176 -0.0
(read/write) 196840 196840 0 0.0
.bss 113768 113768 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75992 75992 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215602 215602 0 0.0
.text 2183698 2183522 -176 -0.0
thermostat-no-ble arm64 (read only) 2368284 2368076 -208 -0.0
(read/write) 174369 174369 0 0.0
.bss 86097 86097 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79008 79008 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145500 145500 0 0.0
.text 1993680 1993472 -208 -0.0
tv-app debug (read only) 2845017 2844841 -176 -0.0
(read/write) 276536 276536 0 0.0
.bss 189112 189112 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76568 76568 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216011 216011 0 0.0
.text 2446546 2446370 -176 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411676 2411676 0 0.0
.bss 205660 205660 0 0.0
.data 5848 5848 0 0.0
.text 1374276 1374276 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177475 1177459 -16 -0.0
bss 141784 141784 0 0.0
rodata 150100 150100 0 0.0
text 806956 806944 -12 -0.0
p6 all-clusters-app default (read/write) 2527096 2527080 -16 -0.0
.bss 139040 139040 0 0.0
.data 2784 2784 0 0.0
.text 1485360 1485344 -16 -0.0
light-app default (read/write) 2418848 2418832 -16 -0.0
.bss 132520 132520 0 0.0
.data 2584 2584 0 0.0
.text 1377112 1377096 -16 -0.0
lock-app default (read/write) 2423040 2423008 -32 -0.0
.bss 132320 132320 0 0.0
.data 2544 2544 0 0.0
.text 1381304 1381272 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808020 807988 -32 -0.0
bss 75216 75216 0 0.0
noinit 40416 40416 0 0.0
text 571792 571764 -28 -0.0

bzbarsky-apple
bzbarsky-apple reviewed Apr 27, 2022
View reviewed changes
src/messaging/ReliableMessageContext.h Outdated Show resolved Hide resolved
src/messaging/ReliableMessageContext.h Outdated Show resolved Hide resolved
@pullapprove pullapprove bot requested review from arkq and jtung-apple and removed request for austinh0 May 4, 2022 16:07
@stale
Copy link

stale bot commented May 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label May 13, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label May 14, 2022
@bzbarsky-apple
Copy link
Contributor

@kghost are you still planning to get back to this?

@stale
Copy link

stale bot commented May 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label May 25, 2022
@stale
Copy link

stale bot commented Jun 4, 2022

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Jun 4, 2022
@bzbarsky-apple bzbarsky-apple reopened this Jun 4, 2022
@stale stale bot removed the stale Stale issue or PR label Jun 4, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #17731: Size comparison from fbce051 to d2cec1b

Increases (5 builds for cc13x2_26x2)
platform target config section fbce051 d2cec1b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161552 161560 8 0.0
lock-ftd LP_CC2652R7 (read/write) 159104 159112 8 0.0
pump-app LP_CC2652R7 (read/write) 178564 178572 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 188092 188100 8 0.0
shell LP_CC2652R7 (read/write) 164768 164776 8 0.0
Decreases (33 builds for cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, p6, telink)
platform target config section fbce051 d2cec1b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690303 690295 -8 -0.0
.text 577680 577672 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640919 640911 -8 -0.0
.text 551248 551240 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 683815 683807 -8 -0.0
.text 585164 585156 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 633231 633223 -8 -0.0
.text 534684 534676 -8 -0.0
pump-app LP_CC2652R7 (read only) 665267 665259 -8 -0.0
.text 578436 578428 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 655843 655835 -8 -0.0
.text 571124 571116 -8 -0.0
shell LP_CC2652R7 (read only) 682582 682574 -8 -0.0
.text 573360 573352 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602546 602530 -16 -0.0
.app_xip_area 461492 461476 -16 -0.0
lock cyw930739m2evb_01 (read/write) 599630 599614 -16 -0.0
.app_xip_area 458440 458424 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599366 599358 -8 -0.0
.app_xip_area 459292 459284 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1008060 1008034 -26 -0.0
.flash.text 1008060 1008034 -26 -0.0
m5stack (read only) 1062859 1062843 -16 -0.0
.flash.text 1057475 1057459 -16 -0.0
linux all-clusters-app debug (read only) 2893417 2893241 -176 -0.0
.text 2463346 2463170 -176 -0.0
all-clusters-minimal-app debug (read only) 2754929 2754753 -176 -0.0
.text 2325554 2325378 -176 -0.0
bridge-app debug+rpc (read only) 2198961 2198785 -176 -0.0
.text 1852146 1851970 -176 -0.0
chip-tool debug (read only) 9737285 9737109 -176 -0.0
.text 7829877 7829701 -176 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9474780 -208 -0.0
.text 7470420 7470212 -208 -0.0
lighting-app debug+rpc (read only) 2483377 2483201 -176 -0.0
.text 2110306 2110130 -176 -0.0
lock-app debug (read only) 2429329 2429153 -176 -0.0
.text 2047234 2047058 -176 -0.0
ota-provider-app debug (read only) 2204761 2204585 -176 -0.0
.text 1853058 1852882 -176 -0.0
ota-requestor-app debug (read only) 2266409 2266233 -176 -0.0
.text 1907282 1907106 -176 -0.0
shell debug (read only) 2585089 2584913 -176 -0.0
.text 2198322 2198146 -176 -0.0
thermostat-no-ble arm64 (read only) 2544956 2544748 -208 -0.0
.text 2147776 2147568 -208 -0.0
tv-app debug (read only) 3031449 3031273 -176 -0.0
.text 2605650 2605474 -176 -0.0
tv-casting-app debug (read only) 5335041 5334865 -176 -0.0
.text 4643986 4643810 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1192163 -16 -0.0
text 817264 817252 -12 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 789312 789304 -8 -0.0
p6 all-clusters-app default (read/write) 2544880 2544864 -16 -0.0
.text 1503144 1503128 -16 -0.0
all-clusters-minimal-app default (read/write) 2489744 2489728 -16 -0.0
.text 1448008 1447992 -16 -0.0
light-app default (read/write) 2421656 2421624 -32 -0.0
.text 1379920 1379888 -32 -0.0
lock-app default (read/write) 2441992 2441960 -32 -0.0
.text 1400256 1400224 -32 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781908 -32 -0.0
text 552812 552782 -30 -0.0
lighting-app tlsr9518adk80d (read/write) 801952 801920 -32 -0.0
text 569532 569500 -32 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fbce051 d2cec1b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690303 690295 -8 -0.0
(read/write) 161552 161560 8 0.0
.bss 74748 74748 0 0.0
.data 3392 3392 0 0.0
.rodata 112311 112311 0 0.0
.text 577680 577672 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640919 640911 -8 -0.0
(read/write) 158220 158220 0 0.0
.bss 73972 73972 0 0.0
.data 3332 3332 0 0.0
.rodata 89351 89351 0 0.0
.text 551248 551240 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 683815 683807 -8 -0.0
(read/write) 159104 159112 8 0.0
.bss 72700 72700 0 0.0
.data 3256 3256 0 0.0
.rodata 98167 98167 0 0.0
.text 585164 585156 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 633231 633223 -8 -0.0
(read/write) 145808 145808 0 0.0
.bss 68436 68436 0 0.0
.data 3256 3256 0 0.0
.rodata 98055 98055 0 0.0
.text 534684 534676 -8 -0.0
pump-app LP_CC2652R7 (read only) 665267 665259 -8 -0.0
(read/write) 178564 178572 8 0.0
.bss 72844 72844 0 0.0
.data 3292 3292 0 0.0
.rodata 86347 86347 0 0.0
.text 578436 578428 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 655843 655835 -8 -0.0
(read/write) 188092 188100 8 0.0
.bss 72948 72948 0 0.0
.data 3252 3252 0 0.0
.rodata 84235 84235 0 0.0
.text 571124 571116 -8 -0.0
shell LP_CC2652R7 (read only) 682582 682574 -8 -0.0
(read/write) 164768 164776 8 0.0
.bss 77044 77044 0 0.0
.data 3396 3396 0 0.0
.rodata 108910 108910 0 0.0
.text 573360 573352 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602546 602530 -16 -0.0
.app_xip_area 461492 461476 -16 -0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599630 599614 -16 -0.0
.app_xip_area 458440 458424 -16 -0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599366 599358 -8 -0.0
.app_xip_area 459292 459284 -8 -0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1008060 1008034 -26 -0.0
(read/write) 1481914 1481914 0 0.0
.dram0.bss 69256 69256 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212568 212568 0 0.0
.flash.text 1008060 1008034 -26 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062859 1062843 -16 -0.0
(read/write) 484048 484048 0 0.0
.dram0.bss 74776 74776 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243076 243076 0 0.0
.flash.text 1057475 1057459 -16 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653944 653944 0 0.0
.bss 70052 70052 0 0.0
.data 2004 2004 0 0.0
.text 576088 576088 0 0.0
lock k32w061+release (read/write) 715036 715036 0 0.0
.bss 70492 70492 0 0.0
.data 1976 1976 0 0.0
.text 636768 636768 0 0.0
linux all-clusters-app debug (read only) 2893417 2893241 -176 -0.0
(read/write) 180056 180056 0 0.0
.bss 87872 87872 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255549 255549 0 0.0
.text 2463346 2463170 -176 -0.0
all-clusters-minimal-app debug (read only) 2754929 2754753 -176 -0.0
(read/write) 171672 171672 0 0.0
.bss 87040 87040 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256861 256861 0 0.0
.text 2325554 2325378 -176 -0.0
bridge-app debug+rpc (read only) 2198961 2198785 -176 -0.0
(read/write) 149560 149560 0 0.0
.bss 74528 74528 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187904 187904 0 0.0
.text 1852146 1851970 -176 -0.0
chip-tool debug (read only) 9737285 9737109 -176 -0.0
(read/write) 608064 608064 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575240 575240 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505405 505405 0 0.0
.text 7829877 7829701 -176 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9474780 -208 -0.0
(read/write) 674321 674321 0 0.0
.bss 43729 43729 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610696 610696 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467548 467548 0 0.0
.text 7470420 7470212 -208 -0.0
lighting-app debug+rpc (read only) 2483377 2483201 -176 -0.0
(read/write) 155168 155168 0 0.0
.bss 76352 76352 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205480 205480 0 0.0
.text 2110306 2110130 -176 -0.0
lock-app debug (read only) 2429329 2429153 -176 -0.0
(read/write) 150304 150304 0 0.0
.bss 75072 75072 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219496 219496 0 0.0
.text 2047234 2047058 -176 -0.0
ota-provider-app debug (read only) 2204761 2204585 -176 -0.0
(read/write) 143296 143296 0 0.0
.bss 74528 74528 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 192024 192024 0 0.0
.text 1853058 1852882 -176 -0.0
ota-requestor-app debug (read only) 2266409 2266233 -176 -0.0
(read/write) 146344 146344 0 0.0
.bss 75296 75296 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195392 195392 0 0.0
.text 1907282 1907106 -176 -0.0
shell debug (read only) 2585089 2584913 -176 -0.0
(read/write) 203232 203232 0 0.0
.bss 118760 118760 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228146 228146 0 0.0
.text 2198322 2198146 -176 -0.0
thermostat-no-ble arm64 (read only) 2544956 2544748 -208 -0.0
(read/write) 183153 183153 0 0.0
.bss 91457 91457 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82168 82168 0 0.0
.dynamic 528 528 0 0.0
.got 5000 5000 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160196 160196 0 0.0
.text 2147776 2147568 -208 -0.0
tv-app debug (read only) 3031449 3031273 -176 -0.0
(read/write) 281936 281936 0 0.0
.bss 192648 192648 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 240736 240736 0 0.0
.text 2605650 2605474 -176 -0.0
tv-casting-app debug (read only) 5335041 5334865 -176 -0.0
(read/write) 224000 224000 0 0.0
.bss 80168 80168 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135168 135168 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340576 340576 0 0.0
.text 4643986 4643810 -176 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429848 2429848 0 0.0
.bss 202724 202724 0 0.0
.data 5872 5872 0 0.0
.text 1392492 1392492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1192163 -16 -0.0
bss 141378 141378 0 0.0
rodata 154628 154628 0 0.0
text 817264 817252 -12 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139891 1139891 0 0.0
bss 140595 140595 0 0.0
rodata 131124 131124 0 0.0
text 789312 789304 -8 -0.0
p6 all-clusters-app default (read/write) 2544880 2544864 -16 -0.0
.bss 137208 137208 0 0.0
.data 2808 2808 0 0.0
.text 1503144 1503128 -16 -0.0
all-clusters-minimal-app default (read/write) 2489744 2489728 -16 -0.0
.bss 136416 136416 0 0.0
.data 2752 2752 0 0.0
.text 1448008 1447992 -16 -0.0
light-app default (read/write) 2421656 2421624 -32 -0.0
.bss 129520 129520 0 0.0
.data 2600 2600 0 0.0
.text 1379920 1379888 -32 -0.0
lock-app default (read/write) 2441992 2441960 -32 -0.0
.bss 129344 129344 0 0.0
.data 2576 2576 0 0.0
.text 1400256 1400224 -32 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781908 -32 -0.0
bss 70652 70652 0 0.0
noinit 40416 40416 0 0.0
text 552812 552782 -30 -0.0
lighting-app tlsr9518adk80d (read/write) 801952 801920 -32 -0.0
bss 70904 70904 0 0.0
noinit 40416 40416 0 0.0
text 569532 569500 -32 -0.0

@kghost kghost merged commit 3a5d086 into project-chip:master Jun 8, 2022
@kghost kghost deleted the exchange-2 branch June 8, 2022 18:03
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@kghost @bzbarsky-apple @mkardous-silabs
ExchangeContext remove unused flags (project-chip#17731)
29172e7 
* ExchangeContext remove unused flags

* Update src/messaging/ReliableMessageContext.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Resolve comments: do not rename HasPiggybackAckPending

* Update comments

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@arkq arkq Awaiting requested review from arkq

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @bzbarsky-apple @andy31415