Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExchageContext: remove unused flag #17661

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Apr 23, 2022

Problem

Some legacy code is not being used at all

Change overview

Clear up unused code

Testing

Passed unit-tests

@github-actions
Copy link

github-actions bot commented Apr 23, 2022

PR #17661: Size comparison from 73579c9 to ca420b5

Increases (2 builds for cc13x2_26x2)
platform target config section 73579c9 ca420b5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161952 161960 8 0.0
lock-ftd LP_CC2652R7 (read/write) 166548 166564 16 0.0
Decreases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 73579c9 ca420b5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690975 690967 -8 -0.0
.text 584480 584472 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 677347 677331 -16 -0.0
.text 578076 578060 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626099 626083 -16 -0.0
.text 526940 526924 -16 -0.0
pump-app LP_CC2652R7 (read only) 649863 649847 -16 -0.0
.text 573744 573728 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642851 642835 -16 -0.0
.text 563592 563576 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618134 618118 -16 -0.0
.app_xip_area 525140 525124 -16 -0.0
lock cyw930739m2evb_01 (read/write) 613082 613066 -16 -0.0
.app_xip_area 521568 521552 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565726 565710 -16 -0.0
.app_xip_area 464624 464608 -16 -0.0
efr32 lighting-app BRD4161A (read only) 905880 905848 -32 -0.0
.text 905872 905840 -32 -0.0
BRD4161A+rpc (read only) 940296 940264 -32 -0.0
.text 940288 940256 -32 -0.0
window-app BRD4161A (read only) 843352 843320 -32 -0.0
.text 843344 843312 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 997990 997972 -18 -0.0
.flash.text 997990 997972 -18 -0.0
m5stack (read only) 1052195 1052155 -40 -0.0
.flash.text 1046811 1046771 -40 -0.0
k32w light k32w061+release (read/write) 684128 684112 -16 -0.0
.text 598672 598656 -16 -0.0
lock k32w061+release (read/write) 725220 725204 -16 -0.0
.text 639172 639156 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10549900 10549724 -176 -0.0
.text 8911188 8911012 -176 -0.0
thermostat-no-ble arm64 (read only) 2361436 2361276 -160 -0.0
.text 1987232 1987072 -160 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 805664 805652 -12 -0.0
p6 all-clusters-app default (read/write) 2525168 2525136 -32 -0.0
.text 1483432 1483400 -32 -0.0
light-app default (read/write) 2416936 2416904 -32 -0.0
.text 1375200 1375168 -32 -0.0
lock-app default (read/write) 2421112 2421080 -32 -0.0
.text 1379376 1379344 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801048 801032 -16 -0.0
text 570394 570376 -18 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 73579c9 ca420b5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690975 690967 -8 -0.0
(read/write) 161952 161960 8 0.0
.bss 75912 75912 0 0.0
.data 3396 3396 0 0.0
.rodata 106015 106015 0 0.0
.text 584480 584472 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 677347 677331 -16 -0.0
(read/write) 166548 166564 16 0.0
.bss 73936 73936 0 0.0
.data 3220 3220 0 0.0
.rodata 98787 98787 0 0.0
.text 578076 578060 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626099 626083 -16 -0.0
(read/write) 146732 146732 0 0.0
.bss 69656 69656 0 0.0
.data 3220 3220 0 0.0
.rodata 98667 98667 0 0.0
.text 526940 526924 -16 -0.0
pump-app LP_CC2652R7 (read only) 649863 649847 -16 -0.0
(read/write) 152532 152532 0 0.0
.bss 74400 74400 0 0.0
.data 3252 3252 0 0.0
.rodata 75631 75631 0 0.0
.text 573744 573728 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642851 642835 -16 -0.0
(read/write) 151944 151944 0 0.0
.bss 74104 74104 0 0.0
.data 3216 3216 0 0.0
.rodata 78771 78771 0 0.0
.text 563592 563576 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618134 618118 -16 -0.0
.app_xip_area 525140 525124 -16 -0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613082 613066 -16 -0.0
.app_xip_area 521568 521552 -16 -0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565726 565710 -16 -0.0
.app_xip_area 464624 464608 -16 -0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905880 905848 -32 -0.0
(read/write) 129392 129392 0 0.0
.bss 127344 127344 0 0.0
.data 2044 2044 0 0.0
.text 905872 905840 -32 -0.0
BRD4161A+rpc (read only) 940296 940264 -32 -0.0
(read/write) 146072 146072 0 0.0
.bss 143824 143824 0 0.0
.data 2248 2248 0 0.0
.text 940288 940256 -32 -0.0
window-app BRD4161A (read only) 843352 843320 -32 -0.0
(read/write) 127480 127480 0 0.0
.bss 125520 125520 0 0.0
.data 1956 1956 0 0.0
.text 843344 843312 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 997990 997972 -18 -0.0
(read/write) 1468074 1468074 0 0.0
.dram0.bss 62640 62640 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 997990 997972 -18 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1052195 1052155 -40 -0.0
(read/write) 470080 470080 0 0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235916 235916 0 0.0
.flash.text 1046811 1046771 -40 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684128 684112 -16 -0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598672 598656 -16 -0.0
lock k32w061+release (read/write) 725220 725204 -16 -0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639172 639156 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10549900 10549724 -176 -0.0
(read/write) 497633 497633 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393088 393088 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 521052 521052 0 0.0
.text 8911188 8911012 -176 -0.0
thermostat-no-ble arm64 (read only) 2361436 2361276 -160 -0.0
(read/write) 151137 151137 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78992 78992 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145164 145164 0 0.0
.text 1987232 1987072 -160 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410108 2410108 0 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372708 1372708 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170627 1170627 0 0.0
bss 136264 136264 0 0.0
rodata 150052 150052 0 0.0
text 805664 805652 -12 -0.0
p6 all-clusters-app default (read/write) 2525168 2525136 -32 -0.0
.bss 118376 118376 0 0.0
.data 2784 2784 0 0.0
.text 1483432 1483400 -32 -0.0
light-app default (read/write) 2416936 2416904 -32 -0.0
.bss 111856 111856 0 0.0
.data 2584 2584 0 0.0
.text 1375200 1375168 -32 -0.0
lock-app default (read/write) 2421112 2421080 -32 -0.0
.bss 111656 111656 0 0.0
.data 2544 2544 0 0.0
.text 1379376 1379344 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801048 801032 -16 -0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570394 570376 -18 -0.0

@andy31415 andy31415 merged commit 2825fa1 into project-chip:master Apr 23, 2022
@kghost kghost deleted the exchange-3 branch April 26, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants