Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Add --commissioner-fabricid parameter #17309

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[chip-tool] Add --commissioner-fabricid parameter #17309

merged 1 commit into from
Apr 19, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

There is no way to override the fabric id.

Change overview

  • Add a --commissioner-fabricid optional parameter to cluster commands

@vivien-apple vivien-apple self-assigned this Apr 13, 2022
This was referenced Apr 13, 2022
Closed
Closed
@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17309: Size comparison from be946b0 to a19b004

Increases (1 build for linux)
platform target config section be946b0 a19b004 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10277348 10277460 112 0.0
.rodata 512244 512276 32 0.0
.text 8661844 8661924 80 0.0
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section be946b0 a19b004 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640211 640211 0 0.0
(read/write) 151212 151212 0 0.0
.bss 74144 74144 0 0.0
.data 3212 3212 0 0.0
.rodata 80163 80163 0 0.0
.text 559556 559556 0 0.0
lock-mtd LP_CC2652R7 (read only) 588947 588947 0 0.0
(read/write) 146932 146932 0 0.0
.bss 69864 69864 0 0.0
.data 3212 3212 0 0.0
.rodata 80043 80043 0 0.0
.text 508412 508412 0 0.0
pump-app LP_CC2652R7 (read only) 648287 648287 0 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75351 75351 0 0.0
.text 572448 572448 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642267 642267 0 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 78987 78987 0 0.0
.text 562792 562792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618818 618818 0 0.0
.app_xip_area 525528 525528 0 0.0
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576414 576414 0 0.0
.app_xip_area 484660 484660 0 0.0
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564938 564938 0 0.0
.app_xip_area 463556 463556 0 0.0
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907300 907300 0 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 907292 907292 0 0.0
BRD4161A+rpc (read only) 941668 941668 0 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 941660 941660 0 0.0
window-app BRD4161A (read only) 844292 844292 0 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 844284 844284 0 0.0
esp32 all-clusters-app c3devkit (read only) 979702 979702 0 0.0
(read/write) 1397514 1397514 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201552 201552 0 0.0
.flash.text 979702 979702 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035283 1035283 0 0.0
(read/write) 465252 465252 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231120 231120 0 0.0
.flash.text 1029899 1029899 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 687036 687036 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 601072 601072 0 0.0
lock k32w061+release (read/write) 691652 691652 0 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 605152 605152 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10277348 10277460 112 0.0
(read/write) 492209 492209 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388816 388816 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512244 512276 32 0.0
.text 8661844 8661924 80 0.0
thermostat-no-ble arm64 (read only) 2352444 2352444 0 0.0
(read/write) 150993 150993 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144540 144540 0 0.0
.text 1979328 1979328 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156151 1156151 0 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 795236 795236 0 0.0
p6 all-clusters-app default (read/write) 2514704 2514704 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1472968 1472968 0 0.0
light-app default (read/write) 2415176 2415176 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373440 1373440 0 0.0
lock-app default (read/write) 2378744 2378744 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1337008 1337008 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801264 801264 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 569958 569958 0 0.0

@vivien-apple
Copy link
Contributor Author

/rebase

@vivien-apple vivien-apple force-pushed the ChipTool_CommissionerFabricIdParameter branch from a19b004 to d9a9820 Compare April 13, 2022 14:54
@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17309: Size comparison from 184bda1 to d9a9820

Increases (2 builds for linux)
platform target config section 184bda1 d9a9820 change % change
linux chip-tool debug (read only) 10683941 10684069 128 0.0
.text 9315669 9315797 128 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10283492 10283588 96 0.0
.rodata 513028 513044 16 0.0
.text 8667044 8667124 80 0.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 184bda1 d9a9820 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640435 640435 0 0.0
(read/write) 151212 151212 0 0.0
.bss 74144 74144 0 0.0
.data 3212 3212 0 0.0
.rodata 80227 80227 0 0.0
.text 559716 559716 0 0.0
lock-mtd LP_CC2652R7 (read only) 589171 589171 0 0.0
(read/write) 146932 146932 0 0.0
.bss 69864 69864 0 0.0
.data 3212 3212 0 0.0
.rodata 80107 80107 0 0.0
.text 508572 508572 0 0.0
pump-app LP_CC2652R7 (read only) 648527 648527 0 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75415 75415 0 0.0
.text 572624 572624 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642499 642499 0 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 79051 79051 0 0.0
.text 562960 562960 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 619042 619042 0 0.0
.app_xip_area 525752 525752 0 0.0
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576646 576646 0 0.0
.app_xip_area 484892 484892 0 0.0
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565170 565170 0 0.0
.app_xip_area 463788 463788 0 0.0
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907716 907716 0 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 907708 907708 0 0.0
BRD4161A+rpc (read only) 942084 942084 0 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 942076 942076 0 0.0
window-app BRD4161A (read only) 844708 844708 0 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 844700 844700 0 0.0
esp32 all-clusters-app c3devkit (read only) 979972 979972 0 0.0
(read/write) 1397578 1397578 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201616 201616 0 0.0
.flash.text 979972 979972 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035459 1035459 0 0.0
(read/write) 465316 465316 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231184 231184 0 0.0
.flash.text 1030075 1030075 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 687260 687260 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 601296 601296 0 0.0
lock k32w061+release (read/write) 691892 691892 0 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 605392 605392 0 0.0
linux all-clusters-app debug (read only) 2697969 2697969 0 0.0
(read/write) 149216 149216 0 0.0
.bss 60192 60192 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 81080 81080 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 232421 232421 0 0.0
.text 2291554 2291554 0 0.0
bridge-app debug+rpc (read only) 1837581 1837581 0 0.0
(read/write) 91856 91856 0 0.0
.bss 44480 44480 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39376 39376 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148505 148505 0 0.0
.text 1570645 1570645 0 0.0
chip-tool debug (read only) 10683941 10684069 128 0.0
(read/write) 371832 371832 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341728 341728 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538965 538965 0 0.0
.text 9315669 9315797 128 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10283492 10283588 96 0.0
(read/write) 492273 492273 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388840 388840 0 0.0
.dynamic 560 560 0 0.0
.got 57440 57440 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 513028 513044 16 0.0
.text 8667044 8667124 80 0.0
door-lock-app debug (read only) 2108929 2108929 0 0.0
(read/write) 119600 119600 0 0.0
.bss 48064 48064 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64504 64504 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186697 186697 0 0.0
.text 1766530 1766530 0 0.0
lighting-app debug+rpc (read only) 2313769 2313769 0 0.0
(read/write) 127920 127920 0 0.0
.bss 50272 50272 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182665 182665 0 0.0
.text 1965266 1965266 0 0.0
ota-provider-app debug (read only) 2046145 2046145 0 0.0
(read/write) 115040 115040 0 0.0
.bss 47968 47968 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172515 172515 0 0.0
.text 1717442 1717442 0 0.0
ota-requestor-app debug (read only) 2076521 2076521 0 0.0
(read/write) 118392 118392 0 0.0
.bss 48960 48960 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61960 61960 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169388 169388 0 0.0
.text 1749074 1749074 0 0.0
shell debug (read only) 2525825 2525825 0 0.0
(read/write) 150064 150064 0 0.0
.bss 67624 67624 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75464 75464 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214738 214738 0 0.0
.text 2149922 2149922 0 0.0
thermostat-no-ble arm64 (read only) 2353620 2353620 0 0.0
(read/write) 151121 151121 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78752 78752 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144548 144548 0 0.0
.text 1980496 1980496 0 0.0
tv-app debug (read only) 2797265 2797265 0 0.0
(read/write) 250784 250784 0 0.0
.bss 164112 164112 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 76008 76008 0 0.0
.dynamic 592 592 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213259 213259 0 0.0
.text 2402706 2402706 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368516 2368516 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1331116 1331116 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163459 1163459 0 0.0
bss 136528 136528 0 0.0
rodata 147364 147364 0 0.0
text 800940 800940 0 0.0
p6 all-clusters-app default (read/write) 2515120 2515120 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1473384 1473384 0 0.0
light-app default (read/write) 2415592 2415592 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373856 1373856 0 0.0
lock-app default (read/write) 2379160 2379160 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1337424 1337424 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801516 801516 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 570132 570132 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with @msandstedt's comment address.

@andy31415 andy31415 merged commit 728adc0 into project-chip:master Apr 19, 2022
vivien-apple added a commit to vivien-apple/connectedhomeip-1 that referenced this pull request Apr 29, 2022
@vivien-apple
[chip-tool] Revert commissioner-fabricid argument from project-chip#1…
2b02585 
…7309
vivien-apple added a commit to vivien-apple/connectedhomeip-1 that referenced this pull request Apr 29, 2022
@vivien-apple
[chip-tool] Revert commissioner-fabricid argument from project-chip#1…
8710a66 
…7309
@vivien-apple vivien-apple mentioned this pull request Apr 29, 2022
Merged
vivien-apple added a commit that referenced this pull request Apr 29, 2022
@vivien-apple
[chip-tool] Revert commissioner-fabricid argument from #17309 (#17913)
a960050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt left review comments

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivien-apple @tcarmelveilleux @msandstedt @bzbarsky-apple @andy31415