Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Use absolute paths in example's CMakeLists.txt files #16843

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

shubhamdp
Copy link
Contributor

Problem

  • Few paths in examples' CMakeLists.txt files uses relative paths. If esp32 application is moved to some other path other than examples/some-app/esp32 then build would fail.

Change overview

  • Use absolute path by using third_party/connectedhomeip symbolic link.

Testing

  • Manually built all-clusters-app/esp32 with default configuration
  • Manually built all-clusters-app/esp32 by enabling pw rpc, CONFIG_ENABLE_PW_RPC
  • CI pipeline must be green

@github-actions
Copy link

github-actions bot commented Mar 30, 2022

PR #16843: Size comparison from 0d98cc2 to 42ebe33

Decreases (1 build for esp32)
platform target config section 0d98cc2 42ebe33 change % change
esp32 all-clusters-app m5stack (read/write) 462636 462612 -24 -0.0
.flash.rodata 228832 228808 -24 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0d98cc2 42ebe33 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 608546 608546 0 0.0
.app_xip_area 515312 515312 0 0.0
.bss 75980 75980 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 566086 566086 0 0.0
.app_xip_area 474380 474380 0 0.0
.bss 74484 74484 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578170 578170 0 0.0
.app_xip_area 476808 476808 0 0.0
.bss 83820 83820 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 929492 929492 0 0.0
(read/write) 129108 129108 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 929484 929484 0 0.0
BRD4161A+rpc (read only) 958500 958500 0 0.0
(read/write) 145072 145072 0 0.0
.bss 142896 142896 0 0.0
.data 2176 2176 0 0.0
.text 958492 958492 0 0.0
window-app BRD4161A (read only) 858976 858976 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 858968 858968 0 0.0
esp32 all-clusters-app c3devkit (read only) 969434 969434 0 0.0
(read/write) 1394882 1394882 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 199320 199320 0 0.0
.flash.text 969434 969434 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1025047 1025047 0 0.0
(read/write) 462636 462612 -24 -0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228832 228808 -24 -0.0
.flash.text 1019663 1019663 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 706992 706992 0 0.0
.bss 77976 77976 0 0.0
.data 1876 1876 0 0.0
.text 621340 621340 0 0.0
lock k32w061+release (read/write) 706100 706100 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 620440 620440 0 0.0
linux all-clusters-app debug (read only) 2544289 2544289 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 217125 217125 0 0.0
.text 2163266 2163266 0 0.0
bridge-app debug+rpc (read only) 1776405 1776405 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145228 145228 0 0.0
.text 1515749 1515749 0 0.0
chip-tool debug (read only) 10321845 10321845 0 0.0
(read/write) 356784 356784 0 0.0
.bss 22528 22528 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 327000 327000 0 0.0
.dynamic 624 624 0 0.0
.got 4872 4872 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 526837 526837 0 0.0
.text 9007621 9007621 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9930612 9930612 0 0.0
(read/write) 475665 475665 0 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 373712 373712 0 0.0
.dynamic 560 560 0 0.0
.got 56232 56232 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 501468 501468 0 0.0
.text 8371124 8371124 0 0.0
door-lock-app debug (read only) 2029081 2029081 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181852 181852 0 0.0
.text 1697346 1697346 0 0.0
lighting-app debug+rpc (read only) 2206777 2206777 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175804 175804 0 0.0
.text 1871730 1871730 0 0.0
ota-provider-app debug (read only) 1969145 1969145 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167571 167571 0 0.0
.text 1649634 1649634 0 0.0
ota-requestor-app debug (read only) 1996641 1996641 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163756 163756 0 0.0
.text 1679938 1679938 0 0.0
shell debug (read only) 2457393 2457393 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210290 210290 0 0.0
.text 2090082 2090082 0 0.0
thermostat-no-ble arm64 (read only) 2286396 2286396 0 0.0
(read/write) 148401 148401 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4528 4528 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140220 140220 0 0.0
.text 1922688 1922688 0 0.0
tv-app debug (read only) 2705225 2705225 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206635 206635 0 0.0
.text 2323890 2323890 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358308 2358308 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1320908 1320908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1146395 1146395 0 0.0
bss 143056 143056 0 0.0
rodata 142660 142660 0 0.0
text 785832 785832 0 0.0
p6 all-clusters-app default (read/write) 2501304 2501304 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1459568 1459568 0 0.0
light-app default (read/write) 2403464 2403464 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1361728 1361728 0 0.0
lock-app default (read/write) 2367088 2367088 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1325352 1325352 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 790812 790812 0 0.0
bss 70272 70272 0 0.0
noinit 40416 40416 0 0.0
text 560818 560818 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit a36db55 into project-chip:master Apr 1, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@shubhamdp shubhamdp deleted the esp32_eg_abs_path branch August 18, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants