Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Fixed problem with building Light Switch app example without DFU #16819

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

ArekBalysNordic
Copy link
Contributor

Problem

  • The light Switch app example does not work without enabling DFU via BLE

Change overview

  • Fixed this problem. Now the LightSwitch app example works with all configurations.

Testing

  • Tested manually on nrf52840dk and nrf5340dk with each configuration (low-power, DFU BLE, DFU OTA) separately.

@github-actions
Copy link

github-actions bot commented Mar 30, 2022

PR #16819: Size comparison from 08906fb to 2651bf7

Full report (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08906fb 2651bf7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606810 606810 0 0.0
.app_xip_area 513580 513580 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564358 564358 0 0.0
.app_xip_area 472656 472656 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576538 576538 0 0.0
.app_xip_area 475188 475188 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927928 927928 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927920 927920 0 0.0
BRD4161A+rpc (read only) 956920 956920 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956912 956912 0 0.0
window-app BRD4161A (read only) 857412 857412 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857404 857404 0 0.0
esp32 all-clusters-app c3devkit (read only) 968374 968374 0 0.0
(read/write) 1394770 1394770 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199240 199240 0 0.0
.flash.text 968374 968374 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1024075 1024075 0 0.0
(read/write) 462532 462532 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228728 228728 0 0.0
.flash.text 1018691 1018691 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705392 705392 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619748 619748 0 0.0
lock k32w061+release (read/write) 704508 704508 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618848 618848 0 0.0
linux all-clusters-app debug (read only) 2536721 2536721 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216613 216613 0 0.0
.text 2156210 2156210 0 0.0
bridge-app debug+rpc (read only) 1770437 1770437 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145004 145004 0 0.0
.text 1510005 1510005 0 0.0
chip-tool debug (read only) 10311229 10311229 0 0.0
(read/write) 356456 356456 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326808 326808 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 525877 525877 0 0.0
.text 8999013 8999013 0 0.0
chip-tool-ipv6only arm64 (read only) 9923868 9923868 0 0.0
(read/write) 475441 475441 0 0.0
.bss 40753 40753 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 373536 373536 0 0.0
.dynamic 560 560 0 0.0
.got 56200 56200 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 501012 501012 0 0.0
.text 8365268 8365268 0 0.0
door-lock-app debug (read only) 2023065 2023065 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181596 181596 0 0.0
.text 1691586 1691586 0 0.0
lighting-app debug+rpc (read only) 2199433 2199433 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175452 175452 0 0.0
.text 1864738 1864738 0 0.0
ota-provider-app debug (read only) 1963457 1963457 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167371 167371 0 0.0
.text 1644146 1644146 0 0.0
ota-requestor-app debug (read only) 1990697 1990697 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163556 163556 0 0.0
.text 1674194 1674194 0 0.0
shell debug (read only) 2451489 2451489 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210066 210066 0 0.0
.text 2084402 2084402 0 0.0
thermostat-no-ble arm64 (read only) 2281172 2281172 0 0.0
(read/write) 148337 148337 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76952 76952 0 0.0
.dynamic 560 560 0 0.0
.got 4512 4512 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1917744 1917744 0 0.0
tv-app debug (read only) 2699113 2699113 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206443 206443 0 0.0
.text 2317970 2317970 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357388 2357388 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319988 1319988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144823 1144823 0 0.0
bss 143052 143052 0 0.0
rodata 142432 142432 0 0.0
text 784496 784496 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1130235 1130235 0 0.0
bss 139508 139508 0 0.0
rodata 119084 119084 0 0.0
text 793144 793144 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1094231 1094231 0 0.0
bss 139744 139744 0 0.0
rodata 110320 110320 0 0.0
text 765204 765204 0 0.0
nrf52840dongle_nrf52840 (read/write) 1143915 1143915 0 0.0
bss 140492 140492 0 0.0
rodata 118744 118744 0 0.0
text 795208 795208 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1039034 1039034 0 0.0
bss 136572 136572 0 0.0
rodata 112280 112280 0 0.0
text 708320 708320 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1030727 1030727 0 0.0
bss 129456 129456 0 0.0
rodata 112032 112032 0 0.0
text 710848 710848 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 939786 939786 0 0.0
bss 126552 126552 0 0.0
rodata 105280 105280 0 0.0
text 626176 626176 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1048627 1048627 0 0.0
bss 129368 129368 0 0.0
rodata 113740 113740 0 0.0
text 727044 727044 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1031835 1031835 0 0.0
bss 129116 129116 0 0.0
rodata 110308 110308 0 0.0
text 713944 713944 0 0.0
p6 all-clusters-app default (read/write) 2499976 2499976 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1458240 1458240 0 0.0
light-app default (read/write) 2402144 2402144 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360408 1360408 0 0.0
lock-app default (read/write) 2365760 2365760 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1324024 1324024 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 789148 789148 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559380 559380 0 0.0

@Damian-Nordic Damian-Nordic merged commit a20ba1c into project-chip:master Mar 31, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@ArekBalysNordic ArekBalysNordic deleted the light_switch_fix branch May 30, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants