Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nwprov] Add missing debugText and index to some synchronous commands #16676

Merged
merged 13 commits into from
Mar 30, 2022
Merged

[nwprov] Add missing debugText and index to some synchronous commands #16676

merged 13 commits into from
Mar 30, 2022

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Mar 25, 2022 •
edited
Loading

Problem

Fixes #15781

Change overview

Add debug text and network index to some synchronous commands on the driver side.
No platform update required for now, since we only support exactly one network on all platforms, in this case, network index will always be 0.

Testing

  • Updated test script

@restyled-io restyled-io bot mentioned this pull request Mar 25, 2022
Closed
@erjiaqing erjiaqing force-pushed the nwprov-final/fix-missing-network-index-field branch from ae61125 to a18685f Compare March 25, 2022 15:50
Damian-Nordic
Damian-Nordic approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please fix the one place where outDebugText is not set properly.

src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

PR #16676: Size comparison from 8da5d03 to 18666d6

Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 8da5d03 18666d6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606194 606458 264 0.0
.app_xip_area 512964 513228 264 0.1
lock cyw930739m2evb_01 (read/write) 563734 563990 256 0.0
.app_xip_area 472032 472288 256 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575994 576242 248 0.0
.app_xip_area 474644 474892 248 0.1
efr32 lighting-app BRD4161A (read only) 927264 927584 320 0.0
.text 927256 927576 320 0.0
BRD4161A+rpc (read only) 956272 956592 320 0.0
.text 956264 956584 320 0.0
window-app BRD4161A (read only) 856748 857068 320 0.0
.text 856740 857060 320 0.0
esp32 all-clusters-app c3devkit (read only) 967810 968090 280 0.0
.flash.text 967810 968090 280 0.0
m5stack (read only) 1023499 1023763 264 0.0
.flash.text 1018115 1018379 264 0.0
k32w light k32w061+release (read/write) 704784 705040 256 0.0
.text 619140 619396 256 0.0
lock k32w061+release (read/write) 703900 704156 256 0.0
.text 618240 618496 256 0.0
linux all-clusters-app debug (read only) 2533833 2535545 1712 0.1
.rodata 216357 216677 320 0.1
.text 2153650 2155042 1392 0.1
chip-tool debug (read only) 10228533 10228885 352 0.0
.text 8924837 8925189 352 0.0
chip-tool-ipv6only arm64 (read only) 9849708 9850028 320 0.0
.rodata 494484 494500 16 0.0
.text 8302004 8302308 304 0.0
lighting-app debug+rpc (read only) 2196545 2198017 1472 0.1
.rodata 175196 175356 160 0.1
.text 1862178 1863490 1312 0.1
thermostat-no-ble arm64 (read only) 2278468 2279444 976 0.0
.text 1915264 1916240 976 0.1
tv-app debug (read only) 2696209 2696465 256 0.0
.text 2315394 2315650 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144215 1144455 240 0.0
text 784004 784248 244 0.0
p6 all-clusters-app default (read/write) 2499312 2499648 336 0.0
.text 1457576 1457912 336 0.0
light-app default (read/write) 2401496 2401816 320 0.0
.text 1359760 1360080 320 0.0
lock-app default (read/write) 2365112 2365432 320 0.0
.text 1323376 1323696 320 0.0
telink lighting-app tlsr9518adk80d (read/write) 788424 788688 264 0.0
text 558792 559050 258 0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 8da5d03 18666d6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606194 606458 264 0.0
.app_xip_area 512964 513228 264 0.1
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563734 563990 256 0.0
.app_xip_area 472032 472288 256 0.1
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575994 576242 248 0.0
.app_xip_area 474644 474892 248 0.1
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927264 927584 320 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927256 927576 320 0.0
BRD4161A+rpc (read only) 956272 956592 320 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956264 956584 320 0.0
window-app BRD4161A (read only) 856748 857068 320 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 856740 857060 320 0.0
esp32 all-clusters-app c3devkit (read only) 967810 968090 280 0.0
(read/write) 1394642 1394642 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199112 199112 0 0.0
.flash.text 967810 968090 280 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023499 1023763 264 0.0
(read/write) 462404 462404 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228600 228600 0 0.0
.flash.text 1018115 1018379 264 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704784 705040 256 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619140 619396 256 0.0
lock k32w061+release (read/write) 703900 704156 256 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618240 618496 256 0.0
linux all-clusters-app debug (read only) 2533833 2535545 1712 0.1
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216357 216677 320 0.1
.text 2153650 2155042 1392 0.1
bridge-app debug+rpc (read only) 1767533 1767533 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144716 144716 0 0.0
.text 1507461 1507461 0 0.0
chip-tool debug (read only) 10228533 10228885 352 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 519157 519157 0 0.0
.text 8924837 8925189 352 0.0
chip-tool-ipv6only arm64 (read only) 9849708 9850028 320 0.0
(read/write) 473713 473713 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55368 55368 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494484 494500 16 0.0
.text 8302004 8302308 304 0.0
door-lock-app debug (read only) 2020193 2020193 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181340 181340 0 0.0
.text 1689042 1689042 0 0.0
lighting-app debug+rpc (read only) 2196545 2198017 1472 0.1
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175196 175356 160 0.1
.text 1862178 1863490 1312 0.1
ota-provider-app debug (read only) 1960825 1960825 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167147 167147 0 0.0
.text 1641810 1641810 0 0.0
ota-requestor-app debug (read only) 1987793 1987793 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163268 163268 0 0.0
.text 1671650 1671650 0 0.0
shell debug (read only) 2448601 2448601 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209810 209810 0 0.0
.text 2081842 2081842 0 0.0
thermostat-no-ble arm64 (read only) 2278468 2279444 976 0.0
(read/write) 148305 148305 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139908 139908 0 0.0
.text 1915264 1916240 976 0.1
tv-app debug (read only) 2696209 2696465 256 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206187 206187 0 0.0
.text 2315394 2315650 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144215 1144455 240 0.0
bss 143052 143052 0 0.0
rodata 142304 142304 0 0.0
text 784004 784248 244 0.0
p6 all-clusters-app default (read/write) 2499312 2499648 336 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1457576 1457912 336 0.0
light-app default (read/write) 2401496 2401816 320 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1359760 1360080 320 0.0
lock-app default (read/write) 2365112 2365432 320 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1323376 1323696 320 0.0
telink lighting-app tlsr9518adk80d (read/write) 788424 788688 264 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 558792 559050 258 0.0

@github-actions
Copy link

PR #16676: Size comparison from 1456eb1 to 1a4c8ad

Increases (1 build for nrfconnect)
platform target config section 1456eb1 1a4c8ad change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144595 1145435 840 0.1
rodata 142364 142516 152 0.1
text 784336 785020 684 0.1
Full report (1 build for nrfconnect)
platform target config section 1456eb1 1a4c8ad change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144595 1145435 840 0.1
bss 143052 143052 0 0.0
rodata 142364 142516 152 0.1
text 784336 785020 684 0.1

@erjiaqing erjiaqing merged commit 4005949 into project-chip:master Mar 30, 2022
@erjiaqing erjiaqing deleted the nwprov-final/fix-missing-network-index-field branch March 30, 2022 15:43
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@erjiaqing @rochaferraz
[nwprov] Add missing debugText and index to some synchronous commands (…
b7d41f3 
…project-chip#16676)

* [nwprov] Add missing debugText and index to some synchronous commands

* string search / replace for platform code

* Run codegen

* Address comments

* Update examples

* Fix

* Fix

* Fix

* Fix

* Run Codegen
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@erjiaqing @andrei-menzopol
[nwprov] Add missing debugText and index to some synchronous commands (…
82e100a 
…project-chip#16676)

* [nwprov] Add missing debugText and index to some synchronous commands

* string search / replace for platform code

* Run codegen

* Address comments

* Update examples

* Fix

* Fix

* Fix

* Fix

* Run Codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkIndex argument missing in NetworkConfigResponse command - Network commissioning
3 participants
@erjiaqing @bzbarsky-apple @Damian-Nordic