Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] support custom build config for external platform #16618

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[build] support custom build config for external platform #16618

merged 1 commit into from
Mar 30, 2022

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Mar 24, 2022 •
edited
Loading

Problem

The ChipDeviceBuildConfig.h is generated by the internal platform BUILD.gn for external platforms and cannot be overridden.

Change overview

Allow external device layers to generate its own build config.

Add external device layer support for ESP32.

Testing

External platforms not included in the PR.
Common build can be verified by the CI.

@restyled-io restyled-io bot mentioned this pull request Mar 24, 2022
Closed
@gjc13 gjc13 force-pushed the external-platform-buildconfig branch 2 times, most recently from 390f32f to 2fb2902 Compare March 24, 2022 14:05
@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

PR #16618: Size comparison from 011efcf to 2fb2902

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 011efcf0 2fb2902 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603562 603562 0 0.0
.app_xip_area 510732 510732 0 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561350 561350 0 0.0
.app_xip_area 470048 470048 0 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573426 573426 0 0.0
.app_xip_area 472476 472476 0 0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 923432 923432 0 0.0
(read/write) 128680 128680 0 0.0
.bss 126680 126680 0 0.0
.data 1996 1996 0 0.0
.text 923424 923424 0 0.0
BRD4161A+rpc (read only) 952240 952240 0 0.0
(read/write) 144632 144632 0 0.0
.bss 142456 142456 0 0.0
.data 2176 2176 0 0.0
.text 952232 952232 0 0.0
window-app BRD4161A (read only) 853220 853220 0 0.0
(read/write) 126648 126648 0 0.0
.bss 124776 124776 0 0.0
.data 1872 1872 0 0.0
.text 853212 853212 0 0.0
esp32 all-clusters-app c3devkit (read only) 964804 964804 0 0.0
(read/write) 1394194 1394194 0 0.0
.dram0.bss 61992 61992 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 199064 199064 0 0.0
.flash.text 964804 964804 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1021107 1021107 0 0.0
(read/write) 461940 461940 0 0.0
.dram0.bss 67520 67520 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228560 228560 0 0.0
.flash.text 1015723 1015723 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701704 701704 0 0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 616460 616460 0 0.0
lock k32w061+release (read/write) 701156 701156 0 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 615896 615896 0 0.0
linux all-clusters-app debug (read only) 2483153 2483153 0 0.0
(read/write) 143344 143344 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 212229 212229 0 0.0
.text 2107202 2107202 0 0.0
bridge-app debug+rpc (read only) 1755461 1755461 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44552 44552 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144300 144300 0 0.0
.text 1495925 1495925 0 0.0
chip-tool debug (read only) 10216325 10216325 0 0.0
(read/write) 355456 355456 0 0.0
.bss 22496 22496 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325800 325800 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 521141 521141 0 0.0
.text 8911253 8911253 0 0.0
chip-tool-ipv6only arm64 (read only) 9832668 9832668 0 0.0
(read/write) 473889 473889 0 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372312 372312 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496516 496516 0 0.0
.text 8282052 8282052 0 0.0
door-lock-app debug (read only) 2007345 2007345 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47680 47680 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180956 180956 0 0.0
.text 1676706 1676706 0 0.0
lighting-app debug+rpc (read only) 2181289 2181289 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48960 48960 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 174972 174972 0 0.0
.text 1847250 1847250 0 0.0
ota-provider-app debug (read only) 1948393 1948393 0 0.0
(read/write) 112624 112624 0 0.0
.bss 47552 47552 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166699 166699 0 0.0
.text 1629954 1629954 0 0.0
ota-requestor-app debug (read only) 1975201 1975201 0 0.0
(read/write) 115880 115880 0 0.0
.bss 48544 48544 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60408 60408 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162692 162692 0 0.0
.text 1659858 1659858 0 0.0
shell debug (read only) 2431945 2431945 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67336 67336 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209682 209682 0 0.0
.text 2065394 2065394 0 0.0
thermostat-no-ble arm64 (read only) 2266140 2266140 0 0.0
(read/write) 148385 148385 0 0.0
.bss 62833 62833 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139708 139708 0 0.0
.text 1903024 1903024 0 0.0
tv-app debug (read only) 2681737 2681737 0 0.0
(read/write) 247872 247872 0 0.0
.bss 164512 164512 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74160 74160 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206933 206933 0 0.0
.text 2299906 2299906 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353772 2353772 0 0.0
.bss 184572 184572 0 0.0
.data 5760 5760 0 0.0
.text 1316372 1316372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140039 1140039 0 0.0
bss 142512 142512 0 0.0
rodata 141912 141912 0 0.0
text 780764 780764 0 0.0
p6 all-clusters-app default (read/write) 2494984 2494984 0 0.0
.bss 117992 117992 0 0.0
.data 2640 2640 0 0.0
.text 1453248 1453248 0 0.0
light-app default (read/write) 2397360 2397360 0 0.0
.bss 111464 111464 0 0.0
.data 2496 2496 0 0.0
.text 1355624 1355624 0 0.0
lock-app default (read/write) 2360888 2360888 0 0.0
.bss 111208 111208 0 0.0
.data 2456 2456 0 0.0
.text 1319152 1319152 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896606 896606 0 0.0
bss 87356 87356 0 0.0
noinit 37160 37160 0 0.0
text 633984 633984 0 0.0

woody-apple
woody-apple approved these changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking changes, given this is supporting a build system outside the SDK

@bzbarsky-apple bzbarsky-apple merged commit d3dd5e0 into project-chip:master Mar 30, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@gjc13 @rochaferraz
[build] support custom build config for external platform (project-ch…
c50a360 
…ip#16618)
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@gjc13 @andrei-menzopol
[build] support custom build config for external platform (project-ch…
212f6de 
…ip#16618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrishi dhrishi dhrishi approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
ble config fast track platform review - pending system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gjc13 @dhrishi @woody-apple @bzbarsky-apple