Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ble] update ble advertisement packet format #1649

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Jul 20, 2020

Update the packet format to be coherent with the current specification.

Summary of Changes

This PR will send CHIP specified BLE advertisement packets. The discriminator is now hardcoded and shall be derived from the factory data in future changes.

fixes #1648

Update the packet format to be coherent with the current specification.
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2020

This pull request introduces 1 alert when merging 75c637a into c57e482 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text -16 -16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_loc,0,207
.debug_info,0,91
.debug_line,0,46
.debug_abbrev,0,18
[Unmapped],0,11
.debug_frame,0,-4
.text,-16,-16
.debug_str,0,-77
.debug_ranges,0,-120


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.text 44 44
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.shstrtab,0,161
.xt.prop._ZN4chip3Ble31ChipBLEDeviceIdentificationInfo22SetDeviceDiscriminatorEt,0,76
.strtab,0,72
.symtab,0,48
.flash.text,44,44
.debug_line,0,41
.xt.lit._ZN4chip11DeviceLayer8Internal31GenericConfigurationManagerImplINS0_24ConfigurationManagerImplEE31_GetBLEDeviceIdentificationInfoERNS_3Ble31ChipBLEDeviceIdentificationInfoE,0,40
.debug_frame,0,20
.debug_abbrev,0,16
.debug_aranges,0,8
.debug_ranges,0,8
.debug_str,0,-91
.debug_info,0,-95


@woody-apple
Copy link
Contributor

@andy31415 @jelderton ?

@woody-apple
Copy link
Contributor

@robszewczyk ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The BLE advertisement packet format is not coherent with the specification
5 participants