[IM] Record LastReportTick and DirtyTick in ReadHandler #16060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b77dc5 to
cac6273
Compare
cac6273 to
503b9cc
Compare
mrjerryjohns
approved these changes
Mar 23, 2022
|
PR #16060: Size comparison from 4ea2bae to 41ab797 Increases above 0.2%:
Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (1 build for linux)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
53c235e to
7952064
Compare
|
PR #16060: Size comparison from 197f65f to 7952064 Increases above 0.2%:
Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 25, 2022
|
/rebase |
|
Fast tracking given this has had > 3 days for review. |
| // Here we just reset the iterator to the beginning of the current cluster, if the dirty path affects it. | ||
| // This will ensure the reports are consistent within a single cluster generated from a single path in the request. | ||
|
|
||
| // TODO (#16699): Currently we can only gurentee the reports generated from a single path in the request are consistent. The |
There was a problem hiding this comment.
"guarantee", not "gurentee".
Comment on lines
+303
to
+309
| // For subscriptions, we record the dirty set generation when we started to generate the last report. | ||
| // The mCurrentReportsBeginGeneration records the generation at the start of the current report. This only/ | ||
| // has a meaningful value while IsReporting() is true. | ||
| // | ||
| // mPreviousReportsBeginGeneration will be set to mCurrentReportsBeginGeneration after we send the last | ||
| // chunk of the current report. Anything that was dirty with a generation earlier than | ||
| // mPreviousReportsBeginGeneration has had its value sent to the client. |
There was a problem hiding this comment.
This does not look like the right comment for mForceDirty. Merge issue?
Comment on lines
+311
to
+315
| // For subscriptions, we record the timestamp when we started to generate the last report. | ||
| // The mCurrentReportsBeginGeneration records the timestamp for the current report, which won;t be used for checking if this | ||
| // ReadHandler is dirty. | ||
| // mPreviousReportsBeginGeneration will be set to mCurrentReportsBeginGeneration after we sent the last chunk of the current | ||
| // report. |
There was a problem hiding this comment.
This is where the comment that's above mForceDirty should be...
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…#16060) * [IM] Record LastRecordTimestamp and DirtyTimestamp in ReadHandler * Update naming and comments * Add more tests * Fix * Update tests * Address comments * Resolve compile error * Drive IO for a bit longer time * Address comments * Lift timelimit for darwin * Tick -> Generation
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…#16060) * [IM] Record LastRecordTimestamp and DirtyTimestamp in ReadHandler * Update naming and comments * Add more tests * Fix * Update tests * Address comments * Resolve compile error * Drive IO for a bit longer time * Address comments * Lift timelimit for darwin * Tick -> Generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #15975
During priming report, the report might be large, and if there are any attributes changed during the report, we will do a full regeneration, makes the report unable to finish.
Change overview
Testing