Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Darwin CHIPDevice data object format #16049

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Update Darwin CHIPDevice data object format #16049

merged 1 commit into from
Mar 15, 2022

Conversation

kpark-apple
Copy link
Contributor

Problem

Change overview

  • CHIPAttributePath object and CHIPCommandPath object are used for paths
    instead of individual dictionary keys for path elements.
  • NSError object replaces implementation specific status value.
  • List TLV conversion code was removed.
  • Implementation specific tag is replaced with context tag number just
    for Structure TLV.
  • 64 bit int conversion was fixed.
  • new operator was replaced with Platform::New.
  • Float and double TLV decoding was fixed to distinguish them.
  • Potential buffer overrun during UTF8String TLV conversion was fixed.
  • String constant names were corrected.
  • Method header comments were corrected.

Testing

  • Previous unit tests and integration tests were updated to verify the object and decoding changes.

@boring-cyborg boring-cyborg bot added the darwin label Mar 10, 2022
@github-actions
Copy link

github-actions bot commented Mar 10, 2022 •
edited
Loading

PR #16049: Size comparison from 190520d to f40d7a2

Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 190520d f40d7a2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598058 598058 0 0.0
.app_xip_area 505640 505640 0 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555926 555926 0 0.0
.app_xip_area 465044 465044 0 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566030 566030 0 0.0
.app_xip_area 465444 465444 0 0.0
.bss 82996 82996 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919872 919872 0 0.0
(read/write) 128264 128264 0 0.0
.bss 126224 126224 0 0.0
.data 2040 2040 0 0.0
.text 919864 919864 0 0.0
BRD4161A+rpc (read only) 948700 948700 0 0.0
(read/write) 144220 144220 0 0.0
.bss 142000 142000 0 0.0
.data 2220 2220 0 0.0
.text 948692 948692 0 0.0
window-app BRD4161A (read only) 852348 852348 0 0.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 852340 852340 0 0.0
esp32 all-clusters-app c3devkit (read only) 957736 957736 0 0.0
(read/write) 1393778 1393778 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197064 197064 0 0.0
.flash.text 957736 957736 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012887 1012887 0 0.0
(read/write) 461028 461028 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226032 226032 0 0.0
.flash.text 1007503 1007503 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694492 694492 0 0.0
.bss 77160 77160 0 0.0
.data 1924 1924 0 0.0
.text 609608 609608 0 0.0
lock k32w061+release (read/write) 695292 695292 0 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 610456 610456 0 0.0
linux all-clusters-app debug (read only) 2430321 2430321 0 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205637 205637 0 0.0
.text 2061698 2061698 0 0.0
bridge-app debug+rpc (read only) 1735493 1735493 0 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141868 141868 0 0.0
.text 1477653 1477653 0 0.0
chip-tool debug (read only) 10093045 10093045 0 0.0
(read/write) 358168 358168 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514196 514196 0 0.0
.text 8796165 8796165 0 0.0
chip-tool-ipv6only arm64 (read only) 9729052 9729052 0 0.0
(read/write) 475969 475969 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55304 55304 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491908 491908 0 0.0
.text 8185956 8185956 0 0.0
door-lock-app debug (read only) 1949953 1949953 0 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173756 173756 0 0.0
.text 1627554 1627554 0 0.0
lighting-app debug+rpc (read only) 2082121 2082121 0 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165948 165948 0 0.0
.text 1760514 1760514 0 0.0
ota-provider-app debug (read only) 1883193 1883193 0 0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158963 158963 0 0.0
.text 1573506 1573506 0 0.0
ota-requestor-app debug (read only) 1910801 1910801 0 0.0
(read/write) 117864 117864 0 0.0
.bss 51584 51584 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59368 59368 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154924 154924 0 0.0
.text 1605362 1605362 0 0.0
shell debug (read only) 2396513 2396513 0 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205586 205586 0 0.0
.text 2034354 2034354 0 0.0
thermostat-no-ble arm64 (read only) 2178620 2178620 0 0.0
(read/write) 148817 148817 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133116 133116 0 0.0
.text 1826912 1826912 0 0.0
tv-app debug (read only) 2622009 2622009 0 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199293 199293 0 0.0
.text 2248626 2248626 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351356 2351356 0 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1313956 1313956 0 0.0
p6 all-clusters-app default (read/write) 2494216 2494216 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1452480 1452480 0 0.0
light-app default (read/write) 2398296 2398296 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1356560 1356560 0 0.0
lock-app default (read/write) 2361856 2361856 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320120 1320120 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888882 888882 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628184 628184 0 0.0

@kpark-apple kpark-apple force-pushed the fix/kpark/20220309-chipdevice-response-data branch from f40d7a2 to c6619b2 Compare March 11, 2022 15:20
@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16049: Size comparison from 86a8444 to c6619b2

Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 86a8444 c6619b2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599102 0 0.0
.app_xip_area 506700 506700 0 0.0
.bss 75108 75108 0 0.0
.data 640 640 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 556986 0 0.0
.app_xip_area 466112 466112 0 0.0
.bss 73612 73612 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566766 0 0.0
.app_xip_area 466228 466228 0 0.0
.bss 82932 82932 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921128 921128 0 0.0
(read/write) 128232 128232 0 0.0
.bss 126176 126176 0 0.0
.data 2052 2052 0 0.0
.text 921120 921120 0 0.0
BRD4161A+rpc (read only) 949940 949940 0 0.0
(read/write) 144184 144184 0 0.0
.bss 141952 141952 0 0.0
.data 2232 2232 0 0.0
.text 949932 949932 0 0.0
window-app BRD4161A (read only) 853732 853732 0 0.0
(read/write) 126216 126216 0 0.0
.bss 124312 124312 0 0.0
.data 1904 1904 0 0.0
.text 853724 853724 0 0.0
esp32 all-clusters-app c3devkit (read only) 958524 958524 0 0.0
(read/write) 1393858 1393858 0 0.0
.dram0.bss 63584 63584 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197144 197144 0 0.0
.flash.text 958524 958524 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014127 0 0.0
(read/write) 461092 461092 0 0.0
.dram0.bss 69104 69104 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 226104 226104 0 0.0
.flash.text 1008743 1008743 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695388 695388 0 0.0
.bss 77112 77112 0 0.0
.data 1928 1928 0 0.0
.text 610548 610548 0 0.0
lock k32w061+release (read/write) 696360 696360 0 0.0
.bss 77080 77080 0 0.0
.data 1952 1952 0 0.0
.text 611528 611528 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9729660 9729660 0 0.0
(read/write) 475729 475729 0 0.0
.bss 43953 43953 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 371520 371520 0 0.0
.dynamic 560 560 0 0.0
.got 55280 55280 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492148 0 0.0
.text 8186868 8186868 0 0.0
thermostat-no-ble arm64 (read only) 2181588 2181588 0 0.0
(read/write) 148625 148625 0 0.0
.bss 65409 65409 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 74968 74968 0 0.0
.dynamic 560 560 0 0.0
.got 4256 4256 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133444 133444 0 0.0
.text 1829984 1829984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2351012 0 0.0
.bss 186212 186212 0 0.0
.data 5784 5784 0 0.0
.text 1313612 1313612 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152643 0 0.0
bss 146188 146188 0 0.0
rodata 144516 144516 0 0.0
text 786676 786676 0 0.0
p6 all-clusters-app default (read/write) 2495680 2495680 0 0.0
.bss 119640 119640 0 0.0
.data 2672 2672 0 0.0
.text 1453944 1453944 0 0.0
light-app default (read/write) 2399680 2399680 0 0.0
.bss 113104 113104 0 0.0
.data 2528 2528 0 0.0
.text 1357944 1357944 0 0.0
lock-app default (read/write) 2363240 2363240 0 0.0
.bss 112848 112848 0 0.0
.data 2488 2488 0 0.0
.text 1321504 1321504 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889766 889766 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 628970 628970 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 12, 2022
View reviewed changes
src/darwin/Framework/CHIP/CHIPDevice.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/CHIPDevice.h Show resolved Hide resolved
src/darwin/Framework/CHIP/CHIPDevice.mm Show resolved Hide resolved
src/darwin/Framework/CHIP/CHIPDeviceController+XPC.h Outdated Show resolved Hide resolved
@kpark-apple kpark-apple force-pushed the fix/kpark/20220309-chipdevice-response-data branch from c6619b2 to 70f660f Compare March 12, 2022 17:08
@github-actions
Copy link

github-actions bot commented Mar 12, 2022 •
edited
Loading

PR #16049: Size comparison from c2be9bc to 70f660f

Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section c2be9bc 70f660f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602530 602530 0 0.0
.app_xip_area 509708 509708 0 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560390 560390 0 0.0
.app_xip_area 469096 469096 0 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570002 570002 0 0.0
.app_xip_area 469060 469060 0 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918144 918144 0 0.0
(read/write) 128656 128656 0 0.0
.bss 126648 126648 0 0.0
.data 2008 2008 0 0.0
.text 918136 918136 0 0.0
BRD4161A+rpc (read only) 946932 946932 0 0.0
(read/write) 144612 144612 0 0.0
.bss 142424 142424 0 0.0
.data 2188 2188 0 0.0
.text 946924 946924 0 0.0
window-app BRD4161A (read only) 850616 850616 0 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850608 850608 0 0.0
esp32 all-clusters-app c3devkit (read only) 961344 961344 0 0.0
(read/write) 1394994 1394994 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197832 197832 0 0.0
.flash.text 961344 961344 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1016963 1016963 0 0.0
(read/write) 462204 462204 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226776 226776 0 0.0
.flash.text 1011579 1011579 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699052 699052 0 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 613804 613804 0 0.0
lock k32w061+release (read/write) 699884 699884 0 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614624 614624 0 0.0
linux all-clusters-app debug (read only) 2465009 2465009 0 0.0
(read/write) 146384 146384 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2090994 2090994 0 0.0
bridge-app debug+rpc (read only) 1749589 1749589 0 0.0
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143372 143372 0 0.0
.text 1490581 1490581 0 0.0
chip-tool debug (read only) 10094493 10094493 0 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514965 514965 0 0.0
.text 8798277 8798277 0 0.0
chip-tool-ipv6only arm64 (read only) 9727788 9727788 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492244 492244 0 0.0
.text 8185700 8185700 0 0.0
door-lock-app debug (read only) 1984225 1984225 0 0.0
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178460 178460 0 0.0
.text 1656786 1656786 0 0.0
lighting-app debug+rpc (read only) 2115753 2115753 0 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170972 170972 0 0.0
.text 1788786 1788786 0 0.0
ota-provider-app debug (read only) 1917489 1917489 0 0.0
(read/write) 115536 115536 0 0.0
.bss 50816 50816 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 163691 163691 0 0.0
.text 1602738 1602738 0 0.0
ota-requestor-app debug (read only) 1945745 1945745 0 0.0
(read/write) 118536 118536 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59848 59848 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160068 160068 0 0.0
.text 1634466 1634466 0 0.0
shell debug (read only) 2410849 2410849 0 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207474 207474 0 0.0
.text 2047138 2047138 0 0.0
thermostat-no-ble arm64 (read only) 2206980 2206980 0 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136820 136820 0 0.0
.text 1850848 1850848 0 0.0
tv-app debug (read only) 2655601 2655601 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204245 204245 0 0.0
.text 2277218 2277218 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156219 1156219 0 0.0
bss 146644 146644 0 0.0
rodata 145220 145220 0 0.0
text 789208 789208 0 0.0
p6 all-clusters-app default (read/write) 2492128 2492128 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450392 1450392 0 0.0
light-app default (read/write) 2395992 2395992 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354256 1354256 0 0.0
lock-app default (read/write) 2359536 2359536 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317800 1317800 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893842 893842 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631882 631882 0 0.0

@kpark-apple
Update Darwin CHIPDevice data object format
0e7ad6d 
* CHIPAttributePath object and CHIPCommandPath object are used for paths
  instead of individual dictionary keys for path elements.
* NSError object replaces implementation specific status value.
* List TLV conversion code was removed.
* Implementation specific tag is replaced with context tag number just
  for Structure TLV.
* 64 bit int conversion was fixed.
* new operator was replaced with Platform::New.
* Float and double TLV decoding was fixed to distinguish them.
* Potential buffer overrun during UTF8String TLV conversion was fixed.
* String constant names were corrected.
* Method header comments were corrected.
@kpark-apple kpark-apple force-pushed the fix/kpark/20220309-chipdevice-response-data branch from 70f660f to 0e7ad6d Compare March 14, 2022 21:30
@github-actions
Copy link

github-actions bot commented Mar 14, 2022 •
edited
Loading

PR #16049: Size comparison from 510069d to 0e7ad6d

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 510069d 0e7ad6d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602578 0 0.0
.app_xip_area 509756 509756 0 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560430 0 0.0
.app_xip_area 469136 469136 0 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570538 570538 0 0.0
.app_xip_area 469596 469596 0 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919700 919700 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919692 919692 0 0.0
BRD4161A+rpc (read only) 948488 948488 0 0.0
(read/write) 144632 144632 0 0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948480 948480 0 0.0
window-app BRD4161A (read only) 850392 850392 0 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850384 850384 0 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961388 0 0.0
(read/write) 1394938 1394938 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 961388 961388 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017011 0 0.0
(read/write) 462148 462148 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226720 0 0.0
.flash.text 1011627 1011627 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699388 699388 0 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614140 614140 0 0.0
lock k32w061+release (read/write) 699644 699644 0 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614384 0 0.0
linux all-clusters-app debug (read only) 2465225 2465225 0 0.0
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2091298 2091298 0 0.0
bridge-app debug+rpc (read only) 1749757 1749757 0 0.0
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143308 143308 0 0.0
.text 1490901 1490901 0 0.0
chip-tool debug (read only) 10094989 10094989 0 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514997 514997 0 0.0
.text 8798741 8798741 0 0.0
chip-tool-ipv6only arm64 (read only) 9728060 9728060 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492196 0 0.0
.text 8186020 8186020 0 0.0
door-lock-app debug (read only) 1984385 1984385 0 0.0
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178396 178396 0 0.0
.text 1657090 1657090 0 0.0
lighting-app debug+rpc (read only) 2115961 2115961 0 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170940 170940 0 0.0
.text 1789106 1789106 0 0.0
ota-provider-app debug (read only) 1917697 1917697 0 0.0
(read/write) 115504 115504 0 0.0
.bss 50816 50816 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 163659 163659 0 0.0
.text 1603058 1603058 0 0.0
ota-requestor-app debug (read only) 1949265 1949265 0 0.0
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160292 160292 0 0.0
.text 1637746 1637746 0 0.0
shell debug (read only) 2411385 2411385 0 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207474 207474 0 0.0
.text 2047762 2047762 0 0.0
thermostat-no-ble arm64 (read only) 2207236 2207236 0 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136756 0 0.0
.text 1851168 1851168 0 0.0
tv-app debug (read only) 2656065 2656065 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204213 204213 0 0.0
.text 2277794 2277794 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154043 1154043 0 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 787016 787016 0 0.0
p6 all-clusters-app default (read/write) 2492152 2492152 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450416 0 0.0
light-app default (read/write) 2396000 2396000 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354264 0 0.0
lock-app default (read/write) 2359544 2359544 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893770 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631868 0 0.0

@andy31415 andy31415 merged commit eac433a into project-chip:master Mar 15, 2022
@kpark-apple kpark-apple deleted the fix/kpark/20220309-chipdevice-response-data branch March 15, 2022 18:22
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@kpark-apple @andrei-menzopol
Update Darwin CHIPDevice data object format (project-chip#16049)
d53d5d8 
* CHIPAttributePath object and CHIPCommandPath object are used for paths
  instead of individual dictionary keys for path elements.
* NSError object replaces implementation specific status value.
* List TLV conversion code was removed.
* Implementation specific tag is replaced with context tag number just
  for Structure TLV.
* 64 bit int conversion was fixed.
* new operator was replaced with Platform::New.
* Float and double TLV decoding was fixed to distinguish them.
* Potential buffer overrun during UTF8String TLV conversion was fixed.
* String constant names were corrected.
* Method header comments were corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpark-apple @andy31415 @woody-apple @bzbarsky-apple