-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removal of all fabrics in CHIPTool #15982
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
sagar-apple:remove_all_fabrics
Mar 9, 2022
Merged
Fix removal of all fabrics in CHIPTool #15982
bzbarsky-apple
merged 3 commits into
project-chip:master
from
sagar-apple:remove_all_fabrics
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #15982: Size comparison from a69fde3 to ff0a874 Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
/rebase |
ff0a874
to
d31e046
Compare
PR #15982: Size comparison from 102cd77 to d31e046 Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
/rebase |
d31e046
to
d06e287
Compare
PR #15982: Size comparison from 4d18b49 to d06e287 Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 9, 2022
/rebase |
d06e287
to
f59e2f1
Compare
PR #15982: Size comparison from cd44f9b to f59e2f1 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast-tracking platform change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes: #15942
Change overview
Remove our own fabric at the very end of the removal loop.
Testing
Tested with CHIPTool iOS, it's a little random. I didn't see the issue.