-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the test timeout always command-line configurable for YAML tests. #15973
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:test-timeout-configurable
Mar 8, 2022
Merged
Make the test timeout always command-line configurable for YAML tests. #15973
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:test-timeout-configurable
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06c4ac9
to
867b282
Compare
867b282
to
65f0afc
Compare
krypton36
approved these changes
Mar 8, 2022
woody-apple
approved these changes
Mar 8, 2022
Fast tracking testing updates. |
PR #15973: Size comparison from 949bd86 to 65f0afc Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
65f0afc
to
02d70df
Compare
PR #15973: Size comparison from 949bd86 to 02d70df Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
A test's timeout was only configurable if "timeout" was set in the YAML. Make sure the codegen acts as if that is always set. Also modifies zap_regen_all.py to clearly list all the things it's planning to run to generate things up front, and adds chip-tool-darwin to the set of things it generates. Also adds a --dry-run option to zap_regen_all.py to just list the targets and exit.
02d70df
to
64558d8
Compare
PR #15973: Size comparison from a69fde3 to 64558d8 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test's timeout was only configurable if "timeout" was set in the
YAML. Make sure the codegen acts as if that is always set.
Also modifies zap_regen_all.py to clearly list all the things it's
planning to run to generate things up front, and adds chip-tool-darwin
to the set of things it generates.
Also adds a --dry-run option to zap_regen_all.py to just list the
targets and exit.
Problem
See above.
Change overview
Make the "timeout" config variable always be present.
Testing
Examined the new codegen.